* [PATCH] net: diag: add missing declarations
@ 2016-06-09 11:17 Ben Dooks
2016-06-09 14:10 ` Eric Dumazet
0 siblings, 1 reply; 3+ messages in thread
From: Ben Dooks @ 2016-06-09 11:17 UTC (permalink / raw)
To: linux-kernel; +Cc: Ben Dooks, David S. Miller, netdev, linux-kernel
The functions inet_diag_msg_common_fill and inet_diag_msg_attrs_fill
seem to have been missed from the include/linux/inet_diag.h header
file. Add them to fix the following warnings:
net/ipv4/inet_diag.c:69:6: warning: symbol 'inet_diag_msg_common_fill' was not declared. Should it be static?
net/ipv4/inet_diag.c:108:5: warning: symbol 'inet_diag_msg_attrs_fill' was not declared. Should it be static?
Signed-off-by: Ben Dooks <ben.dooks@codethink.co.uk>
---
Cc: "David S. Miller" <davem@davemloft.net>
Cc: netdev@vger.kernel.org
Cc: linux-kernel@vger.kernel.org
---
include/linux/inet_diag.h | 6 ++++++
1 file changed, 6 insertions(+)
diff --git a/include/linux/inet_diag.h b/include/linux/inet_diag.h
index 7c27fa1..feb04ea 100644
--- a/include/linux/inet_diag.h
+++ b/include/linux/inet_diag.h
@@ -52,6 +52,12 @@ struct sock *inet_diag_find_one_icsk(struct net *net,
int inet_diag_bc_sk(const struct nlattr *_bc, struct sock *sk);
+void inet_diag_msg_common_fill(struct inet_diag_msg *r, struct sock *sk);
+
+int inet_diag_msg_attrs_fill(struct sock *sk, struct sk_buff *skb,
+ struct inet_diag_msg *r, int ext,
+ struct user_namespace *user_ns);
+
extern int inet_diag_register(const struct inet_diag_handler *handler);
extern void inet_diag_unregister(const struct inet_diag_handler *handler);
#endif /* _INET_DIAG_H_ */
--
2.8.1
^ permalink raw reply related [flat|nested] 3+ messages in thread
* Re: [PATCH] net: diag: add missing declarations
2016-06-09 11:17 [PATCH] net: diag: add missing declarations Ben Dooks
@ 2016-06-09 14:10 ` Eric Dumazet
2016-06-09 14:17 ` Ben Dooks
0 siblings, 1 reply; 3+ messages in thread
From: Eric Dumazet @ 2016-06-09 14:10 UTC (permalink / raw)
To: Ben Dooks; +Cc: linux-kernel, David S. Miller, netdev, linux-kernel
On Thu, 2016-06-09 at 12:17 +0100, Ben Dooks wrote:
> The functions inet_diag_msg_common_fill and inet_diag_msg_attrs_fill
> seem to have been missed from the include/linux/inet_diag.h header
> file. Add them to fix the following warnings:
>
> net/ipv4/inet_diag.c:69:6: warning: symbol 'inet_diag_msg_common_fill' was not declared. Should it be static?
> net/ipv4/inet_diag.c:108:5: warning: symbol 'inet_diag_msg_attrs_fill' was not declared. Should it be static?
>
> Signed-off-by: Ben Dooks <ben.dooks@codethink.co.uk>
> ---
> Cc: "David S. Miller" <davem@davemloft.net>
> Cc: netdev@vger.kernel.org
> Cc: linux-kernel@vger.kernel.org
> ---
> include/linux/inet_diag.h | 6 ++++++
> 1 file changed, 6 insertions(+)
>
> diff --git a/include/linux/inet_diag.h b/include/linux/inet_diag.h
> index 7c27fa1..feb04ea 100644
> --- a/include/linux/inet_diag.h
> +++ b/include/linux/inet_diag.h
> @@ -52,6 +52,12 @@ struct sock *inet_diag_find_one_icsk(struct net *net,
>
> int inet_diag_bc_sk(const struct nlattr *_bc, struct sock *sk);
>
> +void inet_diag_msg_common_fill(struct inet_diag_msg *r, struct sock *sk);
> +
> +int inet_diag_msg_attrs_fill(struct sock *sk, struct sk_buff *skb,
> + struct inet_diag_msg *r, int ext,
> + struct user_namespace *user_ns);
> +
> extern int inet_diag_register(const struct inet_diag_handler *handler);
> extern void inet_diag_unregister(const struct inet_diag_handler *handler);
> #endif /* _INET_DIAG_H_ */
Please send a v2, deleting them from net/sctp/sctp_diag.c
Thanks.
^ permalink raw reply [flat|nested] 3+ messages in thread
* Re: [PATCH] net: diag: add missing declarations
2016-06-09 14:10 ` Eric Dumazet
@ 2016-06-09 14:17 ` Ben Dooks
0 siblings, 0 replies; 3+ messages in thread
From: Ben Dooks @ 2016-06-09 14:17 UTC (permalink / raw)
To: Eric Dumazet; +Cc: linux-kernel, David S. Miller, netdev, linux-kernel
On 09/06/16 15:10, Eric Dumazet wrote:
> On Thu, 2016-06-09 at 12:17 +0100, Ben Dooks wrote:
>> The functions inet_diag_msg_common_fill and inet_diag_msg_attrs_fill
>> seem to have been missed from the include/linux/inet_diag.h header
>> file. Add them to fix the following warnings:
>>
>> net/ipv4/inet_diag.c:69:6: warning: symbol 'inet_diag_msg_common_fill' was not declared. Should it be static?
>> net/ipv4/inet_diag.c:108:5: warning: symbol 'inet_diag_msg_attrs_fill' was not declared. Should it be static?
>>
>> Signed-off-by: Ben Dooks <ben.dooks@codethink.co.uk>
>> ---
>> Cc: "David S. Miller" <davem@davemloft.net>
>> Cc: netdev@vger.kernel.org
>> Cc: linux-kernel@vger.kernel.org
>> ---
>> include/linux/inet_diag.h | 6 ++++++
>> 1 file changed, 6 insertions(+)
>>
>> diff --git a/include/linux/inet_diag.h b/include/linux/inet_diag.h
>> index 7c27fa1..feb04ea 100644
>> --- a/include/linux/inet_diag.h
>> +++ b/include/linux/inet_diag.h
>> @@ -52,6 +52,12 @@ struct sock *inet_diag_find_one_icsk(struct net *net,
>>
>> int inet_diag_bc_sk(const struct nlattr *_bc, struct sock *sk);
>>
>> +void inet_diag_msg_common_fill(struct inet_diag_msg *r, struct sock *sk);
>> +
>> +int inet_diag_msg_attrs_fill(struct sock *sk, struct sk_buff *skb,
>> + struct inet_diag_msg *r, int ext,
>> + struct user_namespace *user_ns);
>> +
>> extern int inet_diag_register(const struct inet_diag_handler *handler);
>> extern void inet_diag_unregister(const struct inet_diag_handler *handler);
>> #endif /* _INET_DIAG_H_ */
>
> Please send a v2, deleting them from net/sctp/sctp_diag.c
Ah, didn't spot those. Will send a second version thanks.
--
Ben Dooks http://www.codethink.co.uk/
Senior Engineer Codethink - Providing Genius
^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2016-06-09 14:17 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2016-06-09 11:17 [PATCH] net: diag: add missing declarations Ben Dooks
2016-06-09 14:10 ` Eric Dumazet
2016-06-09 14:17 ` Ben Dooks
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).