* [PATCH] drm/bridge: tc358764: Fix build error
@ 2019-07-29 9:05 YueHaibing
2019-07-30 1:59 ` Laurent Pinchart
2019-07-30 12:32 ` Neil Armstrong
0 siblings, 2 replies; 4+ messages in thread
From: YueHaibing @ 2019-07-29 9:05 UTC (permalink / raw)
To: a.hajda, narmstrong, Laurent.pinchart, jonas, jernej.skrabec,
airlied, daniel
Cc: linux-kernel, dri-devel, YueHaibing
If CONFIG_DRM_TOSHIBA_TC358764=y but CONFIG_DRM_KMS_HELPER=m,
building fails:
drivers/gpu/drm/bridge/tc358764.o:(.rodata+0x228): undefined reference to `drm_atomic_helper_connector_reset'
drivers/gpu/drm/bridge/tc358764.o:(.rodata+0x240): undefined reference to `drm_helper_probe_single_connector_modes'
drivers/gpu/drm/bridge/tc358764.o:(.rodata+0x268): undefined reference to `drm_atomic_helper_connector_duplicate_state'
drivers/gpu/drm/bridge/tc358764.o:(.rodata+0x270): undefined reference to `drm_atomic_helper_connector_destroy_state'
Like TC358767, select DRM_KMS_HELPER to fix this, and
change to select DRM_PANEL to avoid recursive dependency.
Reported-by: Hulk Robot <hulkci@huawei.com>
Fixes: f38b7cca6d0e ("drm/bridge: tc358764: Add DSI to LVDS bridge driver")
Signed-off-by: YueHaibing <yuehaibing@huawei.com>
---
drivers/gpu/drm/bridge/Kconfig | 3 ++-
1 file changed, 2 insertions(+), 1 deletion(-)
diff --git a/drivers/gpu/drm/bridge/Kconfig b/drivers/gpu/drm/bridge/Kconfig
index a6eec90..323f72d 100644
--- a/drivers/gpu/drm/bridge/Kconfig
+++ b/drivers/gpu/drm/bridge/Kconfig
@@ -116,9 +116,10 @@ config DRM_THINE_THC63LVD1024
config DRM_TOSHIBA_TC358764
tristate "TC358764 DSI/LVDS bridge"
- depends on DRM && DRM_PANEL
depends on OF
select DRM_MIPI_DSI
+ select DRM_KMS_HELPER
+ select DRM_PANEL
help
Toshiba TC358764 DSI/LVDS bridge driver.
--
2.7.4
^ permalink raw reply related [flat|nested] 4+ messages in thread
* Re: [PATCH] drm/bridge: tc358764: Fix build error
2019-07-29 9:05 [PATCH] drm/bridge: tc358764: Fix build error YueHaibing
@ 2019-07-30 1:59 ` Laurent Pinchart
2019-07-30 12:32 ` Neil Armstrong
1 sibling, 0 replies; 4+ messages in thread
From: Laurent Pinchart @ 2019-07-30 1:59 UTC (permalink / raw)
To: YueHaibing
Cc: a.hajda, narmstrong, jonas, jernej.skrabec, airlied, daniel,
linux-kernel, dri-devel
Hi Yue,
Thank you for the patch.
On Mon, Jul 29, 2019 at 05:05:20PM +0800, YueHaibing wrote:
> If CONFIG_DRM_TOSHIBA_TC358764=y but CONFIG_DRM_KMS_HELPER=m,
> building fails:
>
> drivers/gpu/drm/bridge/tc358764.o:(.rodata+0x228): undefined reference to `drm_atomic_helper_connector_reset'
> drivers/gpu/drm/bridge/tc358764.o:(.rodata+0x240): undefined reference to `drm_helper_probe_single_connector_modes'
> drivers/gpu/drm/bridge/tc358764.o:(.rodata+0x268): undefined reference to `drm_atomic_helper_connector_duplicate_state'
> drivers/gpu/drm/bridge/tc358764.o:(.rodata+0x270): undefined reference to `drm_atomic_helper_connector_destroy_state'
>
> Like TC358767, select DRM_KMS_HELPER to fix this, and
> change to select DRM_PANEL to avoid recursive dependency.
>
> Reported-by: Hulk Robot <hulkci@huawei.com>
> Fixes: f38b7cca6d0e ("drm/bridge: tc358764: Add DSI to LVDS bridge driver")
> Signed-off-by: YueHaibing <yuehaibing@huawei.com>
Reviewed-by: Laurent Pinchart <laurent.pinchart@ideasonboard.com>
> ---
> drivers/gpu/drm/bridge/Kconfig | 3 ++-
> 1 file changed, 2 insertions(+), 1 deletion(-)
>
> diff --git a/drivers/gpu/drm/bridge/Kconfig b/drivers/gpu/drm/bridge/Kconfig
> index a6eec90..323f72d 100644
> --- a/drivers/gpu/drm/bridge/Kconfig
> +++ b/drivers/gpu/drm/bridge/Kconfig
> @@ -116,9 +116,10 @@ config DRM_THINE_THC63LVD1024
>
> config DRM_TOSHIBA_TC358764
> tristate "TC358764 DSI/LVDS bridge"
> - depends on DRM && DRM_PANEL
> depends on OF
> select DRM_MIPI_DSI
> + select DRM_KMS_HELPER
> + select DRM_PANEL
> help
> Toshiba TC358764 DSI/LVDS bridge driver.
>
--
Regards,
Laurent Pinchart
^ permalink raw reply [flat|nested] 4+ messages in thread
* Re: [PATCH] drm/bridge: tc358764: Fix build error
2019-07-29 9:05 [PATCH] drm/bridge: tc358764: Fix build error YueHaibing
2019-07-30 1:59 ` Laurent Pinchart
@ 2019-07-30 12:32 ` Neil Armstrong
2019-07-30 12:47 ` Neil Armstrong
1 sibling, 1 reply; 4+ messages in thread
From: Neil Armstrong @ 2019-07-30 12:32 UTC (permalink / raw)
To: YueHaibing, a.hajda, Laurent.pinchart, jonas, jernej.skrabec,
airlied, daniel
Cc: linux-kernel, dri-devel
On 29/07/2019 11:05, YueHaibing wrote:
> If CONFIG_DRM_TOSHIBA_TC358764=y but CONFIG_DRM_KMS_HELPER=m,
> building fails:
>
> drivers/gpu/drm/bridge/tc358764.o:(.rodata+0x228): undefined reference to `drm_atomic_helper_connector_reset'
> drivers/gpu/drm/bridge/tc358764.o:(.rodata+0x240): undefined reference to `drm_helper_probe_single_connector_modes'
> drivers/gpu/drm/bridge/tc358764.o:(.rodata+0x268): undefined reference to `drm_atomic_helper_connector_duplicate_state'
> drivers/gpu/drm/bridge/tc358764.o:(.rodata+0x270): undefined reference to `drm_atomic_helper_connector_destroy_state'
>
> Like TC358767, select DRM_KMS_HELPER to fix this, and
> change to select DRM_PANEL to avoid recursive dependency.
>
> Reported-by: Hulk Robot <hulkci@huawei.com>
> Fixes: f38b7cca6d0e ("drm/bridge: tc358764: Add DSI to LVDS bridge driver")
> Signed-off-by: YueHaibing <yuehaibing@huawei.com>
> ---
> drivers/gpu/drm/bridge/Kconfig | 3 ++-
> 1 file changed, 2 insertions(+), 1 deletion(-)
>
> diff --git a/drivers/gpu/drm/bridge/Kconfig b/drivers/gpu/drm/bridge/Kconfig
> index a6eec90..323f72d 100644
> --- a/drivers/gpu/drm/bridge/Kconfig
> +++ b/drivers/gpu/drm/bridge/Kconfig
> @@ -116,9 +116,10 @@ config DRM_THINE_THC63LVD1024
>
> config DRM_TOSHIBA_TC358764
> tristate "TC358764 DSI/LVDS bridge"
> - depends on DRM && DRM_PANEL
> depends on OF
> select DRM_MIPI_DSI
> + select DRM_KMS_HELPER
> + select DRM_PANEL
> help
> Toshiba TC358764 DSI/LVDS bridge driver.
>
>
Reviewed-by: Neil Armstrong <narmstrong@baylibre.com>
^ permalink raw reply [flat|nested] 4+ messages in thread
* Re: [PATCH] drm/bridge: tc358764: Fix build error
2019-07-30 12:32 ` Neil Armstrong
@ 2019-07-30 12:47 ` Neil Armstrong
0 siblings, 0 replies; 4+ messages in thread
From: Neil Armstrong @ 2019-07-30 12:47 UTC (permalink / raw)
To: YueHaibing, a.hajda, Laurent.pinchart, jonas, jernej.skrabec,
airlied, daniel
Cc: linux-kernel, dri-devel
On 30/07/2019 14:32, Neil Armstrong wrote:
> On 29/07/2019 11:05, YueHaibing wrote:
>> If CONFIG_DRM_TOSHIBA_TC358764=y but CONFIG_DRM_KMS_HELPER=m,
>> building fails:
>>
>> drivers/gpu/drm/bridge/tc358764.o:(.rodata+0x228): undefined reference to `drm_atomic_helper_connector_reset'
>> drivers/gpu/drm/bridge/tc358764.o:(.rodata+0x240): undefined reference to `drm_helper_probe_single_connector_modes'
>> drivers/gpu/drm/bridge/tc358764.o:(.rodata+0x268): undefined reference to `drm_atomic_helper_connector_duplicate_state'
>> drivers/gpu/drm/bridge/tc358764.o:(.rodata+0x270): undefined reference to `drm_atomic_helper_connector_destroy_state'
>>
>> Like TC358767, select DRM_KMS_HELPER to fix this, and
>> change to select DRM_PANEL to avoid recursive dependency.
>>
>> Reported-by: Hulk Robot <hulkci@huawei.com>
>> Fixes: f38b7cca6d0e ("drm/bridge: tc358764: Add DSI to LVDS bridge driver")
>> Signed-off-by: YueHaibing <yuehaibing@huawei.com>
>> ---
>> drivers/gpu/drm/bridge/Kconfig | 3 ++-
>> 1 file changed, 2 insertions(+), 1 deletion(-)
>>
>> diff --git a/drivers/gpu/drm/bridge/Kconfig b/drivers/gpu/drm/bridge/Kconfig
>> index a6eec90..323f72d 100644
>> --- a/drivers/gpu/drm/bridge/Kconfig
>> +++ b/drivers/gpu/drm/bridge/Kconfig
>> @@ -116,9 +116,10 @@ config DRM_THINE_THC63LVD1024
>>
>> config DRM_TOSHIBA_TC358764
>> tristate "TC358764 DSI/LVDS bridge"
>> - depends on DRM && DRM_PANEL
>> depends on OF
>> select DRM_MIPI_DSI
>> + select DRM_KMS_HELPER
>> + select DRM_PANEL
>> help
>> Toshiba TC358764 DSI/LVDS bridge driver.
>>
>>
>
> Reviewed-by: Neil Armstrong <narmstrong@baylibre.com>
>
Applying to drm-misc-fixes
Thanks,
Neil
^ permalink raw reply [flat|nested] 4+ messages in thread
end of thread, other threads:[~2019-07-30 12:47 UTC | newest]
Thread overview: 4+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2019-07-29 9:05 [PATCH] drm/bridge: tc358764: Fix build error YueHaibing
2019-07-30 1:59 ` Laurent Pinchart
2019-07-30 12:32 ` Neil Armstrong
2019-07-30 12:47 ` Neil Armstrong
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).