* [PATCH] MIPS: Loongson: Set CONFIG_FRAME_WARN=2048 in loongson3_defconfig to fix build warning
@ 2020-08-14 2:56 Tiezhu Yang
2020-08-14 6:53 ` Thomas Bogendoerfer
0 siblings, 1 reply; 4+ messages in thread
From: Tiezhu Yang @ 2020-08-14 2:56 UTC (permalink / raw)
To: Thomas Bogendoerfer, Huacai Chen, Jiaxun Yang
Cc: linux-mips, linux-kernel, Xuefeng Li
After commit 70b838292bef ("MIPS: Update default config file for
Loongson-3"), CONFIG_VHOST_SCSI and CONFIG_VHOST are set when use
loongson3_defconfig, and then there exists the following two build
warnings related with these two configs, set CONFIG_FRAME_WARN=2048
in loongson3_defconfig to fix it.
CC [M] drivers/vhost/scsi.o
drivers/vhost/scsi.c: In function ‘vhost_scsi_flush’:
drivers/vhost/scsi.c:1374:1: warning: the frame size of 1040 bytes is larger than 1024 bytes [-Wframe-larger-than=]
}
^
LD [M] drivers/vhost/vhost_scsi.o
CC [M] drivers/vhost/vsock.o
LD [M] drivers/vhost/vhost_vsock.o
CC [M] drivers/vhost/vhost.o
drivers/vhost/vhost.c: In function ‘log_used’:
drivers/vhost/vhost.c:1896:1: warning: the frame size of 1040 bytes is larger than 1024 bytes [-Wframe-larger-than=]
}
^
Fixes: 70b838292bef ("MIPS: Update default config file for Loongson-3")
Signed-off-by: Tiezhu Yang <yangtiezhu@loongson.cn>
---
arch/mips/configs/loongson3_defconfig | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/arch/mips/configs/loongson3_defconfig b/arch/mips/configs/loongson3_defconfig
index a65b08d..2b356d9 100644
--- a/arch/mips/configs/loongson3_defconfig
+++ b/arch/mips/configs/loongson3_defconfig
@@ -403,7 +403,7 @@ CONFIG_CRYPTO_TEA=m
CONFIG_CRYPTO_TWOFISH=m
CONFIG_CRYPTO_DEFLATE=m
CONFIG_PRINTK_TIME=y
-CONFIG_FRAME_WARN=1024
+CONFIG_FRAME_WARN=2048
CONFIG_STRIP_ASM_SYMS=y
CONFIG_MAGIC_SYSRQ=y
# CONFIG_SCHED_DEBUG is not set
--
2.1.0
^ permalink raw reply related [flat|nested] 4+ messages in thread
* Re: [PATCH] MIPS: Loongson: Set CONFIG_FRAME_WARN=2048 in loongson3_defconfig to fix build warning
2020-08-14 2:56 [PATCH] MIPS: Loongson: Set CONFIG_FRAME_WARN=2048 in loongson3_defconfig to fix build warning Tiezhu Yang
@ 2020-08-14 6:53 ` Thomas Bogendoerfer
2020-08-14 7:31 ` Tiezhu Yang
0 siblings, 1 reply; 4+ messages in thread
From: Thomas Bogendoerfer @ 2020-08-14 6:53 UTC (permalink / raw)
To: Tiezhu Yang
Cc: Huacai Chen, Jiaxun Yang, linux-mips, linux-kernel, Xuefeng Li
On Fri, Aug 14, 2020 at 10:56:33AM +0800, Tiezhu Yang wrote:
> Fixes: 70b838292bef ("MIPS: Update default config file for Loongson-3")
I'm not so sure whether this warrants a fixes tag.
> arch/mips/configs/loongson3_defconfig | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/arch/mips/configs/loongson3_defconfig b/arch/mips/configs/loongson3_defconfig
> index a65b08d..2b356d9 100644
> --- a/arch/mips/configs/loongson3_defconfig
> +++ b/arch/mips/configs/loongson3_defconfig
> @@ -403,7 +403,7 @@ CONFIG_CRYPTO_TEA=m
> CONFIG_CRYPTO_TWOFISH=m
> CONFIG_CRYPTO_DEFLATE=m
> CONFIG_PRINTK_TIME=y
> -CONFIG_FRAME_WARN=1024
> +CONFIG_FRAME_WARN=2048
what about just dropping it ? Default for 64bit is 2048. Leaving it out
of the config has the advantage that you will get a change of the default
for free.
Thomas.
--
Crap can work. Given enough thrust pigs will fly, but it's not necessarily a
good idea. [ RFC1925, 2.3 ]
^ permalink raw reply [flat|nested] 4+ messages in thread
* Re: [PATCH] MIPS: Loongson: Set CONFIG_FRAME_WARN=2048 in loongson3_defconfig to fix build warning
2020-08-14 6:53 ` Thomas Bogendoerfer
@ 2020-08-14 7:31 ` Tiezhu Yang
2020-08-14 8:08 ` Thomas Bogendoerfer
0 siblings, 1 reply; 4+ messages in thread
From: Tiezhu Yang @ 2020-08-14 7:31 UTC (permalink / raw)
To: Thomas Bogendoerfer
Cc: Huacai Chen, Jiaxun Yang, linux-mips, linux-kernel, Xuefeng Li
On 08/14/2020 02:53 PM, Thomas Bogendoerfer wrote:
> On Fri, Aug 14, 2020 at 10:56:33AM +0800, Tiezhu Yang wrote:
>> Fixes: 70b838292bef ("MIPS: Update default config file for Loongson-3")
> I'm not so sure whether this warrants a fixes tag.
I use git bisect to find it is the first bad commit. Please let me know
if it is not necessary and then I will remove the Fixes tag.
>
>> arch/mips/configs/loongson3_defconfig | 2 +-
>> 1 file changed, 1 insertion(+), 1 deletion(-)
>>
>> diff --git a/arch/mips/configs/loongson3_defconfig b/arch/mips/configs/loongson3_defconfig
>> index a65b08d..2b356d9 100644
>> --- a/arch/mips/configs/loongson3_defconfig
>> +++ b/arch/mips/configs/loongson3_defconfig
>> @@ -403,7 +403,7 @@ CONFIG_CRYPTO_TEA=m
>> CONFIG_CRYPTO_TWOFISH=m
>> CONFIG_CRYPTO_DEFLATE=m
>> CONFIG_PRINTK_TIME=y
>> -CONFIG_FRAME_WARN=1024
>> +CONFIG_FRAME_WARN=2048
> what about just dropping it ? Default for 64bit is 2048. Leaving it out
> of the config has the advantage that you will get a change of the default
> for free.
OK, looks good to me, I will send v2.
Thanks,
Tiezhu
>
> Thomas.
>
^ permalink raw reply [flat|nested] 4+ messages in thread
* Re: [PATCH] MIPS: Loongson: Set CONFIG_FRAME_WARN=2048 in loongson3_defconfig to fix build warning
2020-08-14 7:31 ` Tiezhu Yang
@ 2020-08-14 8:08 ` Thomas Bogendoerfer
0 siblings, 0 replies; 4+ messages in thread
From: Thomas Bogendoerfer @ 2020-08-14 8:08 UTC (permalink / raw)
To: Tiezhu Yang
Cc: Huacai Chen, Jiaxun Yang, linux-mips, linux-kernel, Xuefeng Li
On Fri, Aug 14, 2020 at 03:31:19PM +0800, Tiezhu Yang wrote:
> On 08/14/2020 02:53 PM, Thomas Bogendoerfer wrote:
> >On Fri, Aug 14, 2020 at 10:56:33AM +0800, Tiezhu Yang wrote:
> >>Fixes: 70b838292bef ("MIPS: Update default config file for Loongson-3")
> >I'm not so sure whether this warrants a fixes tag.
>
> I use git bisect to find it is the first bad commit. Please let me know
> if it is not necessary and then I will remove the Fixes tag.
Please remove it.
Thomas.
--
Crap can work. Given enough thrust pigs will fly, but it's not necessarily a
good idea. [ RFC1925, 2.3 ]
^ permalink raw reply [flat|nested] 4+ messages in thread
end of thread, other threads:[~2020-08-14 8:09 UTC | newest]
Thread overview: 4+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2020-08-14 2:56 [PATCH] MIPS: Loongson: Set CONFIG_FRAME_WARN=2048 in loongson3_defconfig to fix build warning Tiezhu Yang
2020-08-14 6:53 ` Thomas Bogendoerfer
2020-08-14 7:31 ` Tiezhu Yang
2020-08-14 8:08 ` Thomas Bogendoerfer
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).