[PATCH -next RESEND] regulator: BD71815: select REGULATOR_ROHM to fix link errors

[PATCH -next RESEND] regulator: BD71815: select REGULATOR_ROHM to fix link errors

[Randy Dunlap]

With REGULATOR_ROHM there are linker errors:

ld: drivers/regulator/bd71815-regulator.o: in function `set_hw_dvs_levels':
bd71815-regulator.c:(.text+0xbb): undefined reference to `rohm_regulator_set_dvs_levels'
ld: drivers/regulator/bd71815-regulator.o: in function `buck12_set_hw_dvs_levels':
bd71815-regulator.c:(.text+0x33e): undefined reference to `rohm_regulator_set_dvs_levels'

Fixes: 1aad39001e851 ("regulator: Support ROHM BD71815 regulators")
Signed-off-by: Randy Dunlap <rdunlap@infradead.org>
Cc: Matti Vaittinen <matti.vaittinen@fi.rohmeurope.com>
Cc: Lee Jones <lee.jones@linaro.org>
Cc: Liam Girdwood <lgirdwood@gmail.com>
Cc: Mark Brown <broonie@kernel.org>
---
Sorry about the Resend. I'm having some email problems.

 drivers/regulator/Kconfig |    1 +
 1 file changed, 1 insertion(+)

--- linux-next-20210426.orig/drivers/regulator/Kconfig
+++ linux-next-20210426/drivers/regulator/Kconfig
@@ -207,6 +207,7 @@ config REGULATOR_BD70528
 config REGULATOR_BD71815
 	tristate "ROHM BD71815 Power Regulator"
 	depends on MFD_ROHM_BD71828
+	select REGULATOR_ROHM
 	help
 	  This driver supports voltage regulators on ROHM BD71815 PMIC.
 	  This will enable support for the software controllable buck

Re: [PATCH -next RESEND] regulator: BD71815: select REGULATOR_ROHM to fix link errors

[Matti Vaittinen]

Morning Randy,

On Mon, 2021-04-26 at 11:37 -0700, Randy Dunlap wrote:
> With REGULATOR_ROHM there are linker errors:
> 
> ld: drivers/regulator/bd71815-regulator.o: in function
> `set_hw_dvs_levels':
> bd71815-regulator.c:(.text+0xbb): undefined reference to
> `rohm_regulator_set_dvs_levels'
> ld: drivers/regulator/bd71815-regulator.o: in function
> `buck12_set_hw_dvs_levels':
> bd71815-regulator.c:(.text+0x33e): undefined reference to
> `rohm_regulator_set_dvs_levels'
> 
> Fixes: 1aad39001e851 ("regulator: Support ROHM BD71815 regulators")
> Signed-off-by: Randy Dunlap <rdunlap@infradead.org>
> Cc: Matti Vaittinen <matti.vaittinen@fi.rohmeurope.com>
> Cc: Lee Jones <lee.jones@linaro.org>
> Cc: Liam Girdwood <lgirdwood@gmail.com>
> Cc: Mark Brown <broonie@kernel.org>
> ---
> Sorry about the Resend. I'm having some email problems.

Thanks for fixing this. I just wanted to let you know Arnd sent same
fix (and couple of other fixes to BD71815) few days ago. Mark couldn't
take the patches as the original series is only in Lee's tree. Sorry
for causing the problems.

Best Regards
	Matti Vaittinen