linux-kernel.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
* [PATCH] nl80211: fix enumeration type
@ 2017-04-20  6:55 Stefan Agner
  2017-04-20  7:22 ` Johannes Berg
  0 siblings, 1 reply; 3+ messages in thread
From: Stefan Agner @ 2017-04-20  6:55 UTC (permalink / raw)
  To: johannes; +Cc: davem, linux-wireless, netdev, linux-kernel, Stefan Agner

Use type enum nl80211_rate_info for bitrate information. This fixes
a warning when compiling with clang:
  warning: implicit conversion from enumeration type 'enum nl80211_rate_info'
  to different enumeration type 'enum nl80211_attrs'

Signed-off-by: Stefan Agner <stefan@agner.ch>
---
 net/wireless/nl80211.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/net/wireless/nl80211.c b/net/wireless/nl80211.c
index 2312dc2ffdb9..9af21a21ea6b 100644
--- a/net/wireless/nl80211.c
+++ b/net/wireless/nl80211.c
@@ -4151,7 +4151,7 @@ static bool nl80211_put_sta_rate(struct sk_buff *msg, struct rate_info *info,
 	struct nlattr *rate;
 	u32 bitrate;
 	u16 bitrate_compat;
-	enum nl80211_attrs rate_flg;
+	enum nl80211_rate_info rate_flg;
 
 	rate = nla_nest_start(msg, attr);
 	if (!rate)
-- 
2.12.2

^ permalink raw reply related	[flat|nested] 3+ messages in thread

* Re: [PATCH] nl80211: fix enumeration type
  2017-04-20  6:55 [PATCH] nl80211: fix enumeration type Stefan Agner
@ 2017-04-20  7:22 ` Johannes Berg
  2017-04-20 14:21   ` Stefan Agner
  0 siblings, 1 reply; 3+ messages in thread
From: Johannes Berg @ 2017-04-20  7:22 UTC (permalink / raw)
  To: Stefan Agner; +Cc: davem, linux-wireless, netdev, linux-kernel

On Wed, 2017-04-19 at 23:55 -0700, Stefan Agner wrote:
> Use type enum nl80211_rate_info for bitrate information. This fixes
> a warning when compiling with clang:
>   warning: implicit conversion from enumeration type 'enum
> nl80211_rate_info'
>   to different enumeration type 'enum nl80211_attrs'

I'm pretty sure I just applied exactly these two patches very recently.

What made *two* people suddenly see this?

johannes

^ permalink raw reply	[flat|nested] 3+ messages in thread

* Re: [PATCH] nl80211: fix enumeration type
  2017-04-20  7:22 ` Johannes Berg
@ 2017-04-20 14:21   ` Stefan Agner
  0 siblings, 0 replies; 3+ messages in thread
From: Stefan Agner @ 2017-04-20 14:21 UTC (permalink / raw)
  To: Johannes Berg; +Cc: davem, linux-wireless, netdev, linux-kernel

On 2017-04-20 00:22, Johannes Berg wrote:
> On Wed, 2017-04-19 at 23:55 -0700, Stefan Agner wrote:
>> Use type enum nl80211_rate_info for bitrate information. This fixes
>> a warning when compiling with clang:
>>   warning: implicit conversion from enumeration type 'enum
>> nl80211_rate_info'
>>   to different enumeration type 'enum nl80211_attrs'
> 
> I'm pretty sure I just applied exactly these two patches very recently.
> 
> What made *two* people suddenly see this?

There has been renewed work on compiling Linux using clang... Sorry for
the clash.

--
Stefan

^ permalink raw reply	[flat|nested] 3+ messages in thread

end of thread, other threads:[~2017-04-20 14:21 UTC | newest]

Thread overview: 3+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2017-04-20  6:55 [PATCH] nl80211: fix enumeration type Stefan Agner
2017-04-20  7:22 ` Johannes Berg
2017-04-20 14:21   ` Stefan Agner

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).