* [PATCH] ata/acard_ahci: remove unused variable n_elem
@ 2020-01-21 8:48 Alex Shi
2020-01-22 17:46 ` Jens Axboe
0 siblings, 1 reply; 2+ messages in thread
From: Alex Shi @ 2020-01-21 8:48 UTC (permalink / raw)
Cc: Jens Axboe, linux-ide, linux-kernel
No one care the varible acard_ahci in func acard_ahci_qc_prep.
better to remove it.
Signed-off-by: Alex Shi <alex.shi@linux.alibaba.com>
Cc: Jens Axboe <axboe@kernel.dk>
Cc: linux-ide@vger.kernel.org
Cc: linux-kernel@vger.kernel.org
---
drivers/ata/acard-ahci.c | 4 +---
1 file changed, 1 insertion(+), 3 deletions(-)
diff --git a/drivers/ata/acard-ahci.c b/drivers/ata/acard-ahci.c
index 46dc54d18f0b..2a04e8abd397 100644
--- a/drivers/ata/acard-ahci.c
+++ b/drivers/ata/acard-ahci.c
@@ -218,7 +218,6 @@ static enum ata_completion_errors acard_ahci_qc_prep(struct ata_queued_cmd *qc)
void *cmd_tbl;
u32 opts;
const u32 cmd_fis_len = 5; /* five dwords */
- unsigned int n_elem;
/*
* Fill in command table information. First, the header,
@@ -232,9 +231,8 @@ static enum ata_completion_errors acard_ahci_qc_prep(struct ata_queued_cmd *qc)
memcpy(cmd_tbl + AHCI_CMD_TBL_CDB, qc->cdb, qc->dev->cdb_len);
}
- n_elem = 0;
if (qc->flags & ATA_QCFLAG_DMAMAP)
- n_elem = acard_ahci_fill_sg(qc, cmd_tbl);
+ acard_ahci_fill_sg(qc, cmd_tbl);
/*
* Fill in command slot information.
--
1.8.3.1
^ permalink raw reply related [flat|nested] 2+ messages in thread
* Re: [PATCH] ata/acard_ahci: remove unused variable n_elem
2020-01-21 8:48 [PATCH] ata/acard_ahci: remove unused variable n_elem Alex Shi
@ 2020-01-22 17:46 ` Jens Axboe
0 siblings, 0 replies; 2+ messages in thread
From: Jens Axboe @ 2020-01-22 17:46 UTC (permalink / raw)
To: Alex Shi; +Cc: linux-ide, linux-kernel
On 1/21/20 1:48 AM, Alex Shi wrote:
> No one care the varible acard_ahci in func acard_ahci_qc_prep.
> better to remove it.
Applied, thanks.
--
Jens Axboe
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2020-01-22 17:46 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2020-01-21 8:48 [PATCH] ata/acard_ahci: remove unused variable n_elem Alex Shi
2020-01-22 17:46 ` Jens Axboe
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).