From: Atish Patra <Atish.Patra@wdc.com>
To: "schwab@suse.de" <schwab@suse.de>, Anup Patel <Anup.Patel@wdc.com>
Cc: "linux-riscv@lists.infradead.org"
<linux-riscv@lists.infradead.org>,
"hch@infradead.org" <hch@infradead.org>,
"daniel.lezcano@linaro.org" <daniel.lezcano@linaro.org>,
Alistair Francis <Alistair.Francis@wdc.com>,
Damien Le Moal <Damien.LeMoal@wdc.com>,
"paul.walmsley@sifive.com" <paul.walmsley@sifive.com>,
"rkrcmar@redhat.com" <rkrcmar@redhat.com>,
"linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>,
"tglx@linutronix.de" <tglx@linutronix.de>,
"anup@brainfault.org" <anup@brainfault.org>,
"kvm@vger.kernel.org" <kvm@vger.kernel.org>,
"palmer@sifive.com" <palmer@sifive.com>,
"pbonzini@redhat.com" <pbonzini@redhat.com>
Subject: Re: [RFC PATCH 13/16] RISC-V: KVM: Add timer functionality
Date: Mon, 29 Jul 2019 18:02:00 +0000 [thread overview]
Message-ID: <d26a4582fad27d0f475cf8bca4d3e6c49987d37d.camel@wdc.com> (raw)
In-Reply-To: <mvmpnlsc39p.fsf@suse.de>
On Mon, 2019-07-29 at 16:40 +0200, Andreas Schwab wrote:
> On Jul 29 2019, Anup Patel <Anup.Patel@wdc.com> wrote:
>
> > From: Atish Patra <atish.patra@wdc.com>
> >
> > The RISC-V hypervisor specification doesn't have any virtual timer
> > feature.
> >
> > Due to this, the guest VCPU timer will be programmed via SBI calls.
> > The host will use a separate hrtimer event for each guest VCPU to
> > provide timer functionality. We inject a virtual timer interrupt to
> > the guest VCPU whenever the guest VCPU hrtimer event expires.
> >
> > The following features are not supported yet and will be added in
> > future:
> > 1. A time offset to adjust guest time from host time
> > 2. A saved next event in guest vcpu for vm migration
>
> I'm getting this error:
>
> In file included from <command-line>:
> ./include/clocksource/timer-riscv.h:12:30: error: unknown type name
> ‘u32’
> 12 | void riscv_cs_get_mult_shift(u32 *mult, u32 *shift);
> | ^~~
> ./include/clocksource/timer-riscv.h:12:41: error: unknown type name
> ‘u32’
> 12 | void riscv_cs_get_mult_shift(u32 *mult, u32 *shift);
> | ^~~
> make[1]: *** [scripts/Makefile.build:301: include/clocksource/timer-
> riscv.h.s] Error 1
>
> Andreas.
>
Strange. We never saw this error. But I think we should add this one to
the header file (include/clocksource/timer-riscv.h)
#include <linux/types.h>
Can you try it at your end and confirm please ?
Regards,
Atish
next prev parent reply other threads:[~2019-07-29 18:09 UTC|newest]
Thread overview: 67+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-07-29 11:56 [RFC PATCH 00/16] KVM RISC-V Support Anup Patel
2019-07-29 11:56 ` [RFC PATCH 01/16] KVM: RISC-V: Add KVM_REG_RISCV for ONE_REG interface Anup Patel
2019-07-29 11:56 ` [RFC PATCH 02/16] RISC-V: Add hypervisor extension related CSR defines Anup Patel
2019-07-29 11:56 ` [RFC PATCH 03/16] RISC-V: Add initial skeletal KVM support Anup Patel
2019-07-30 9:23 ` Paolo Bonzini
2019-07-30 11:04 ` Anup Patel
2019-07-30 9:25 ` Paolo Bonzini
2019-07-30 11:03 ` Anup Patel
2019-07-29 11:56 ` [RFC PATCH 04/16] RISC-V: KVM: Implement VCPU create, init and destroy functions Anup Patel
2019-07-30 8:48 ` Paolo Bonzini
2019-07-30 10:16 ` Paolo Bonzini
2019-07-30 11:45 ` Anup Patel
2019-07-30 11:47 ` Paolo Bonzini
2019-07-29 11:56 ` [RFC PATCH 05/16] RISC-V: KVM: Implement VCPU interrupts and requests handling Anup Patel
2019-07-30 11:17 ` Paolo Bonzini
2019-07-30 12:00 ` Anup Patel
2019-07-30 12:12 ` Paolo Bonzini
2019-07-30 12:45 ` Anup Patel
2019-07-30 13:18 ` Paolo Bonzini
2019-07-30 13:35 ` Anup Patel
2019-07-30 14:08 ` Paolo Bonzini
2019-08-02 3:59 ` Anup Patel
2019-07-29 11:56 ` [RFC PATCH 06/16] RISC-V: KVM: Implement KVM_GET_ONE_REG/KVM_SET_ONE_REG ioctls Anup Patel
2019-07-30 8:43 ` Paolo Bonzini
2019-07-30 9:35 ` Paolo Bonzini
2019-07-30 12:08 ` Anup Patel
2019-07-30 12:10 ` Paolo Bonzini
2019-07-30 12:16 ` Anup Patel
2019-07-29 11:57 ` [RFC PATCH 07/16] RISC-V: KVM: Implement VCPU world-switch Anup Patel
2019-07-30 9:34 ` Paolo Bonzini
2019-07-30 12:51 ` Anup Patel
2019-07-29 11:57 ` [RFC PATCH 08/16] RISC-V: KVM: Handle MMIO exits for VCPU Anup Patel
2019-07-30 11:20 ` Paolo Bonzini
2019-07-31 7:23 ` Anup Patel
2019-07-29 11:57 ` [RFC PATCH 09/16] RISC-V: KVM: Handle WFI " Anup Patel
2019-07-29 11:57 ` [RFC PATCH 10/16] RISC-V: KVM: Implement VMID allocator Anup Patel
2019-07-30 8:59 ` Paolo Bonzini
2019-07-29 11:57 ` [RFC PATCH 11/16] RISC-V: KVM: Implement stage2 page table programming Anup Patel
2019-07-30 9:00 ` Paolo Bonzini
2019-07-30 12:14 ` Anup Patel
2019-07-29 11:57 ` [RFC PATCH 12/16] RISC-V: KVM: Implement MMU notifiers Anup Patel
2019-07-29 11:57 ` [RFC PATCH 13/16] RISC-V: KVM: Add timer functionality Anup Patel
2019-07-29 14:40 ` Andreas Schwab
2019-07-29 18:02 ` Atish Patra [this message]
2019-07-30 6:51 ` Andreas Schwab
2019-07-30 7:00 ` Atish Patra
2019-07-30 11:26 ` Paolo Bonzini
2019-07-31 1:55 ` Atish Patra
2019-07-31 6:58 ` Paolo Bonzini
2019-07-31 7:18 ` Anup Patel
2019-07-29 11:57 ` [RFC PATCH 14/16] RISC-V: KVM: FP lazy save/restore Anup Patel
2019-07-29 11:57 ` [RFC PATCH 15/16] RISC-V: KVM: Add SBI v0.1 support Anup Patel
2019-07-29 19:40 ` Paolo Bonzini
2019-07-29 19:51 ` Atish Patra
2019-07-29 20:08 ` Paolo Bonzini
2019-07-29 21:08 ` Atish Patra
2019-07-30 9:26 ` Paolo Bonzini
2019-07-29 11:58 ` [RFC PATCH 16/16] RISC-V: Enable VIRTIO drivers in RV64 and RV32 defconfig Anup Patel
2019-07-29 21:47 ` [RFC PATCH 00/16] KVM RISC-V Support Paolo Bonzini
2019-07-30 5:26 ` Anup Patel
2019-07-30 11:33 ` Paolo Bonzini
2019-07-30 13:50 ` Anup Patel
2019-07-30 14:02 ` Paolo Bonzini
2019-07-30 6:53 ` Andreas Schwab
2019-07-30 7:25 ` Anup Patel
2019-07-30 7:42 ` Andreas Schwab
2019-07-30 7:36 ` Anup Patel
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=d26a4582fad27d0f475cf8bca4d3e6c49987d37d.camel@wdc.com \
--to=atish.patra@wdc.com \
--cc=Alistair.Francis@wdc.com \
--cc=Anup.Patel@wdc.com \
--cc=Damien.LeMoal@wdc.com \
--cc=anup@brainfault.org \
--cc=daniel.lezcano@linaro.org \
--cc=hch@infradead.org \
--cc=kvm@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-riscv@lists.infradead.org \
--cc=palmer@sifive.com \
--cc=paul.walmsley@sifive.com \
--cc=pbonzini@redhat.com \
--cc=rkrcmar@redhat.com \
--cc=schwab@suse.de \
--cc=tglx@linutronix.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).