* [PATCH] um: Remove duplicate headers
@ 2019-01-18 14:58 Sabyasachi Gupta
2019-01-18 19:23 ` Anton Ivanov
0 siblings, 1 reply; 5+ messages in thread
From: Sabyasachi Gupta @ 2019-01-18 14:58 UTC (permalink / raw)
To: jdike, richard, anton.ivanov, yuehaibing
Cc: jrdr.linux, linux-um, linux-kernel, brajeswar.linux
Remove sys/socket.h and sys/uio.h which are included more than once
Signed-off-by: Sabyasachi Gupta <sabyasachi.linux@gmail.com>
---
arch/um/drivers/vector_user.c | 2 --
1 file changed, 2 deletions(-)
diff --git a/arch/um/drivers/vector_user.c b/arch/um/drivers/vector_user.c
index d2c17dd..c863921 100644
--- a/arch/um/drivers/vector_user.c
+++ b/arch/um/drivers/vector_user.c
@@ -23,7 +23,6 @@
#include <netinet/ether.h>
#include <linux/if_ether.h>
#include <linux/if_packet.h>
-#include <sys/socket.h>
#include <sys/wait.h>
#include <sys/uio.h>
#include <linux/virtio_net.h>
@@ -31,7 +30,6 @@
#include <stdlib.h>
#include <os.h>
#include <um_malloc.h>
-#include <sys/uio.h>
#include "vector_user.h"
#define ID_GRE 0
--
2.7.4
^ permalink raw reply related [flat|nested] 5+ messages in thread
* Re: [PATCH] um: Remove duplicate headers
2019-01-18 14:58 [PATCH] um: Remove duplicate headers Sabyasachi Gupta
@ 2019-01-18 19:23 ` Anton Ivanov
2019-01-18 19:42 ` Richard Weinberger
0 siblings, 1 reply; 5+ messages in thread
From: Anton Ivanov @ 2019-01-18 19:23 UTC (permalink / raw)
To: Sabyasachi Gupta, jdike, richard, yuehaibing
Cc: brajeswar.linux, linux-um, jrdr.linux, linux-kernel
On 18/01/2019 14:58, Sabyasachi Gupta wrote:
> Remove sys/socket.h and sys/uio.h which are included more than once
>
> Signed-off-by: Sabyasachi Gupta <sabyasachi.linux@gmail.com>
> ---
> arch/um/drivers/vector_user.c | 2 --
> 1 file changed, 2 deletions(-)
>
> diff --git a/arch/um/drivers/vector_user.c b/arch/um/drivers/vector_user.c
> index d2c17dd..c863921 100644
> --- a/arch/um/drivers/vector_user.c
> +++ b/arch/um/drivers/vector_user.c
> @@ -23,7 +23,6 @@
> #include <netinet/ether.h>
> #include <linux/if_ether.h>
> #include <linux/if_packet.h>
> -#include <sys/socket.h>
> #include <sys/wait.h>
> #include <sys/uio.h>
> #include <linux/virtio_net.h>
> @@ -31,7 +30,6 @@
> #include <stdlib.h>
> #include <os.h>
> #include <um_malloc.h>
> -#include <sys/uio.h>
> #include "vector_user.h"
>
> #define ID_GRE 0
>
Hi Sabyasachi,
I believe we have an identical patch enqueued already from a couple of
weeks back.
Best Regards,
A.
^ permalink raw reply [flat|nested] 5+ messages in thread
* Re: [PATCH] um: Remove duplicate headers
2019-01-18 19:23 ` Anton Ivanov
@ 2019-01-18 19:42 ` Richard Weinberger
2019-01-18 20:00 ` Anton Ivanov
0 siblings, 1 reply; 5+ messages in thread
From: Richard Weinberger @ 2019-01-18 19:42 UTC (permalink / raw)
To: Anton Ivanov
Cc: Sabyasachi Gupta, jdike, yuehaibing, brajeswar.linux, linux-um,
jrdr.linux, linux-kernel
Am Freitag, 18. Januar 2019, 20:23:07 CET schrieb Anton Ivanov:
>
> On 18/01/2019 14:58, Sabyasachi Gupta wrote:
> > Remove sys/socket.h and sys/uio.h which are included more than once
> >
> > Signed-off-by: Sabyasachi Gupta <sabyasachi.linux@gmail.com>
> > ---
> > arch/um/drivers/vector_user.c | 2 --
> > 1 file changed, 2 deletions(-)
> >
> > diff --git a/arch/um/drivers/vector_user.c b/arch/um/drivers/vector_user.c
> > index d2c17dd..c863921 100644
> > --- a/arch/um/drivers/vector_user.c
> > +++ b/arch/um/drivers/vector_user.c
> > @@ -23,7 +23,6 @@
> > #include <netinet/ether.h>
> > #include <linux/if_ether.h>
> > #include <linux/if_packet.h>
> > -#include <sys/socket.h>
> > #include <sys/wait.h>
> > #include <sys/uio.h>
> > #include <linux/virtio_net.h>
> > @@ -31,7 +30,6 @@
> > #include <stdlib.h>
> > #include <os.h>
> > #include <um_malloc.h>
> > -#include <sys/uio.h>
> > #include "vector_user.h"
> >
> > #define ID_GRE 0
> >
>
> Hi Sabyasachi,
>
> I believe we have an identical patch enqueued already from a couple of
> weeks back.
Hmm, did I miss that one in patchwork?
Thanks,
//richard
^ permalink raw reply [flat|nested] 5+ messages in thread
* Re: [PATCH] um: Remove duplicate headers
2019-01-18 19:42 ` Richard Weinberger
@ 2019-01-18 20:00 ` Anton Ivanov
2019-01-18 21:54 ` Richard Weinberger
0 siblings, 1 reply; 5+ messages in thread
From: Anton Ivanov @ 2019-01-18 20:00 UTC (permalink / raw)
To: Richard Weinberger
Cc: Sabyasachi Gupta, yuehaibing, jdike, linux-um, linux-kernel,
jrdr.linux, brajeswar.linux
On 18/01/2019 19:42, Richard Weinberger wrote:
> Am Freitag, 18. Januar 2019, 20:23:07 CET schrieb Anton Ivanov:
>>
>> On 18/01/2019 14:58, Sabyasachi Gupta wrote:
>>> Remove sys/socket.h and sys/uio.h which are included more than once
>>>
>>> Signed-off-by: Sabyasachi Gupta <sabyasachi.linux@gmail.com>
>>> ---
>>> arch/um/drivers/vector_user.c | 2 --
>>> 1 file changed, 2 deletions(-)
>>>
>>> diff --git a/arch/um/drivers/vector_user.c b/arch/um/drivers/vector_user.c
>>> index d2c17dd..c863921 100644
>>> --- a/arch/um/drivers/vector_user.c
>>> +++ b/arch/um/drivers/vector_user.c
>>> @@ -23,7 +23,6 @@
>>> #include <netinet/ether.h>
>>> #include <linux/if_ether.h>
>>> #include <linux/if_packet.h>
>>> -#include <sys/socket.h>
>>> #include <sys/wait.h>
>>> #include <sys/uio.h>
>>> #include <linux/virtio_net.h>
>>> @@ -31,7 +30,6 @@
>>> #include <stdlib.h>
>>> #include <os.h>
>>> #include <um_malloc.h>
>>> -#include <sys/uio.h>
>>> #include "vector_user.h"
>>>
>>> #define ID_GRE 0
>>>
>>
>> Hi Sabyasachi,
>>
>> I believe we have an identical patch enqueued already from a couple of
>> weeks back.
>
> Hmm, did I miss that one in patchwork?
>
> Thanks,
> //richard
>
>
>
> _______________________________________________
> linux-um mailing list
> linux-um@lists.infradead.org
> http://lists.infradead.org/mailman/listinfo/linux-um
>
https://patchwork.ozlabs.org/patch/1020163/
A.
^ permalink raw reply [flat|nested] 5+ messages in thread
* Re: [PATCH] um: Remove duplicate headers
2019-01-18 20:00 ` Anton Ivanov
@ 2019-01-18 21:54 ` Richard Weinberger
0 siblings, 0 replies; 5+ messages in thread
From: Richard Weinberger @ 2019-01-18 21:54 UTC (permalink / raw)
To: Anton Ivanov
Cc: Sabyasachi Gupta, yuehaibing, jdike, linux-um, linux-kernel,
jrdr.linux, brajeswar.linux
Am Freitag, 18. Januar 2019, 21:00:22 CET schrieb Anton Ivanov:
> >> Hi Sabyasachi,
> >>
> >> I believe we have an identical patch enqueued already from a couple of
> >> weeks back.
> >
> > Hmm, did I miss that one in patchwork?
> >
> > Thanks,
> > //richard
> >
> >
> >
> > _______________________________________________
> > linux-um mailing list
> > linux-um@lists.infradead.org
> > http://lists.infradead.org/mailman/listinfo/linux-um
> >
> https://patchwork.ozlabs.org/patch/1020163/
Ahh, I thought I forgot this for the last merge window.
Now things make sense again.
Anton, can you please test/Ack the patch? Then it can go to -next.
Thanks,
//richard
^ permalink raw reply [flat|nested] 5+ messages in thread
end of thread, other threads:[~2019-01-18 21:54 UTC | newest]
Thread overview: 5+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2019-01-18 14:58 [PATCH] um: Remove duplicate headers Sabyasachi Gupta
2019-01-18 19:23 ` Anton Ivanov
2019-01-18 19:42 ` Richard Weinberger
2019-01-18 20:00 ` Anton Ivanov
2019-01-18 21:54 ` Richard Weinberger
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).