linux-kernel.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
* Bad MAINTAINERS pattern in section 'STAGING - FLARION FT1000 DRIVERS'
@ 2018-09-28 22:04 Joe Perches
  2018-09-29  0:46 ` Greg Kroah-Hartman
  0 siblings, 1 reply; 3+ messages in thread
From: Joe Perches @ 2018-09-28 22:04 UTC (permalink / raw)
  To: linux-kernel
  Cc: Marek Belisko, Arnd Bergmann, Deepa Dinamani, Greg Kroah-Hartman

Please fix this defect appropriately.

linux-next MAINTAINERS section:

	13899	STAGING - FLARION FT1000 DRIVERS
	13900	M:	Marek Belisko <marek.belisko@gmail.com>
	13901	S:	Odd Fixes
-->	13902	F:	drivers/staging/ft1000/

Commit that introduced this:

commit a0138163cfbfdfbdc20e4477c77bd7046bd66bb4
 Author: Joe Perches <joe@perches.com>
 Date:   Tue Jul 5 15:21:34 2011 -0700
 
     MAINTAINERS: Add remaining staging entries
     
     Add the staging entries from various TODO files
     to MAINTAINERS.  Add a few web links as well.
     
     Miscellaneous staging typo section header fix.
     
     Signed-off-by: Joe Perches <joe@perches.com>
     Signed-off-by: Greg Kroah-Hartman <gregkh@suse.de>
 
  MAINTAINERS | 69 ++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++-
  1 file changed, 68 insertions(+), 1 deletion(-)

Last commit with drivers/staging/ft1000/

commit 6512edec48b2ccfe9bb969ce26ebbbcd49de6c4b
Author: Deepa Dinamani <deepa.kernel@gmail.com>
Date:   Wed Oct 21 18:42:37 2015 -0700

    staging: ft1000: remove obsolete driver
    
    Remove support for Qleadtek Flash-OFDM modems. Telecom carrier is
    discontinuing service for the radio technology.
    See http://www.gtigroup.org/news/ind/2015-08-18/6996.html.
    
    Suggested-by: Arnd Bergmann <arnd@arndb.de>
    Signed-off-by: Deepa Dinamani <deepa.kernel@gmail.com>
    Acked-by: Arnd Bergmann <arnd@arndb.de>
    Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>

 drivers/staging/Kconfig                            |    2 -
 drivers/staging/Makefile                           |    1 -
 drivers/staging/ft1000/Kconfig                     |   22 -
 drivers/staging/ft1000/Makefile                    |    3 -
 drivers/staging/ft1000/TODO                        |    9 -
 drivers/staging/ft1000/ft1000-pcmcia/Makefile      |    2 -
 drivers/staging/ft1000/ft1000-pcmcia/boot.h        |  158 --
 drivers/staging/ft1000/ft1000-pcmcia/ft1000.h      |   70 -
 drivers/staging/ft1000/ft1000-pcmcia/ft1000.img    |  Bin 305770 -> 0 bytes
 drivers/staging/ft1000/ft1000-pcmcia/ft1000_cs.c   |  158 --
 drivers/staging/ft1000/ft1000-pcmcia/ft1000_dnld.c |  762 --------
 drivers/staging/ft1000/ft1000-pcmcia/ft1000_hw.c   | 2068 --------------------
 drivers/staging/ft1000/ft1000-usb/Makefile         |    3 -
 drivers/staging/ft1000/ft1000-usb/ft1000_debug.c   |  789 --------
 .../staging/ft1000/ft1000-usb/ft1000_download.c    | 1058 ----------
 drivers/staging/ft1000/ft1000-usb/ft1000_hw.c      | 1586 ---------------
 drivers/staging/ft1000/ft1000-usb/ft1000_ioctl.h   |  123 --
 drivers/staging/ft1000/ft1000-usb/ft1000_usb.c     |  248 ---
 drivers/staging/ft1000/ft1000-usb/ft1000_usb.h     |  150 --
 drivers/staging/ft1000/ft1000-usb/ft3000.img       |  Bin 280414 -> 0 bytes
 drivers/staging/ft1000/ft1000.h                    |  366 ----
 21 files changed, 7578 deletions(-)

^ permalink raw reply	[flat|nested] 3+ messages in thread

* Re: Bad MAINTAINERS pattern in section 'STAGING - FLARION FT1000 DRIVERS'
  2018-09-28 22:04 Bad MAINTAINERS pattern in section 'STAGING - FLARION FT1000 DRIVERS' Joe Perches
@ 2018-09-29  0:46 ` Greg Kroah-Hartman
  2018-09-29  1:15   ` Joe Perches
  0 siblings, 1 reply; 3+ messages in thread
From: Greg Kroah-Hartman @ 2018-09-29  0:46 UTC (permalink / raw)
  To: Joe Perches; +Cc: linux-kernel, Marek Belisko, Arnd Bergmann, Deepa Dinamani

On Fri, Sep 28, 2018 at 03:04:23PM -0700, Joe Perches wrote:
> Please fix this defect appropriately.
> 
> linux-next MAINTAINERS section:
> 
> 	13899	STAGING - FLARION FT1000 DRIVERS
> 	13900	M:	Marek Belisko <marek.belisko@gmail.com>
> 	13901	S:	Odd Fixes
> -->	13902	F:	drivers/staging/ft1000/
> 
> Commit that introduced this:
> 
> commit a0138163cfbfdfbdc20e4477c77bd7046bd66bb4
>  Author: Joe Perches <joe@perches.com>
>  Date:   Tue Jul 5 15:21:34 2011 -0700
>  
>      MAINTAINERS: Add remaining staging entries
>      
>      Add the staging entries from various TODO files
>      to MAINTAINERS.  Add a few web links as well.
>      
>      Miscellaneous staging typo section header fix.
>      
>      Signed-off-by: Joe Perches <joe@perches.com>
>      Signed-off-by: Greg Kroah-Hartman <gregkh@suse.de>
>  
>   MAINTAINERS | 69 ++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++-
>   1 file changed, 68 insertions(+), 1 deletion(-)

So you are going to fix this, considering you created the problem?

This is an odd request to make of yourself in public, or was this a
script gone wrong?

confused,

greg k-h

^ permalink raw reply	[flat|nested] 3+ messages in thread

* Re: Bad MAINTAINERS pattern in section 'STAGING - FLARION FT1000 DRIVERS'
  2018-09-29  0:46 ` Greg Kroah-Hartman
@ 2018-09-29  1:15   ` Joe Perches
  0 siblings, 0 replies; 3+ messages in thread
From: Joe Perches @ 2018-09-29  1:15 UTC (permalink / raw)
  To: Greg Kroah-Hartman
  Cc: linux-kernel, Marek Belisko, Arnd Bergmann, Deepa Dinamani

[-- Attachment #1: Type: text/plain, Size: 2592 bytes --]

On Fri, 2018-09-28 at 17:46 -0700, Greg Kroah-Hartman wrote:
> On Fri, Sep 28, 2018 at 03:04:23PM -0700, Joe Perches wrote:
> > Please fix this defect appropriately.
> > 
> > linux-next MAINTAINERS section:
> > 
> > 	13899	STAGING - FLARION FT1000 DRIVERS
> > 	13900	M:	Marek Belisko <marek.belisko@gmail.com>
> > 	13901	S:	Odd Fixes
> > -->	13902	F:	drivers/staging/ft1000/
> > 
> > Commit that introduced this:
> > 
> > commit a0138163cfbfdfbdc20e4477c77bd7046bd66bb4
> >  Author: Joe Perches <joe@perches.com>
> >  Date:   Tue Jul 5 15:21:34 2011 -0700
> >  
> >      MAINTAINERS: Add remaining staging entries
> >      
> >      Add the staging entries from various TODO files
> >      to MAINTAINERS.  Add a few web links as well.
> >      
> >      Miscellaneous staging typo section header fix.
> >      
> >      Signed-off-by: Joe Perches <joe@perches.com>
> >      Signed-off-by: Greg Kroah-Hartman <gregkh@suse.de>
> >  
> >   MAINTAINERS | 69 ++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++-
> >   1 file changed, 68 insertions(+), 1 deletion(-)
> 
> So you are going to fix this, considering you created the problem?

_I_ did not create this problem.

You neglected to read the commit information below this in the
parent email.

When I wrote the MAINTAINERS patch in 2011, the files existed.

The files were removed in 2015 and you signed-off on their removal.

----------------------------------------------
Last commit with drivers/staging/ft1000/

commit 6512edec48b2ccfe9bb969ce26ebbbcd49de6c4b
Author: Deepa Dinamani <deepa.kernel@gmail.com>
Date:   Wed Oct 21 18:42:37 2015 -0700

    staging: ft1000: remove obsolete driver
    
    Remove support for Qleadtek Flash-OFDM modems. Telecom carrier is
    discontinuing service for the radio technology.
    See http://www.gtigroup.org/news/ind/2015-08-18/6996.html.
    
    Suggested-by: Arnd Bergmann <arnd@arndb.de>
    Signed-off-by: Deepa Dinamani <deepa.kernel@gmail.com>
    Acked-by: Arnd Bergmann <arnd@arndb.de>
    Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
----------------------------------------------

> This is an odd request to make of yourself in public, or was this a
> script gone wrong?

It was not a script gone wrong, though the output and emails
were scripted.

> confused,

No worries, it's easy to miss stuff.

fyi: the silly script I wrote is attached

Done using the latest -next with an empty patterns directory

$ perl ./scripts/get_maintainer.pl --self-test=patterns | \
  cut -f2 -d: | \
  while read line ; do \
    perl ./dump_section.perl $line \
  done


[-- Attachment #2: dump_section.perl --]
[-- Type: application/x-perl, Size: 2579 bytes --]

^ permalink raw reply	[flat|nested] 3+ messages in thread

end of thread, other threads:[~2018-09-29  1:15 UTC | newest]

Thread overview: 3+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2018-09-28 22:04 Bad MAINTAINERS pattern in section 'STAGING - FLARION FT1000 DRIVERS' Joe Perches
2018-09-29  0:46 ` Greg Kroah-Hartman
2018-09-29  1:15   ` Joe Perches

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).