From: Sibi Sankar <sibis@codeaurora.org>
To: Bjorn Andersson <bjorn.andersson@linaro.org>
Cc: Matthias Kaehlcke <mka@chromium.org>,
p.zabel@pengutronix.de, robh+dt@kernel.org,
linux-remoteproc@vger.kernel.org, linux-kernel@vger.kernel.org,
devicetree@vger.kernel.org, ohad@wizery.com,
mark.rutland@arm.com, sricharan@codeaurora.org,
akdwived@codeaurora.org, linux-arm-msm@vger.kernel.org,
tsoni@codeaurora.org, linux-remoteproc-owner@vger.kernel.org
Subject: Re: [PATCH v2 2/6] reset: qcom: PDC Global (Power Domain Controller) reset controller
Date: Tue, 28 Aug 2018 12:41:20 +0530 [thread overview]
Message-ID: <e9de1c7b6ba51f825389c3fad81f633d@codeaurora.org> (raw)
In-Reply-To: <20180828030253.GF2523@minitux>
Hi Bjorn/Matthias,
Thanks for the review, will fix them in the next-respin.
On 2018-08-28 08:32, Bjorn Andersson wrote:
> On Mon 27 Aug 17:22 PDT 2018, Matthias Kaehlcke wrote:
>> On Fri, Aug 24, 2018 at 06:48:56PM +0530, Sibi Sankar wrote:
>> > diff --git a/drivers/reset/reset-qcom-pdc.c b/drivers/reset/reset-qcom-pdc.c
> [..]
>> > +struct qcom_pdc_desc {
>> > + const struct regmap_config *config;
>> > + const struct qcom_pdc_reset_map *resets;
>> > + size_t num_resets;
>> > +};
>>
>> Not sure if this structure adds much value or just a layer of
>> indirection:
>>
>> - .config is only accessed in _probe(), sdm845_pdc_regmap_config could
>> be used directly
>> - .resets is used in _(de)assert(), sdm845_pdc_resets could be used
>> directly
>> - .num_resets is only accessed in _probe(),
>> ARRAY_SIZE(sdm845_pdc_resets) could be used instead
>>
>> It probably makes sense if it is planned to support reset controllers
>> of other SoCs with this driver.
>>
>
> I like this suggestion, once we need the configurability we can add the
> type for it. It also shows that only .resets would need to be
> referenced
> by qcom_pdc_reset_data.
>
Will change it accordingly
>> > +struct qcom_pdc_reset_data {
>> > + struct reset_controller_dev rcdev;
>> > + struct regmap *regmap;
>> > + const struct qcom_pdc_desc *desc;
>> > +};
> [..]
>> > +static int qcom_pdc_reset_probe(struct platform_device *pdev)
>> > +{
> [..]
>> > + data->regmap = devm_regmap_init_mmio(dev, base, desc->config);
>> > + if (IS_ERR(data->regmap)) {
>> > + dev_err(dev, "Unable to get pdc-global regmap");
>>
>> Add missing '\n'
>>
>> Say 'pdc-reset' instead of 'pdc-global'? (see also my other comment
>> below).
>>
>
> This regmap is created out of the single anonymous "reg", so I think
> the
> error should be reduced to "Unable to initialize regmap\n".
>
Sure will add it but aren't we trying to regmap the entire pdc-global
register space though?
> [..]
>> > +static const struct of_device_id qcom_pdc_reset_of_match[] = {
>> > + { .compatible = "qcom,sdm845-pdc-global", .data = &sdm845_pdc_desc },
>>
>> Should this be 'qcom,sdm845-pdc-reset' which is more specific than
>> 'global' and in line with the name and purpose of the driver?
>> Obviously this would require to adjust the bindings doc too.
>>
>
> No, the binding describes the hardware block named "PDC Global",
> currently implemented as a reset controller. The reason for doing this
> is so that we one day can expose additional interfaces in a backwards
> compatible fashion.
>
> Regards,
> Bjorn
--
-- Sibi Sankar --
Qualcomm Innovation Center, Inc. is a member of Code Aurora Forum,
a Linux Foundation Collaborative Project.
next prev parent reply other threads:[~2018-08-28 7:11 UTC|newest]
Thread overview: 19+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-08-24 13:18 [PATCH v2 0/6] Add support for PDC Global on SDM845 SoCs Sibi Sankar
2018-08-24 13:18 ` [PATCH v2 1/6] dt-bindings: reset: Add PDC Global binding for " Sibi Sankar
2018-08-28 0:33 ` Bjorn Andersson
2018-08-28 0:38 ` Matthias Kaehlcke
2018-08-28 6:08 ` sibis
2018-08-28 17:11 ` Matthias Kaehlcke
2018-08-29 0:43 ` Rob Herring
2018-08-24 13:18 ` [PATCH v2 2/6] reset: qcom: PDC Global (Power Domain Controller) reset controller Sibi Sankar
2018-08-28 0:22 ` Matthias Kaehlcke
2018-08-28 3:02 ` Bjorn Andersson
2018-08-28 7:11 ` Sibi Sankar [this message]
2018-08-28 16:56 ` Matthias Kaehlcke
2018-08-24 13:18 ` [PATCH v2 3/6] dt-bindings: remoteproc: Remove additional definition tag Sibi Sankar
2018-08-28 0:44 ` Matthias Kaehlcke
2018-08-29 16:38 ` Sibi Sankar
2018-08-24 13:18 ` [PATCH v2 4/6] dt-bindings: remoteproc: Add PDC reset binding for Q6V5 PIL Sibi Sankar
2018-08-29 0:44 ` Rob Herring
2018-08-24 13:18 ` [PATCH v2 5/6] remoteproc: qcom: q6v5-pil: Explicitly get mss_restart line Sibi Sankar
2018-08-24 13:19 ` [PATCH v2 6/6] remoteproc: qcom: q6v5-pil: Add PDC reset for modem on SDM845 SoCs Sibi Sankar
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=e9de1c7b6ba51f825389c3fad81f633d@codeaurora.org \
--to=sibis@codeaurora.org \
--cc=akdwived@codeaurora.org \
--cc=bjorn.andersson@linaro.org \
--cc=devicetree@vger.kernel.org \
--cc=linux-arm-msm@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-remoteproc-owner@vger.kernel.org \
--cc=linux-remoteproc@vger.kernel.org \
--cc=mark.rutland@arm.com \
--cc=mka@chromium.org \
--cc=ohad@wizery.com \
--cc=p.zabel@pengutronix.de \
--cc=robh+dt@kernel.org \
--cc=sricharan@codeaurora.org \
--cc=tsoni@codeaurora.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).