* [PATCH] platform/surface: gpe: Add support for Surface Pro 8
@ 2022-04-29 18:00 Maximilian Luz
2022-05-06 10:16 ` Hans de Goede
0 siblings, 1 reply; 2+ messages in thread
From: Maximilian Luz @ 2022-04-29 18:00 UTC (permalink / raw)
To: Hans de Goede
Cc: Maximilian Luz, Mark Gross, platform-driver-x86, linux-kernel
The new Surface Pro 8 uses GPEs for lid events as well. Add an entry for
that so that the lid can be used to wake the device. Note that this is a
device with a keyboard type-cover, where this acts as the "lid".
Signed-off-by: Maximilian Luz <luzmaximilian@gmail.com>
---
drivers/platform/surface/surface_gpe.c | 8 ++++++++
1 file changed, 8 insertions(+)
diff --git a/drivers/platform/surface/surface_gpe.c b/drivers/platform/surface/surface_gpe.c
index c1775db29efb..ec66fde28e75 100644
--- a/drivers/platform/surface/surface_gpe.c
+++ b/drivers/platform/surface/surface_gpe.c
@@ -99,6 +99,14 @@ static const struct dmi_system_id dmi_lid_device_table[] = {
},
.driver_data = (void *)lid_device_props_l4D,
},
+ {
+ .ident = "Surface Pro 8",
+ .matches = {
+ DMI_EXACT_MATCH(DMI_SYS_VENDOR, "Microsoft Corporation"),
+ DMI_EXACT_MATCH(DMI_PRODUCT_NAME, "Surface Pro 8"),
+ },
+ .driver_data = (void *)lid_device_props_l4B,
+ },
{
.ident = "Surface Book 1",
.matches = {
--
2.36.0
^ permalink raw reply related [flat|nested] 2+ messages in thread
* Re: [PATCH] platform/surface: gpe: Add support for Surface Pro 8
2022-04-29 18:00 [PATCH] platform/surface: gpe: Add support for Surface Pro 8 Maximilian Luz
@ 2022-05-06 10:16 ` Hans de Goede
0 siblings, 0 replies; 2+ messages in thread
From: Hans de Goede @ 2022-05-06 10:16 UTC (permalink / raw)
To: Maximilian Luz; +Cc: Mark Gross, platform-driver-x86, linux-kernel
Hi,
On 4/29/22 20:00, Maximilian Luz wrote:
> The new Surface Pro 8 uses GPEs for lid events as well. Add an entry for
> that so that the lid can be used to wake the device. Note that this is a
> device with a keyboard type-cover, where this acts as the "lid".
>
> Signed-off-by: Maximilian Luz <luzmaximilian@gmail.com>
Thank you for your patch, I've applied this patch to my review-hans
branch:
https://git.kernel.org/pub/scm/linux/kernel/git/pdx86/platform-drivers-x86.git/log/?h=review-hans
Note it will show up in my review-hans branch once I've pushed my
local branch there, which might take a while.
Once I've run some tests on this branch the patches there will be
added to the platform-drivers-x86/for-next branch and eventually
will be included in the pdx86 pull-request to Linus for the next
merge-window.
Regards,
Hans
> ---
> drivers/platform/surface/surface_gpe.c | 8 ++++++++
> 1 file changed, 8 insertions(+)
>
> diff --git a/drivers/platform/surface/surface_gpe.c b/drivers/platform/surface/surface_gpe.c
> index c1775db29efb..ec66fde28e75 100644
> --- a/drivers/platform/surface/surface_gpe.c
> +++ b/drivers/platform/surface/surface_gpe.c
> @@ -99,6 +99,14 @@ static const struct dmi_system_id dmi_lid_device_table[] = {
> },
> .driver_data = (void *)lid_device_props_l4D,
> },
> + {
> + .ident = "Surface Pro 8",
> + .matches = {
> + DMI_EXACT_MATCH(DMI_SYS_VENDOR, "Microsoft Corporation"),
> + DMI_EXACT_MATCH(DMI_PRODUCT_NAME, "Surface Pro 8"),
> + },
> + .driver_data = (void *)lid_device_props_l4B,
> + },
> {
> .ident = "Surface Book 1",
> .matches = {
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2022-05-06 10:16 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2022-04-29 18:00 [PATCH] platform/surface: gpe: Add support for Surface Pro 8 Maximilian Luz
2022-05-06 10:16 ` Hans de Goede
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).