* [PATCH] ALSA: hda: remove redundant variable in snd_hdac_stream_start()
@ 2023-02-09 12:17 Zhang Yiqun
2023-02-09 14:32 ` Mark Brown
2023-02-10 9:07 ` Takashi Iwai
0 siblings, 2 replies; 4+ messages in thread
From: Zhang Yiqun @ 2023-02-09 12:17 UTC (permalink / raw)
To: cezary.rojewski, pierre-louis.bossart, liam.r.girdwood,
peter.ujfalusi, yung-chuan.liao, ranjani.sridharan, kai.vehmanen,
broonie, perex, tiwai, amadeuszx.slawinski, kuninori.morimoto.gx,
ckeepax
Cc: alsa-devel, linux-kernel, Zhang Yiqun
This 2nd variables are all set as true in treewide. So I think
it can be removed for easy understanding.
Signed-off-by: Zhang Yiqun <zhangyiqun@phytium.com.cn>
---
include/sound/hdaudio.h | 2 +-
sound/hda/hdac_stream.c | 7 ++-----
sound/pci/hda/hda_controller.c | 2 +-
sound/soc/intel/avs/pcm.c | 2 +-
sound/soc/intel/avs/probes.c | 2 +-
sound/soc/intel/skylake/skl-pcm.c | 4 ++--
6 files changed, 8 insertions(+), 11 deletions(-)
diff --git a/include/sound/hdaudio.h b/include/sound/hdaudio.h
index a6872537724d..536612c6ab0c 100644
--- a/include/sound/hdaudio.h
+++ b/include/sound/hdaudio.h
@@ -575,7 +575,7 @@ void snd_hdac_stream_cleanup(struct hdac_stream *azx_dev);
int snd_hdac_stream_setup_periods(struct hdac_stream *azx_dev);
int snd_hdac_stream_set_params(struct hdac_stream *azx_dev,
unsigned int format_val);
-void snd_hdac_stream_start(struct hdac_stream *azx_dev, bool fresh_start);
+void snd_hdac_stream_start(struct hdac_stream *azx_dev);
void snd_hdac_stream_stop(struct hdac_stream *azx_dev);
void snd_hdac_stop_streams(struct hdac_bus *bus);
void snd_hdac_stop_streams_and_chip(struct hdac_bus *bus);
diff --git a/sound/hda/hdac_stream.c b/sound/hda/hdac_stream.c
index 547adbc22590..1f56fd33b9af 100644
--- a/sound/hda/hdac_stream.c
+++ b/sound/hda/hdac_stream.c
@@ -124,11 +124,10 @@ EXPORT_SYMBOL_GPL(snd_hdac_stream_init);
/**
* snd_hdac_stream_start - start a stream
* @azx_dev: HD-audio core stream to start
- * @fresh_start: false = wallclock timestamp relative to period wallclock
*
* Start a stream, set start_wallclk and set the running flag.
*/
-void snd_hdac_stream_start(struct hdac_stream *azx_dev, bool fresh_start)
+void snd_hdac_stream_start(struct hdac_stream *azx_dev)
{
struct hdac_bus *bus = azx_dev->bus;
int stripe_ctl;
@@ -136,8 +135,6 @@ void snd_hdac_stream_start(struct hdac_stream *azx_dev, bool fresh_start)
trace_snd_hdac_stream_start(bus, azx_dev);
azx_dev->start_wallclk = snd_hdac_chip_readl(bus, WALLCLK);
- if (!fresh_start)
- azx_dev->start_wallclk -= azx_dev->period_wallclk;
/* enable SIE */
snd_hdac_chip_updatel(bus, INTCTL,
@@ -966,7 +963,7 @@ EXPORT_SYMBOL_GPL(snd_hdac_dsp_prepare);
void snd_hdac_dsp_trigger(struct hdac_stream *azx_dev, bool start)
{
if (start)
- snd_hdac_stream_start(azx_dev, true);
+ snd_hdac_stream_start(azx_dev);
else
snd_hdac_stream_stop(azx_dev);
}
diff --git a/sound/pci/hda/hda_controller.c b/sound/pci/hda/hda_controller.c
index 0ff286b7b66b..c19d45618a09 100644
--- a/sound/pci/hda/hda_controller.c
+++ b/sound/pci/hda/hda_controller.c
@@ -257,7 +257,7 @@ static int azx_pcm_trigger(struct snd_pcm_substream *substream, int cmd)
azx_dev = get_azx_dev(s);
if (start) {
azx_dev->insufficient = 1;
- snd_hdac_stream_start(azx_stream(azx_dev), true);
+ snd_hdac_stream_start(azx_stream(azx_dev));
} else {
snd_hdac_stream_stop(azx_stream(azx_dev));
}
diff --git a/sound/soc/intel/avs/pcm.c b/sound/soc/intel/avs/pcm.c
index f930c5e86a84..b673b84ead32 100644
--- a/sound/soc/intel/avs/pcm.c
+++ b/sound/soc/intel/avs/pcm.c
@@ -647,7 +647,7 @@ static int avs_dai_fe_trigger(struct snd_pcm_substream *substream, int cmd, stru
case SNDRV_PCM_TRIGGER_START:
case SNDRV_PCM_TRIGGER_PAUSE_RELEASE:
spin_lock_irqsave(&bus->reg_lock, flags);
- snd_hdac_stream_start(hdac_stream(host_stream), true);
+ snd_hdac_stream_start(hdac_stream(host_stream));
spin_unlock_irqrestore(&bus->reg_lock, flags);
/* Timeout on DRSM poll shall not stop the resume so ignore the result. */
diff --git a/sound/soc/intel/avs/probes.c b/sound/soc/intel/avs/probes.c
index 29d63f2a9616..741565c6465a 100644
--- a/sound/soc/intel/avs/probes.c
+++ b/sound/soc/intel/avs/probes.c
@@ -190,7 +190,7 @@ static int avs_probe_compr_trigger(struct snd_compr_stream *cstream, int cmd,
case SNDRV_PCM_TRIGGER_PAUSE_RELEASE:
case SNDRV_PCM_TRIGGER_RESUME:
spin_lock_irqsave(&bus->reg_lock, cookie);
- snd_hdac_stream_start(hdac_stream(host_stream), true);
+ snd_hdac_stream_start(hdac_stream(host_stream));
spin_unlock_irqrestore(&bus->reg_lock, cookie);
break;
diff --git a/sound/soc/intel/skylake/skl-pcm.c b/sound/soc/intel/skylake/skl-pcm.c
index dc627d18518d..a4209d88b0c6 100644
--- a/sound/soc/intel/skylake/skl-pcm.c
+++ b/sound/soc/intel/skylake/skl-pcm.c
@@ -449,7 +449,7 @@ static int skl_decoupled_trigger(struct snd_pcm_substream *substream,
spin_lock_irqsave(&bus->reg_lock, cookie);
if (start) {
- snd_hdac_stream_start(hdac_stream(stream), true);
+ snd_hdac_stream_start(hdac_stream(stream));
snd_hdac_stream_timecounter_init(hstr, 0);
} else {
snd_hdac_stream_stop(hdac_stream(stream));
@@ -1134,7 +1134,7 @@ static int skl_coupled_trigger(struct snd_pcm_substream *substream,
continue;
stream = get_hdac_ext_stream(s);
if (start)
- snd_hdac_stream_start(hdac_stream(stream), true);
+ snd_hdac_stream_start(hdac_stream(stream));
else
snd_hdac_stream_stop(hdac_stream(stream));
}
--
2.17.1
^ permalink raw reply related [flat|nested] 4+ messages in thread
* Re: [PATCH] ALSA: hda: remove redundant variable in snd_hdac_stream_start()
2023-02-09 12:17 [PATCH] ALSA: hda: remove redundant variable in snd_hdac_stream_start() Zhang Yiqun
@ 2023-02-09 14:32 ` Mark Brown
2023-02-09 15:15 ` Pierre-Louis Bossart
2023-02-10 9:07 ` Takashi Iwai
1 sibling, 1 reply; 4+ messages in thread
From: Mark Brown @ 2023-02-09 14:32 UTC (permalink / raw)
To: Zhang Yiqun
Cc: cezary.rojewski, pierre-louis.bossart, liam.r.girdwood,
peter.ujfalusi, yung-chuan.liao, ranjani.sridharan, kai.vehmanen,
perex, tiwai, amadeuszx.slawinski, kuninori.morimoto.gx, ckeepax,
alsa-devel, linux-kernel
[-- Attachment #1: Type: text/plain, Size: 213 bytes --]
On Thu, Feb 09, 2023 at 08:17:23PM +0800, Zhang Yiqun wrote:
> This 2nd variables are all set as true in treewide. So I think
> it can be removed for easy understanding.
Acked-by: Mark Brown <broonie@kernel.org>
[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 488 bytes --]
^ permalink raw reply [flat|nested] 4+ messages in thread
* Re: [PATCH] ALSA: hda: remove redundant variable in snd_hdac_stream_start()
2023-02-09 14:32 ` Mark Brown
@ 2023-02-09 15:15 ` Pierre-Louis Bossart
0 siblings, 0 replies; 4+ messages in thread
From: Pierre-Louis Bossart @ 2023-02-09 15:15 UTC (permalink / raw)
To: Mark Brown, Zhang Yiqun
Cc: cezary.rojewski, liam.r.girdwood, peter.ujfalusi,
yung-chuan.liao, ranjani.sridharan, kai.vehmanen, tiwai,
amadeuszx.slawinski, kuninori.morimoto.gx, ckeepax, alsa-devel,
linux-kernel
On 2/9/23 08:32, Mark Brown wrote:
> On Thu, Feb 09, 2023 at 08:17:23PM +0800, Zhang Yiqun wrote:
>> This 2nd variables are all set as true in treewide. So I think
>> it can be removed for easy understanding.
>
> Acked-by: Mark Brown <broonie@kernel.org>
Reviewed-by: Pierre-Louis Bossart <pierre-louis.bossart@linux.intel.com>
Btw there's another type of always-true parameter, we have a full_reset
parameter that's not used.
sound/soc/intel/skylake$ git grep skl_init_chip
skl.c:static int skl_init_chip(struct hdac_bus *bus, bool full_reset)
skl.c: skl_init_chip(bus, true);
skl.c: skl_init_chip(bus, true);
skl.c: err = skl_init_chip(bus, true);
sound/soc/intel/avs$ git grep init_chip
core.c:static bool avs_hdac_bus_init_chip(struct hdac_bus *bus, bool
full_reset)
core.c: ret = snd_hdac_bus_init_chip(bus, full_reset);
core.c: avs_hdac_bus_init_chip(bus, true);
core.c: avs_hdac_bus_init_chip(bus, true);
core.c: avs_hdac_bus_init_chip(bus, true);
^ permalink raw reply [flat|nested] 4+ messages in thread
* Re: [PATCH] ALSA: hda: remove redundant variable in snd_hdac_stream_start()
2023-02-09 12:17 [PATCH] ALSA: hda: remove redundant variable in snd_hdac_stream_start() Zhang Yiqun
2023-02-09 14:32 ` Mark Brown
@ 2023-02-10 9:07 ` Takashi Iwai
1 sibling, 0 replies; 4+ messages in thread
From: Takashi Iwai @ 2023-02-10 9:07 UTC (permalink / raw)
To: Zhang Yiqun
Cc: cezary.rojewski, pierre-louis.bossart, liam.r.girdwood,
peter.ujfalusi, yung-chuan.liao, ranjani.sridharan, kai.vehmanen,
broonie, perex, tiwai, amadeuszx.slawinski, kuninori.morimoto.gx,
ckeepax, alsa-devel, linux-kernel
On Thu, 09 Feb 2023 13:17:23 +0100,
Zhang Yiqun wrote:
>
> This 2nd variables are all set as true in treewide. So I think
> it can be removed for easy understanding.
>
> Signed-off-by: Zhang Yiqun <zhangyiqun@phytium.com.cn>
Thanks, applied now.
Takashi
^ permalink raw reply [flat|nested] 4+ messages in thread
end of thread, other threads:[~2023-02-10 9:08 UTC | newest]
Thread overview: 4+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2023-02-09 12:17 [PATCH] ALSA: hda: remove redundant variable in snd_hdac_stream_start() Zhang Yiqun
2023-02-09 14:32 ` Mark Brown
2023-02-09 15:15 ` Pierre-Louis Bossart
2023-02-10 9:07 ` Takashi Iwai
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).