* [PATCH] HID: logitech-dj: add support of the G700(s) receiver
@ 2019-08-12 16:08 Benjamin Tissoires
2019-08-12 16:26 ` Hans de Goede
0 siblings, 1 reply; 3+ messages in thread
From: Benjamin Tissoires @ 2019-08-12 16:08 UTC (permalink / raw)
To: Hans de Goede, Jiri Kosina; +Cc: linux-input, linux-kernel, Benjamin Tissoires
Both the G700 and the G700s are sharing the same receiver.
Include support for this receiver in hid-logitech-dj so that userspace
can differentiate both.
Signed-off-by: Benjamin Tissoires <benjamin.tissoires@redhat.com>
---
drivers/hid/hid-logitech-dj.c | 5 +++++
1 file changed, 5 insertions(+)
diff --git a/drivers/hid/hid-logitech-dj.c b/drivers/hid/hid-logitech-dj.c
index c547cba05fbb..d6250b0cb9f8 100644
--- a/drivers/hid/hid-logitech-dj.c
+++ b/drivers/hid/hid-logitech-dj.c
@@ -959,6 +959,7 @@ static void logi_hidpp_recv_queue_notif(struct hid_device *hdev,
break;
case 0x07:
device_type = "eQUAD step 4 Gaming";
+ logi_hidpp_dev_conn_notif_equad(hdev, hidpp_report, &workitem);
break;
case 0x08:
device_type = "eQUAD step 4 for gamepads";
@@ -1832,6 +1833,10 @@ static const struct hid_device_id logi_dj_receivers[] = {
HID_USB_DEVICE(USB_VENDOR_ID_LOGITECH,
USB_DEVICE_ID_LOGITECH_NANO_RECEIVER_2),
.driver_data = recvr_type_hidpp},
+ { /* Logitech G700(s) receiver (0xc531) */
+ HID_USB_DEVICE(USB_VENDOR_ID_LOGITECH,
+ 0xc531),
+ .driver_data = recvr_type_gaming_hidpp},
{ /* Logitech lightspeed receiver (0xc539) */
HID_USB_DEVICE(USB_VENDOR_ID_LOGITECH,
USB_DEVICE_ID_LOGITECH_NANO_RECEIVER_LIGHTSPEED),
--
2.19.2
^ permalink raw reply related [flat|nested] 3+ messages in thread
* Re: [PATCH] HID: logitech-dj: add support of the G700(s) receiver
2019-08-12 16:08 [PATCH] HID: logitech-dj: add support of the G700(s) receiver Benjamin Tissoires
@ 2019-08-12 16:26 ` Hans de Goede
2019-08-23 10:06 ` Benjamin Tissoires
0 siblings, 1 reply; 3+ messages in thread
From: Hans de Goede @ 2019-08-12 16:26 UTC (permalink / raw)
To: Benjamin Tissoires, Jiri Kosina; +Cc: linux-input, linux-kernel
Hi,
On 12-08-19 18:08, Benjamin Tissoires wrote:
> Both the G700 and the G700s are sharing the same receiver.
> Include support for this receiver in hid-logitech-dj so that userspace
> can differentiate both.
>
> Signed-off-by: Benjamin Tissoires <benjamin.tissoires@redhat.com>
Nice, looks good to me:
Reviewed-by: Hans de Goede <hdegoede@redhat.com>
Regards,
Hans
> ---
> drivers/hid/hid-logitech-dj.c | 5 +++++
> 1 file changed, 5 insertions(+)
>
> diff --git a/drivers/hid/hid-logitech-dj.c b/drivers/hid/hid-logitech-dj.c
> index c547cba05fbb..d6250b0cb9f8 100644
> --- a/drivers/hid/hid-logitech-dj.c
> +++ b/drivers/hid/hid-logitech-dj.c
> @@ -959,6 +959,7 @@ static void logi_hidpp_recv_queue_notif(struct hid_device *hdev,
> break;
> case 0x07:
> device_type = "eQUAD step 4 Gaming";
> + logi_hidpp_dev_conn_notif_equad(hdev, hidpp_report, &workitem);
> break;
> case 0x08:
> device_type = "eQUAD step 4 for gamepads";
> @@ -1832,6 +1833,10 @@ static const struct hid_device_id logi_dj_receivers[] = {
> HID_USB_DEVICE(USB_VENDOR_ID_LOGITECH,
> USB_DEVICE_ID_LOGITECH_NANO_RECEIVER_2),
> .driver_data = recvr_type_hidpp},
> + { /* Logitech G700(s) receiver (0xc531) */
> + HID_USB_DEVICE(USB_VENDOR_ID_LOGITECH,
> + 0xc531),
> + .driver_data = recvr_type_gaming_hidpp},
> { /* Logitech lightspeed receiver (0xc539) */
> HID_USB_DEVICE(USB_VENDOR_ID_LOGITECH,
> USB_DEVICE_ID_LOGITECH_NANO_RECEIVER_LIGHTSPEED),
>
^ permalink raw reply [flat|nested] 3+ messages in thread
* Re: [PATCH] HID: logitech-dj: add support of the G700(s) receiver
2019-08-12 16:26 ` Hans de Goede
@ 2019-08-23 10:06 ` Benjamin Tissoires
0 siblings, 0 replies; 3+ messages in thread
From: Benjamin Tissoires @ 2019-08-23 10:06 UTC (permalink / raw)
To: Hans de Goede; +Cc: Jiri Kosina, open list:HID CORE LAYER, lkml
On Mon, Aug 12, 2019 at 6:26 PM Hans de Goede <hdegoede@redhat.com> wrote:
>
> Hi,
>
> On 12-08-19 18:08, Benjamin Tissoires wrote:
> > Both the G700 and the G700s are sharing the same receiver.
> > Include support for this receiver in hid-logitech-dj so that userspace
> > can differentiate both.
> >
> > Signed-off-by: Benjamin Tissoires <benjamin.tissoires@redhat.com>
>
> Nice, looks good to me:
>
> Reviewed-by: Hans de Goede <hdegoede@redhat.com>
thanks
Applied to for-5.4/logitech
Cheers,
Benjamin
>
> Regards,
>
> Hans
>
>
>
> > ---
> > drivers/hid/hid-logitech-dj.c | 5 +++++
> > 1 file changed, 5 insertions(+)
> >
> > diff --git a/drivers/hid/hid-logitech-dj.c b/drivers/hid/hid-logitech-dj.c
> > index c547cba05fbb..d6250b0cb9f8 100644
> > --- a/drivers/hid/hid-logitech-dj.c
> > +++ b/drivers/hid/hid-logitech-dj.c
> > @@ -959,6 +959,7 @@ static void logi_hidpp_recv_queue_notif(struct hid_device *hdev,
> > break;
> > case 0x07:
> > device_type = "eQUAD step 4 Gaming";
> > + logi_hidpp_dev_conn_notif_equad(hdev, hidpp_report, &workitem);
> > break;
> > case 0x08:
> > device_type = "eQUAD step 4 for gamepads";
> > @@ -1832,6 +1833,10 @@ static const struct hid_device_id logi_dj_receivers[] = {
> > HID_USB_DEVICE(USB_VENDOR_ID_LOGITECH,
> > USB_DEVICE_ID_LOGITECH_NANO_RECEIVER_2),
> > .driver_data = recvr_type_hidpp},
> > + { /* Logitech G700(s) receiver (0xc531) */
> > + HID_USB_DEVICE(USB_VENDOR_ID_LOGITECH,
> > + 0xc531),
> > + .driver_data = recvr_type_gaming_hidpp},
> > { /* Logitech lightspeed receiver (0xc539) */
> > HID_USB_DEVICE(USB_VENDOR_ID_LOGITECH,
> > USB_DEVICE_ID_LOGITECH_NANO_RECEIVER_LIGHTSPEED),
> >
^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2019-08-23 10:06 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2019-08-12 16:08 [PATCH] HID: logitech-dj: add support of the G700(s) receiver Benjamin Tissoires
2019-08-12 16:26 ` Hans de Goede
2019-08-23 10:06 ` Benjamin Tissoires
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).