* Re: [PATCH stable 4.4] powerpc/lib: fix book3s/32 boot failure due to code patching
[not found] <71dbc8bdad5da9f6cb0446535fb2a29c68fccf80.1557926850.git.christophe.leroy@c-s.fr>
@ 2019-05-15 14:16 ` Greg KH
2019-05-15 15:13 ` Christophe Leroy
0 siblings, 1 reply; 2+ messages in thread
From: Greg KH @ 2019-05-15 14:16 UTC (permalink / raw)
To: Christophe Leroy
Cc: Benjamin Herrenschmidt, Paul Mackerras, Michael Ellerman,
erhard_f, Michael Neuling, linux-kernel, linuxppc-dev, stable
On Wed, May 15, 2019 at 01:30:42PM +0000, Christophe Leroy wrote:
> [Backport of upstream commit b45ba4a51cde29b2939365ef0c07ad34c8321789]
>
> On powerpc32, patch_instruction() is called by apply_feature_fixups()
> which is called from early_init()
>
> There is the following note in front of early_init():
> * Note that the kernel may be running at an address which is different
> * from the address that it was linked at, so we must use RELOC/PTRRELOC
> * to access static data (including strings). -- paulus
>
> Therefore init_mem_is_free must be accessed with PTRRELOC()
>
> Link: https://bugzilla.kernel.org/show_bug.cgi?id=203597
> Signed-off-by: Christophe Leroy <christophe.leroy@c-s.fr>
>
> ---
> Can't apply the upstream commit as such due to several other unrelated stuff
> like for instance STRICT_KERNEL_RWX which are missing.
> So instead, using same approach as for commit 252eb55816a6f69ef9464cad303cdb3326cdc61d
>
> Removed the Fixes: tag as I don't know yet the commit Id of the fixed commit on 4.4 branch.
> ---
> arch/powerpc/lib/code-patching.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
Now added, thanks.
greg k-h
^ permalink raw reply [flat|nested] 2+ messages in thread
* Re: [PATCH stable 4.4] powerpc/lib: fix book3s/32 boot failure due to code patching
2019-05-15 14:16 ` [PATCH stable 4.4] powerpc/lib: fix book3s/32 boot failure due to code patching Greg KH
@ 2019-05-15 15:13 ` Christophe Leroy
0 siblings, 0 replies; 2+ messages in thread
From: Christophe Leroy @ 2019-05-15 15:13 UTC (permalink / raw)
To: Greg KH
Cc: Benjamin Herrenschmidt, Paul Mackerras, Michael Ellerman,
erhard_f, Michael Neuling, linux-kernel, linuxppc-dev, stable
Le 15/05/2019 à 16:16, Greg KH a écrit :
> On Wed, May 15, 2019 at 01:30:42PM +0000, Christophe Leroy wrote:
>> [Backport of upstream commit b45ba4a51cde29b2939365ef0c07ad34c8321789]
>>
>> On powerpc32, patch_instruction() is called by apply_feature_fixups()
>> which is called from early_init()
>>
>> There is the following note in front of early_init():
>> * Note that the kernel may be running at an address which is different
>> * from the address that it was linked at, so we must use RELOC/PTRRELOC
>> * to access static data (including strings). -- paulus
>>
>> Therefore init_mem_is_free must be accessed with PTRRELOC()
>>
>> Link: https://bugzilla.kernel.org/show_bug.cgi?id=203597
>> Signed-off-by: Christophe Leroy <christophe.leroy@c-s.fr>
>>
>> ---
>> Can't apply the upstream commit as such due to several other unrelated stuff
>> like for instance STRICT_KERNEL_RWX which are missing.
>> So instead, using same approach as for commit 252eb55816a6f69ef9464cad303cdb3326cdc61d
>>
>> Removed the Fixes: tag as I don't know yet the commit Id of the fixed commit on 4.4 branch.
>> ---
>> arch/powerpc/lib/code-patching.c | 2 +-
>> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> Now added, thanks.
>
Thanks,
However you took the commit log from the upstream commit, which doesn't
corresponds exactly to the change being done here and described in the
backport patch
Christophe
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2019-05-15 15:13 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
[not found] <71dbc8bdad5da9f6cb0446535fb2a29c68fccf80.1557926850.git.christophe.leroy@c-s.fr>
2019-05-15 14:16 ` [PATCH stable 4.4] powerpc/lib: fix book3s/32 boot failure due to code patching Greg KH
2019-05-15 15:13 ` Christophe Leroy
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).