* [PATCH] ray_cs: use true,false for bool variable
@ 2020-04-26 9:41 Jason Yan
2020-04-26 9:47 ` Sergei Shtylyov
0 siblings, 1 reply; 4+ messages in thread
From: Jason Yan @ 2020-04-26 9:41 UTC (permalink / raw)
To: kvalo, davem, adobriyan, tglx, linux-wireless, netdev, linux-kernel
Cc: Jason Yan
Fix the following coccicheck warning:
drivers/net/wireless/ray_cs.c:2797:5-14: WARNING: Comparison of 0/1 to
bool variable
drivers/net/wireless/ray_cs.c:2798:2-11: WARNING: Assignment of 0/1 to
bool variable
Signed-off-by: Jason Yan <yanaijie@huawei.com>
---
drivers/net/wireless/ray_cs.c | 4 ++--
1 file changed, 2 insertions(+), 2 deletions(-)
diff --git a/drivers/net/wireless/ray_cs.c b/drivers/net/wireless/ray_cs.c
index c1d542bfa530..f9402424accd 100644
--- a/drivers/net/wireless/ray_cs.c
+++ b/drivers/net/wireless/ray_cs.c
@@ -2794,8 +2794,8 @@ static int __init init_ray_cs(void)
proc_create_data("driver/ray_cs/translate", 0200, NULL, &int_proc_ops,
&translate);
#endif
- if (translate != 0)
- translate = 1;
+ if (!translate)
+ translate = true;
return 0;
} /* init_ray_cs */
--
2.21.1
^ permalink raw reply related [flat|nested] 4+ messages in thread
* Re: [PATCH] ray_cs: use true,false for bool variable
2020-04-26 9:41 [PATCH] ray_cs: use true,false for bool variable Jason Yan
@ 2020-04-26 9:47 ` Sergei Shtylyov
2020-04-26 10:27 ` Jason Yan
0 siblings, 1 reply; 4+ messages in thread
From: Sergei Shtylyov @ 2020-04-26 9:47 UTC (permalink / raw)
To: Jason Yan, kvalo, davem, adobriyan, tglx, linux-wireless, netdev,
linux-kernel
Hello!
On 26.04.2020 12:41, Jason Yan wrote:
> Fix the following coccicheck warning:
>
> drivers/net/wireless/ray_cs.c:2797:5-14: WARNING: Comparison of 0/1 to
> bool variable
> drivers/net/wireless/ray_cs.c:2798:2-11: WARNING: Assignment of 0/1 to
> bool variable
>
> Signed-off-by: Jason Yan <yanaijie@huawei.com>
> ---
> drivers/net/wireless/ray_cs.c | 4 ++--
> 1 file changed, 2 insertions(+), 2 deletions(-)
>
> diff --git a/drivers/net/wireless/ray_cs.c b/drivers/net/wireless/ray_cs.c
> index c1d542bfa530..f9402424accd 100644
> --- a/drivers/net/wireless/ray_cs.c
> +++ b/drivers/net/wireless/ray_cs.c
> @@ -2794,8 +2794,8 @@ static int __init init_ray_cs(void)
> proc_create_data("driver/ray_cs/translate", 0200, NULL, &int_proc_ops,
> &translate);
> #endif
> - if (translate != 0)
> - translate = 1;
> + if (!translate)
That inverts the original logic, no?
> + translate = true;
Actually, that whole comparison/assignment doesn't make sense, if we use
bool...
[...]
MBR, Sergei
^ permalink raw reply [flat|nested] 4+ messages in thread
* Re: [PATCH] ray_cs: use true,false for bool variable
2020-04-26 9:47 ` Sergei Shtylyov
@ 2020-04-26 10:27 ` Jason Yan
2020-04-26 10:33 ` Jason Yan
0 siblings, 1 reply; 4+ messages in thread
From: Jason Yan @ 2020-04-26 10:27 UTC (permalink / raw)
To: Sergei Shtylyov, kvalo, davem, adobriyan, tglx, linux-wireless,
netdev, linux-kernel
在 2020/4/26 17:47, Sergei Shtylyov 写道:
> Hello!
>
> On 26.04.2020 12:41, Jason Yan wrote:
>
>> Fix the following coccicheck warning:
>>
>> drivers/net/wireless/ray_cs.c:2797:5-14: WARNING: Comparison of 0/1 to
>> bool variable
>> drivers/net/wireless/ray_cs.c:2798:2-11: WARNING: Assignment of 0/1 to
>> bool variable
>>
>> Signed-off-by: Jason Yan <yanaijie@huawei.com>
>> ---
>> drivers/net/wireless/ray_cs.c | 4 ++--
>> 1 file changed, 2 insertions(+), 2 deletions(-)
>>
>> diff --git a/drivers/net/wireless/ray_cs.c
>> b/drivers/net/wireless/ray_cs.c
>> index c1d542bfa530..f9402424accd 100644
>> --- a/drivers/net/wireless/ray_cs.c
>> +++ b/drivers/net/wireless/ray_cs.c
>> @@ -2794,8 +2794,8 @@ static int __init init_ray_cs(void)
>> proc_create_data("driver/ray_cs/translate", 0200, NULL,
>> &int_proc_ops,
>> &translate);
>> #endif
>> - if (translate != 0)
>> - translate = 1;
>> + if (!translate)
>
> That inverts the original logic, no?
Oh, yes.
>
>> + translate = true;
>
> Actually, that whole comparison/assignment doesn't make sense, if we
> use bool...
>
So may be we can do this:
diff --git a/drivers/net/wireless/ray_cs.c b/drivers/net/wireless/ray_cs.c
index c1d542bfa530..9ea695459342 100644
--- a/drivers/net/wireless/ray_cs.c
+++ b/drivers/net/wireless/ray_cs.c
@@ -2794,8 +2794,7 @@ static int __init init_ray_cs(void)
proc_create_data("driver/ray_cs/translate", 0200, NULL,
&int_proc_ops,
&translate);
#endif
- if (translate != 0)
- translate = 1;
+ translate == !!translate;
return 0;
} /* init_ray_cs */
> [...]
>
> MBR, Sergei
>
> .
^ permalink raw reply related [flat|nested] 4+ messages in thread
* Re: [PATCH] ray_cs: use true,false for bool variable
2020-04-26 10:27 ` Jason Yan
@ 2020-04-26 10:33 ` Jason Yan
0 siblings, 0 replies; 4+ messages in thread
From: Jason Yan @ 2020-04-26 10:33 UTC (permalink / raw)
To: Sergei Shtylyov, kvalo, davem, adobriyan, tglx, linux-wireless,
netdev, linux-kernel
在 2020/4/26 18:27, Jason Yan 写道:
>
>
> 在 2020/4/26 17:47, Sergei Shtylyov 写道:
>> Hello!
>>
>> On 26.04.2020 12:41, Jason Yan wrote:
>>
>>> Fix the following coccicheck warning:
>>>
>>> drivers/net/wireless/ray_cs.c:2797:5-14: WARNING: Comparison of 0/1 to
>>> bool variable
>>> drivers/net/wireless/ray_cs.c:2798:2-11: WARNING: Assignment of 0/1 to
>>> bool variable
>>>
>>> Signed-off-by: Jason Yan <yanaijie@huawei.com>
>>> ---
>>> drivers/net/wireless/ray_cs.c | 4 ++--
>>> 1 file changed, 2 insertions(+), 2 deletions(-)
>>>
>>> diff --git a/drivers/net/wireless/ray_cs.c
>>> b/drivers/net/wireless/ray_cs.c
>>> index c1d542bfa530..f9402424accd 100644
>>> --- a/drivers/net/wireless/ray_cs.c
>>> +++ b/drivers/net/wireless/ray_cs.c
>>> @@ -2794,8 +2794,8 @@ static int __init init_ray_cs(void)
>>> proc_create_data("driver/ray_cs/translate", 0200, NULL,
>>> &int_proc_ops,
>>> &translate);
>>> #endif
>>> - if (translate != 0)
>>> - translate = 1;
>>> + if (!translate)
>>
>> That inverts the original logic, no?
>
> Oh, yes.
>
>>
>>> + translate = true;
>>
>> Actually, that whole comparison/assignment doesn't make sense, if
>> we use bool...
>>
>
> So may be we can do this:
>
> diff --git a/drivers/net/wireless/ray_cs.c b/drivers/net/wireless/ray_cs.c
> index c1d542bfa530..9ea695459342 100644
> --- a/drivers/net/wireless/ray_cs.c
> +++ b/drivers/net/wireless/ray_cs.c
> @@ -2794,8 +2794,7 @@ static int __init init_ray_cs(void)
> proc_create_data("driver/ray_cs/translate", 0200, NULL,
> &int_proc_ops,
> &translate);
> #endif
> - if (translate != 0)
> - translate = 1;
> + translate == !!translate;
Sorry, this should be:
translate = !!translate;
> return 0;
> } /* init_ray_cs */
>
>> [...]
>>
>> MBR, Sergei
>>
>> .
>
>
> .
^ permalink raw reply [flat|nested] 4+ messages in thread
end of thread, other threads:[~2020-04-26 10:33 UTC | newest]
Thread overview: 4+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2020-04-26 9:41 [PATCH] ray_cs: use true,false for bool variable Jason Yan
2020-04-26 9:47 ` Sergei Shtylyov
2020-04-26 10:27 ` Jason Yan
2020-04-26 10:33 ` Jason Yan
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).