* [PATCH] ata: Guard ata_scsi_dump_cdb() by ATA_VERBOSE_DEBUG
@ 2018-07-12 16:29 Paul Menzel
2018-07-12 20:06 ` Tejun Heo
0 siblings, 1 reply; 2+ messages in thread
From: Paul Menzel @ 2018-07-12 16:29 UTC (permalink / raw)
To: Tejun Heo; +Cc: linux-ide, Linux Kernel Mailing List
[-- Attachment #1: Type: text/plain, Size: 987 bytes --]
Date: Sun, 8 Jul 2018 09:11:34 +0200
Defining `ATA_DEBUG` nothing can be really seen, as the log is spammed
with CDB messages.
Therefore, guard the print by `ATA_VERBOSE_DEBUG`.
Signed-off-by: Paul Menzel <pmenzel@molgen.mpg.de>
---
drivers/ata/libata-scsi.c | 4 ++--
1 file changed, 2 insertions(+), 2 deletions(-)
diff --git a/drivers/ata/libata-scsi.c b/drivers/ata/libata-scsi.c
index aad1b01447de..067aec4527b2 100644
--- a/drivers/ata/libata-scsi.c
+++ b/drivers/ata/libata-scsi.c
@@ -4294,10 +4294,10 @@ static inline ata_xlat_func_t ata_get_xlat_func(struct ata_device *dev, u8 cmd)
static inline void ata_scsi_dump_cdb(struct ata_port *ap,
struct scsi_cmnd *cmd)
{
-#ifdef ATA_DEBUG
+#ifdef ATA_VERBOSE_DEBUG
struct scsi_device *scsidev = cmd->device;
- DPRINTK("CDB (%u:%d,%d,%lld) %9ph\n",
+ VPRINTK("CDB (%u:%d,%d,%lld) %9ph\n",
ap->print_id,
scsidev->channel, scsidev->id, scsidev->lun,
cmd->cmnd);
--
2.17.1
[-- Attachment #2: S/MIME Cryptographic Signature --]
[-- Type: application/pkcs7-signature, Size: 5174 bytes --]
^ permalink raw reply related [flat|nested] 2+ messages in thread
* Re: [PATCH] ata: Guard ata_scsi_dump_cdb() by ATA_VERBOSE_DEBUG
2018-07-12 16:29 [PATCH] ata: Guard ata_scsi_dump_cdb() by ATA_VERBOSE_DEBUG Paul Menzel
@ 2018-07-12 20:06 ` Tejun Heo
0 siblings, 0 replies; 2+ messages in thread
From: Tejun Heo @ 2018-07-12 20:06 UTC (permalink / raw)
To: Paul Menzel; +Cc: linux-ide, Linux Kernel Mailing List
On Thu, Jul 12, 2018 at 06:29:44PM +0200, Paul Menzel wrote:
> Date: Sun, 8 Jul 2018 09:11:34 +0200
>
> Defining `ATA_DEBUG` nothing can be really seen, as the log is spammed
> with CDB messages.
>
> Therefore, guard the print by `ATA_VERBOSE_DEBUG`.
>
> Signed-off-by: Paul Menzel <pmenzel@molgen.mpg.de>
Applied to libata/for-4.19.
Thanks.
--
tejun
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2018-07-12 20:06 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2018-07-12 16:29 [PATCH] ata: Guard ata_scsi_dump_cdb() by ATA_VERBOSE_DEBUG Paul Menzel
2018-07-12 20:06 ` Tejun Heo
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).