From: Marcello Sylvester Bauer <sylv@sylv.io>
To: Guenter Roeck <linux@roeck-us.net>, Jean Delvare <jdelvare@suse.com>
Cc: linux-kernel@vger.kernel.org, linux-hwmon@vger.kernel.org,
Patrick Rudolph <patrick.rudolph@9elements.com>,
Marcello Sylvester Bauer <sylv@sylv.io>
Subject: [PATCH v2 4/4] pmbus (pli1209bc): Add regulator support
Date: Mon, 14 Feb 2022 13:40:35 +0100 [thread overview]
Message-ID: <fc5b0ba1f7d41e88ef066c3ff23aaf882c19c543.1644834803.git.sylv@sylv.io> (raw)
In-Reply-To: <cover.1644834803.git.sylv@sylv.io>
Add regulator support for PLI1209BC Digital Supervisor.
Signed-off-by: Marcello Sylvester Bauer <sylv@sylv.io>
---
drivers/hwmon/pmbus/Kconfig | 7 +++++++
drivers/hwmon/pmbus/pli1209bc.c | 31 +++++++++++++++++++++++++++++++
2 files changed, 38 insertions(+)
diff --git a/drivers/hwmon/pmbus/Kconfig b/drivers/hwmon/pmbus/Kconfig
index 831db423bea0..8b8f0d8733b2 100644
--- a/drivers/hwmon/pmbus/Kconfig
+++ b/drivers/hwmon/pmbus/Kconfig
@@ -319,6 +319,13 @@ config SENSORS_PLI1209BC
This driver can also be built as a module. If so, the module will
be called pli1209bc.
+config SENSORS_PLI1209BC_REGULATOR
+ bool "Regulator support for PLI1209BC"
+ depends on SENSORS_PLI1209BC && REGULATOR
+ help
+ If you say yes here you get regulator support for Vicor PLI1209BC
+ Digital Supervisor.
+
config SENSORS_PM6764TR
tristate "ST PM6764TR"
help
diff --git a/drivers/hwmon/pmbus/pli1209bc.c b/drivers/hwmon/pmbus/pli1209bc.c
index 8a9af2ccc46f..7212d73f6e04 100644
--- a/drivers/hwmon/pmbus/pli1209bc.c
+++ b/drivers/hwmon/pmbus/pli1209bc.c
@@ -8,6 +8,7 @@
#include <linux/i2c.h>
#include <linux/module.h>
#include <linux/pmbus.h>
+#include <linux/regulator/driver.h>
#include "pmbus.h"
/*
@@ -32,11 +33,37 @@ static int pli1209bc_read_word_data(struct i2c_client *client, int page,
if (data < 0)
return data;
return data * 10;
+ /*
+ * PMBUS_READ_VOUT and PMBUS_READ_TEMPERATURE_1 return invalid data
+ * when the BCM is turned off. Since it is not possible to return
+ * ENODATA error, return zero instead.
+ */
+ case PMBUS_READ_VOUT:
+ case PMBUS_READ_TEMPERATURE_1:
+ data = pmbus_read_word_data(client, page, phase,
+ PMBUS_STATUS_WORD);
+ if (data < 0)
+ return data;
+ if (data & PB_STATUS_POWER_GOOD_N)
+ return 0L;
+ return pmbus_read_word_data(client, page, phase, reg);
default:
return -ENODATA;
}
}
+#if IS_ENABLED(CONFIG_SENSORS_PLI1209BC_REGULATOR)
+static const struct regulator_desc pli1209bc_reg_desc = {
+ .name = "vout2",
+ .id = 1,
+ .of_match = of_match_ptr("vout2"),
+ .regulators_node = of_match_ptr("regulators"),
+ .ops = &pmbus_regulator_ops,
+ .type = REGULATOR_VOLTAGE,
+ .owner = THIS_MODULE,
+};
+#endif
+
static struct pmbus_driver_info pli1209bc_info = {
.pages = 2,
.format[PSC_VOLTAGE_IN] = direct,
@@ -74,6 +101,10 @@ static struct pmbus_driver_info pli1209bc_info = {
| PMBUS_HAVE_TEMP | PMBUS_HAVE_STATUS_TEMP
| PMBUS_HAVE_STATUS_IOUT | PMBUS_HAVE_STATUS_INPUT,
.read_word_data = pli1209bc_read_word_data,
+#if IS_ENABLED(CONFIG_SENSORS_PLI1209BC_REGULATOR)
+ .num_regulators = 1,
+ .reg_desc = &pli1209bc_reg_desc,
+#endif
};
static int pli1209bc_probe(struct i2c_client *client)
--
2.34.1
next prev parent reply other threads:[~2022-02-14 12:41 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-02-14 12:40 [PATCH v2 0/4] Support pli1209bc Digital Supervisor Marcello Sylvester Bauer
2022-02-14 12:40 ` [PATCH v2 1/4] dt-bindings: vendor-prefixes: add Vicor Corporation Marcello Sylvester Bauer
2022-02-14 12:40 ` [PATCH v2 2/4] dt-bindings:trivial-devices: Add pli1209bc Marcello Sylvester Bauer
2022-02-14 12:40 ` [PATCH v2 3/4] pmbus: Add support for pli1209bc Marcello Sylvester Bauer
2022-02-14 17:36 ` Guenter Roeck
2022-02-14 18:34 ` sylv
2022-02-14 12:40 ` Marcello Sylvester Bauer [this message]
2022-02-14 17:40 ` [PATCH v2 4/4] pmbus (pli1209bc): Add regulator support Guenter Roeck
2022-02-14 18:19 ` sylv
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=fc5b0ba1f7d41e88ef066c3ff23aaf882c19c543.1644834803.git.sylv@sylv.io \
--to=sylv@sylv.io \
--cc=jdelvare@suse.com \
--cc=linux-hwmon@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux@roeck-us.net \
--cc=patrick.rudolph@9elements.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).