* Re: [PATCH] riscv: Implement free_initrd_mem.
[not found] <20180220135043.15411-1-shea@shealevy.com>
@ 2018-02-23 0:41 ` Palmer Dabbelt
2018-03-08 19:14 ` Shea Levy
0 siblings, 1 reply; 5+ messages in thread
From: Palmer Dabbelt @ 2018-02-23 0:41 UTC (permalink / raw)
To: shea, linux-kernel; +Cc: linux-riscv, shea
On Tue, 20 Feb 2018 05:50:43 PST (-0800), shea@shealevy.com wrote:
> Signed-off-by: Shea Levy <shea@shealevy.com>
> ---
> arch/riscv/mm/init.c | 6 ++++++
> 1 file changed, 6 insertions(+)
>
> diff --git a/arch/riscv/mm/init.c b/arch/riscv/mm/init.c
> index c77df8142be2..1c832b541e95 100644
> --- a/arch/riscv/mm/init.c
> +++ b/arch/riscv/mm/init.c
> @@ -66,5 +66,11 @@ void free_initmem(void)
> #ifdef CONFIG_BLK_DEV_INITRD
> void free_initrd_mem(unsigned long start, unsigned long end)
> {
> + if (start == initrd_start)
> + start = round_down(start, PAGE_SIZE);
> + if (end == initrd_end)
> + end = round_up(end, PAGE_SIZE);
> +
> + free_reserved_area((void *)start, (void *)end, -1, "initrd");
> }
> #endif /* CONFIG_BLK_DEV_INITRD */
It looks like everyone is doing something slightly different here:
* arm64 doesn't round to a page size, and has keep_initrd.
* arm calls poison_init_mem(), and has keep_initrd.
* sparc64 doesn't round, and doesn't have a keep_initrd.
* mips doesn't round, and doesn't have a keep_initrd.
* x86 rounds end to a page size but not start, and doesn't have a keep_initrd.
It feels like this should be something generic. I'm adding linux-kernel to see
what people think.
^ permalink raw reply [flat|nested] 5+ messages in thread
* Re: [PATCH] riscv: Implement free_initrd_mem.
2018-02-23 0:41 ` [PATCH] riscv: Implement free_initrd_mem Palmer Dabbelt
@ 2018-03-08 19:14 ` Shea Levy
2018-03-08 19:35 ` Palmer Dabbelt
0 siblings, 1 reply; 5+ messages in thread
From: Shea Levy @ 2018-03-08 19:14 UTC (permalink / raw)
To: Palmer Dabbelt, linux-kernel; +Cc: linux-riscv
[-- Attachment #1: Type: text/plain, Size: 1417 bytes --]
Hi Palmer,
Palmer Dabbelt <palmer@sifive.com> writes:
> On Tue, 20 Feb 2018 05:50:43 PST (-0800), shea@shealevy.com wrote:
>> Signed-off-by: Shea Levy <shea@shealevy.com>
>> ---
>> arch/riscv/mm/init.c | 6 ++++++
>> 1 file changed, 6 insertions(+)
>>
>> diff --git a/arch/riscv/mm/init.c b/arch/riscv/mm/init.c
>> index c77df8142be2..1c832b541e95 100644
>> --- a/arch/riscv/mm/init.c
>> +++ b/arch/riscv/mm/init.c
>> @@ -66,5 +66,11 @@ void free_initmem(void)
>> #ifdef CONFIG_BLK_DEV_INITRD
>> void free_initrd_mem(unsigned long start, unsigned long end)
>> {
>> + if (start == initrd_start)
>> + start = round_down(start, PAGE_SIZE);
>> + if (end == initrd_end)
>> + end = round_up(end, PAGE_SIZE);
>> +
>> + free_reserved_area((void *)start, (void *)end, -1, "initrd");
>> }
>> #endif /* CONFIG_BLK_DEV_INITRD */
>
> It looks like everyone is doing something slightly different here:
>
> * arm64 doesn't round to a page size, and has keep_initrd.
> * arm calls poison_init_mem(), and has keep_initrd.
> * sparc64 doesn't round, and doesn't have a keep_initrd.
> * mips doesn't round, and doesn't have a keep_initrd.
> * x86 rounds end to a page size but not start, and doesn't have a keep_initrd.
>
> It feels like this should be something generic. I'm adding linux-kernel to see
> what people think.
Should I try to whip up something generic?
Thanks,
Shea
[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 832 bytes --]
^ permalink raw reply [flat|nested] 5+ messages in thread
* Re: [PATCH] riscv: Implement free_initrd_mem.
2018-03-08 19:14 ` Shea Levy
@ 2018-03-08 19:35 ` Palmer Dabbelt
2018-03-08 19:47 ` Shea Levy
0 siblings, 1 reply; 5+ messages in thread
From: Palmer Dabbelt @ 2018-03-08 19:35 UTC (permalink / raw)
To: shea; +Cc: linux-kernel, linux-riscv
On Thu, 08 Mar 2018 11:14:52 PST (-0800), shea@shealevy.com wrote:
> Hi Palmer,
>
> Palmer Dabbelt <palmer@sifive.com> writes:
>
>> On Tue, 20 Feb 2018 05:50:43 PST (-0800), shea@shealevy.com wrote:
>>> Signed-off-by: Shea Levy <shea@shealevy.com>
>>> ---
>>> arch/riscv/mm/init.c | 6 ++++++
>>> 1 file changed, 6 insertions(+)
>>>
>>> diff --git a/arch/riscv/mm/init.c b/arch/riscv/mm/init.c
>>> index c77df8142be2..1c832b541e95 100644
>>> --- a/arch/riscv/mm/init.c
>>> +++ b/arch/riscv/mm/init.c
>>> @@ -66,5 +66,11 @@ void free_initmem(void)
>>> #ifdef CONFIG_BLK_DEV_INITRD
>>> void free_initrd_mem(unsigned long start, unsigned long end)
>>> {
>>> + if (start == initrd_start)
>>> + start = round_down(start, PAGE_SIZE);
>>> + if (end == initrd_end)
>>> + end = round_up(end, PAGE_SIZE);
>>> +
>>> + free_reserved_area((void *)start, (void *)end, -1, "initrd");
>>> }
>>> #endif /* CONFIG_BLK_DEV_INITRD */
>>
>> It looks like everyone is doing something slightly different here:
>>
>> * arm64 doesn't round to a page size, and has keep_initrd.
>> * arm calls poison_init_mem(), and has keep_initrd.
>> * sparc64 doesn't round, and doesn't have a keep_initrd.
>> * mips doesn't round, and doesn't have a keep_initrd.
>> * x86 rounds end to a page size but not start, and doesn't have a keep_initrd.
>>
>> It feels like this should be something generic. I'm adding linux-kernel to see
>> what people think.
>
> Should I try to whip up something generic?
I think that'd be best. Nobody has said anything specific, but it's generally
been suggested to take bits that we copy into our port and make them generic.
If there's no clean way do to so then I'm OK taking this, though.
^ permalink raw reply [flat|nested] 5+ messages in thread
* Re: [PATCH] riscv: Implement free_initrd_mem.
2018-03-08 19:35 ` Palmer Dabbelt
@ 2018-03-08 19:47 ` Shea Levy
2018-03-08 20:31 ` Palmer Dabbelt
0 siblings, 1 reply; 5+ messages in thread
From: Shea Levy @ 2018-03-08 19:47 UTC (permalink / raw)
To: Palmer Dabbelt; +Cc: linux-kernel, linux-riscv
[-- Attachment #1: Type: text/plain, Size: 1867 bytes --]
Palmer Dabbelt <palmer@sifive.com> writes:
> On Thu, 08 Mar 2018 11:14:52 PST (-0800), shea@shealevy.com wrote:
>> Hi Palmer,
>>
>> Palmer Dabbelt <palmer@sifive.com> writes:
>>
>>> On Tue, 20 Feb 2018 05:50:43 PST (-0800), shea@shealevy.com wrote:
>>>> Signed-off-by: Shea Levy <shea@shealevy.com>
>>>> ---
>>>> arch/riscv/mm/init.c | 6 ++++++
>>>> 1 file changed, 6 insertions(+)
>>>>
>>>> diff --git a/arch/riscv/mm/init.c b/arch/riscv/mm/init.c
>>>> index c77df8142be2..1c832b541e95 100644
>>>> --- a/arch/riscv/mm/init.c
>>>> +++ b/arch/riscv/mm/init.c
>>>> @@ -66,5 +66,11 @@ void free_initmem(void)
>>>> #ifdef CONFIG_BLK_DEV_INITRD
>>>> void free_initrd_mem(unsigned long start, unsigned long end)
>>>> {
>>>> + if (start == initrd_start)
>>>> + start = round_down(start, PAGE_SIZE);
>>>> + if (end == initrd_end)
>>>> + end = round_up(end, PAGE_SIZE);
>>>> +
>>>> + free_reserved_area((void *)start, (void *)end, -1, "initrd");
>>>> }
>>>> #endif /* CONFIG_BLK_DEV_INITRD */
>>>
>>> It looks like everyone is doing something slightly different here:
>>>
>>> * arm64 doesn't round to a page size, and has keep_initrd.
>>> * arm calls poison_init_mem(), and has keep_initrd.
>>> * sparc64 doesn't round, and doesn't have a keep_initrd.
>>> * mips doesn't round, and doesn't have a keep_initrd.
>>> * x86 rounds end to a page size but not start, and doesn't have a keep_initrd.
>>>
>>> It feels like this should be something generic. I'm adding linux-kernel to see
>>> what people think.
>>
>> Should I try to whip up something generic?
>
> I think that'd be best. Nobody has said anything specific, but it's generally
> been suggested to take bits that we copy into our port and make them generic.
> If there's no clean way do to so then I'm OK taking this, though.
OK, will add it to my queue.
[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 832 bytes --]
^ permalink raw reply [flat|nested] 5+ messages in thread
* Re: [PATCH] riscv: Implement free_initrd_mem.
2018-03-08 19:47 ` Shea Levy
@ 2018-03-08 20:31 ` Palmer Dabbelt
0 siblings, 0 replies; 5+ messages in thread
From: Palmer Dabbelt @ 2018-03-08 20:31 UTC (permalink / raw)
To: shea; +Cc: linux-kernel, linux-riscv
On Thu, 08 Mar 2018 11:47:08 PST (-0800), shea@shealevy.com wrote:
> Palmer Dabbelt <palmer@sifive.com> writes:
>
>> On Thu, 08 Mar 2018 11:14:52 PST (-0800), shea@shealevy.com wrote:
>>> Hi Palmer,
>>>
>>> Palmer Dabbelt <palmer@sifive.com> writes:
>>>
>>>> On Tue, 20 Feb 2018 05:50:43 PST (-0800), shea@shealevy.com wrote:
>>>>> Signed-off-by: Shea Levy <shea@shealevy.com>
>>>>> ---
>>>>> arch/riscv/mm/init.c | 6 ++++++
>>>>> 1 file changed, 6 insertions(+)
>>>>>
>>>>> diff --git a/arch/riscv/mm/init.c b/arch/riscv/mm/init.c
>>>>> index c77df8142be2..1c832b541e95 100644
>>>>> --- a/arch/riscv/mm/init.c
>>>>> +++ b/arch/riscv/mm/init.c
>>>>> @@ -66,5 +66,11 @@ void free_initmem(void)
>>>>> #ifdef CONFIG_BLK_DEV_INITRD
>>>>> void free_initrd_mem(unsigned long start, unsigned long end)
>>>>> {
>>>>> + if (start == initrd_start)
>>>>> + start = round_down(start, PAGE_SIZE);
>>>>> + if (end == initrd_end)
>>>>> + end = round_up(end, PAGE_SIZE);
>>>>> +
>>>>> + free_reserved_area((void *)start, (void *)end, -1, "initrd");
>>>>> }
>>>>> #endif /* CONFIG_BLK_DEV_INITRD */
>>>>
>>>> It looks like everyone is doing something slightly different here:
>>>>
>>>> * arm64 doesn't round to a page size, and has keep_initrd.
>>>> * arm calls poison_init_mem(), and has keep_initrd.
>>>> * sparc64 doesn't round, and doesn't have a keep_initrd.
>>>> * mips doesn't round, and doesn't have a keep_initrd.
>>>> * x86 rounds end to a page size but not start, and doesn't have a keep_initrd.
>>>>
>>>> It feels like this should be something generic. I'm adding linux-kernel to see
>>>> what people think.
>>>
>>> Should I try to whip up something generic?
>>
>> I think that'd be best. Nobody has said anything specific, but it's generally
>> been suggested to take bits that we copy into our port and make them generic.
>> If there's no clean way do to so then I'm OK taking this, though.
>
> OK, will add it to my queue.
Thanks!
^ permalink raw reply [flat|nested] 5+ messages in thread
end of thread, other threads:[~2018-03-08 20:31 UTC | newest]
Thread overview: 5+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
[not found] <20180220135043.15411-1-shea@shealevy.com>
2018-02-23 0:41 ` [PATCH] riscv: Implement free_initrd_mem Palmer Dabbelt
2018-03-08 19:14 ` Shea Levy
2018-03-08 19:35 ` Palmer Dabbelt
2018-03-08 19:47 ` Shea Levy
2018-03-08 20:31 ` Palmer Dabbelt
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).