linux-next: build warning after merge of the sound tree

linux-next: build warning after merge of the sound tree

[Stephen Rothwell]

[-- Attachment #1: Type: text/plain, Size: 460 bytes --]

Hi Takashi,

After merging the sound tree, today's linux-next build (arm
multi_v7_defconfig) produced this warning:

sound/pci/hda/hda_codec.c: In function 'hda_codec_runtime_suspend':
sound/pci/hda/hda_codec.c:2926:18: warning: unused variable 'pcm' [-Wunused-variable]
  struct hda_pcm *pcm;
                  ^~~

Introduced by commit

  17bc4815de58 ("ALSA: pci: Remove superfluous snd_pcm_suspend*() calls")

-- 
Cheers,
Stephen Rothwell

[-- Attachment #2: OpenPGP digital signature --]
[-- Type: application/pgp-signature, Size: 488 bytes --]

Re: linux-next: build warning after merge of the sound tree

[Takashi Iwai]

On Mon, 21 Jan 2019 01:21:48 +0100,
Stephen Rothwell wrote:
On Mon, 21 Jan 2019 01:21:48 +0100,
Stephen Rothwell wrote:
> 
> Hi Takashi,
> 
> After merging the sound tree, today's linux-next build (arm
> multi_v7_defconfig) produced this warning:
> 
> sound/pci/hda/hda_codec.c: In function 'hda_codec_runtime_suspend':
> sound/pci/hda/hda_codec.c:2926:18: warning: unused variable 'pcm' [-Wunused-variable]
>   struct hda_pcm *pcm;
>                   ^~~
> 
> Introduced by commit
> 
>   17bc4815de58 ("ALSA: pci: Remove superfluous snd_pcm_suspend*() calls")

Thanks, fixed now with the patch below.


Takashi

-- 8< --
From: Takashi Iwai <tiwai@suse.de>
Subject: [PATCH] ALSA: hda - Fix unused variable warning

The unused variable was forgotten to be removed and now we get a
compiler warning:
  sound/pci/hda/hda_codec.c: In function 'hda_codec_runtime_suspend':
  sound/pci/hda/hda_codec.c:2926:18: warning: unused variable 'pcm'

Fixes: 17bc4815de58 ("ALSA: pci: Remove superfluous snd_pcm_suspend*() calls")
Reported-by: Stephen Rothwell <sfr@canb.auug.org.au>
Signed-off-by: Takashi Iwai <tiwai@suse.de>
---
 sound/pci/hda/hda_codec.c | 1 -
 1 file changed, 1 deletion(-)

diff --git a/sound/pci/hda/hda_codec.c b/sound/pci/hda/hda_codec.c
index ff6dbed4d3cd..e4704f5729d3 100644
--- a/sound/pci/hda/hda_codec.c
+++ b/sound/pci/hda/hda_codec.c
@@ -2923,7 +2923,6 @@ static void hda_call_codec_resume(struct hda_codec *codec)
 static int hda_codec_runtime_suspend(struct device *dev)
 {
 	struct hda_codec *codec = dev_to_hda_codec(dev);
-	struct hda_pcm *pcm;
 	unsigned int state;
 
 	cancel_delayed_work_sync(&codec->jackpoll_work);
-- 
2.16.4

Re: [PATCH] ALSA: hda - Fix unused variable warning

[kbuild test robot]

[-- Attachment #1: Type: text/plain, Size: 3623 bytes --]

Hi Takashi,

I love your patch! Yet something to improve:

[auto build test ERROR on sound/for-next]
[also build test ERROR on v5.0-rc2]
[if your patch is applied to the wrong git tree, please drop us a note to help improve the system]

url:    https://github.com/0day-ci/linux/commits/Takashi-Iwai/ALSA-hda-Fix-unused-variable-warning/20190122-135307
base:   https://git.kernel.org/pub/scm/linux/kernel/git/tiwai/sound.git for-next
config: sh-allyesconfig (attached as .config)
compiler: sh4-linux-gnu-gcc (Debian 8.2.0-11) 8.2.0
reproduce:
        wget https://raw.githubusercontent.com/intel/lkp-tests/master/sbin/make.cross -O ~/bin/make.cross
        chmod +x ~/bin/make.cross
        # save the attached .config to linux build tree
        GCC_VERSION=8.2.0 make.cross ARCH=sh 

All errors (new ones prefixed by >>):

   In file included from include/linux/preempt.h:11,
                    from include/linux/spinlock.h:51,
                    from include/linux/mmzone.h:8,
                    from include/linux/gfp.h:6,
                    from include/linux/slab.h:15,
                    from sound/pci//hda/hda_codec.c:24:
   sound/pci//hda/hda_codec.c: In function 'hda_codec_runtime_suspend':
>> sound/pci//hda/hda_codec.c:2929:22: error: 'pcm' undeclared (first use in this function)
     list_for_each_entry(pcm, &codec->pcm_list_head, list)
                         ^~~
   include/linux/list.h:517:7: note: in definition of macro 'list_for_each_entry'
     for (pos = list_first_entry(head, typeof(*pos), member); \
          ^~~
   sound/pci//hda/hda_codec.c:2929:22: note: each undeclared identifier is reported only once for each function it appears in
     list_for_each_entry(pcm, &codec->pcm_list_head, list)
                         ^~~
   include/linux/list.h:517:7: note: in definition of macro 'list_for_each_entry'
     for (pos = list_first_entry(head, typeof(*pos), member); \
          ^~~

vim +/pcm +2929 sound/pci//hda/hda_codec.c

59ed1ead Takashi Iwai 2015-02-18  2922  
cc72da7d Takashi Iwai 2015-02-19  2923  static int hda_codec_runtime_suspend(struct device *dev)
59ed1ead Takashi Iwai 2015-02-18  2924  {
59ed1ead Takashi Iwai 2015-02-18  2925  	struct hda_codec *codec = dev_to_hda_codec(dev);
cc72da7d Takashi Iwai 2015-02-19  2926  	unsigned int state;
59ed1ead Takashi Iwai 2015-02-18  2927  
59ed1ead Takashi Iwai 2015-02-18  2928  	cancel_delayed_work_sync(&codec->jackpoll_work);
bbbc7e85 Takashi Iwai 2015-02-27 @2929  	list_for_each_entry(pcm, &codec->pcm_list_head, list)
bbbc7e85 Takashi Iwai 2015-02-27  2930  		snd_pcm_suspend_all(pcm->pcm);
cc72da7d Takashi Iwai 2015-02-19  2931  	state = hda_call_codec_suspend(codec);
57cb54e5 Takashi Iwai 2018-06-21  2932  	if (codec->link_down_at_suspend ||
57cb54e5 Takashi Iwai 2018-06-21  2933  	    (codec_has_clkstop(codec) && codec_has_epss(codec) &&
57cb54e5 Takashi Iwai 2018-06-21  2934  	     (state & AC_PWRST_CLK_STOP_OK)))
7639a06c Takashi Iwai 2015-03-03  2935  		snd_hdac_codec_link_down(&codec->core);
029d92c2 Takashi Iwai 2018-12-08  2936  	codec_display_power(codec, false);
59ed1ead Takashi Iwai 2015-02-18  2937  	return 0;
59ed1ead Takashi Iwai 2015-02-18  2938  }
59ed1ead Takashi Iwai 2015-02-18  2939  

:::::: The code at line 2929 was first introduced by commit
:::::: bbbc7e8502c95237dbd86cc4d0a12ca9a6b18c8f ALSA: hda - Allocate hda_pcm objects dynamically

:::::: TO: Takashi Iwai <tiwai@suse.de>
:::::: CC: Takashi Iwai <tiwai@suse.de>

---
0-DAY kernel test infrastructure                Open Source Technology Center
https://lists.01.org/pipermail/kbuild-all                   Intel Corporation

[-- Attachment #2: .config.gz --]
[-- Type: application/gzip, Size: 51024 bytes --]

Re: linux-next: build warning after merge of the sound tree

[Takashi Iwai]

On Fri, 25 Aug 2023 07:29:57 +0200,
Stephen Rothwell wrote:
> 
> Hi all,
> 
> After merging the sound tree, today's linux-next build (htmldocs)
> produced this warning:
> 
> Documentation/sound/designs/midi-2.0.rst:517: WARNING: Inline interpreted text or phrase reference start-string without end-string.
> 
> Introduced by commit
> 
>   e240cff9e6e9 ("ALSA: documentation: Add description for USB MIDI 2.0 gadget driver")

It was a missing backquote.  Now fixed.

Thanks!


Takashi

linux-next: build warning after merge of the sound tree

[Stephen Rothwell]

[-- Attachment #1: Type: text/plain, Size: 385 bytes --]

Hi all,

After merging the sound tree, today's linux-next build (htmldocs)
produced this warning:

Documentation/sound/designs/midi-2.0.rst:517: WARNING: Inline interpreted text or phrase reference start-string without end-string.

Introduced by commit

  e240cff9e6e9 ("ALSA: documentation: Add description for USB MIDI 2.0 gadget driver")

-- 
Cheers,
Stephen Rothwell

[-- Attachment #2: OpenPGP digital signature --]
[-- Type: application/pgp-signature, Size: 488 bytes --]

Re: linux-next: build warning after merge of the sound tree

[Stephen Rothwell]

[-- Attachment #1: Type: text/plain, Size: 651 bytes --]

Hi all,

On Thu, 9 Feb 2023 10:48:23 +1100 Stephen Rothwell <sfr@canb.auug.org.au> wrote:
>
> After merging the sound tree, today's linux-next build (powerpc
> ppc64_defconfig) produced this warning:
> 
> sound/ppc/snd_ps3.c: In function 'snd_ps3_driver_remove':
> sound/ppc/snd_ps3.c:1049:13: warning: unused variable 'ret' [-Wunused-variable]
>  1049 |         int ret;
>       |             ^~~
> 
> Introduced by commit
> 
>   25a5a77ae0bc ("ALSA: core: Make snd_card_free() return void")

This became a build failure in my powerpc allyesconfig build, so I
applied the supplied patch for today.

-- 
Cheers,
Stephen Rothwell

[-- Attachment #2: OpenPGP digital signature --]
[-- Type: application/pgp-signature, Size: 488 bytes --]

linux-next: build warning after merge of the sound tree

[Stephen Rothwell]

[-- Attachment #1: Type: text/plain, Size: 435 bytes --]

Hi all,

After merging the sound tree, today's linux-next build (powerpc
ppc64_defconfig) produced this warning:

sound/ppc/snd_ps3.c: In function 'snd_ps3_driver_remove':
sound/ppc/snd_ps3.c:1049:13: warning: unused variable 'ret' [-Wunused-variable]
 1049 |         int ret;
      |             ^~~

Introduced by commit

  25a5a77ae0bc ("ALSA: core: Make snd_card_free() return void")

-- 
Cheers,
Stephen Rothwell

[-- Attachment #2: OpenPGP digital signature --]
[-- Type: application/pgp-signature, Size: 488 bytes --]

Re: linux-next: build warning after merge of the sound tree

[Takashi Iwai]

On Mon, 23 Aug 2021 12:00:02 +0200,
Stephen Rothwell wrote:
> 
> Hi all,
> 
> After merging the sound tree, today's linux-next build (htmldocs)
> produced this warning:
> 
> Documentation/sound/alsa-configuration.rst:2258: WARNING: Unexpected indentation.
> 
> Introduced by commit
> 
>   a39978ed6df1 ("ALSA: doc: Add the description of quirk_flags option for snd-usb-audio")

Thanks for the report, now the fix was queued:
  https://lore.kernel.org/r/20210823113518.30134-1-tiwai@suse.de


Takashi

linux-next: build warning after merge of the sound tree

[Stephen Rothwell]

[-- Attachment #1: Type: text/plain, Size: 338 bytes --]

Hi all,

After merging the sound tree, today's linux-next build (htmldocs)
produced this warning:

Documentation/sound/alsa-configuration.rst:2258: WARNING: Unexpected indentation.

Introduced by commit

  a39978ed6df1 ("ALSA: doc: Add the description of quirk_flags option for snd-usb-audio")

-- 
Cheers,
Stephen Rothwell

[-- Attachment #2: OpenPGP digital signature --]
[-- Type: application/pgp-signature, Size: 488 bytes --]

Re: linux-next: build warning after merge of the sound tree

[Takashi Iwai]

On Fri, 01 May 2020 06:03:23 +0200,
Stephen Rothwell wrote:
> 
> Hi all,
> 
> After merging the sound tree, today's linux-next build (arm
> multi_v7_defconfig) produced this warning:
> 
> sound/pci/hda/patch_realtek.c: In function 'alc_fixup_hp_gpio_led':
> sound/pci/hda/patch_realtek.c:4134:6: warning: unused variable 'err' [-Wunused-variable]
>  4134 |  int err;
>       |      ^~~
> 
> Introduced by commit
> 
>   87dc36482cab ("ALSA: hda/realtek - Add LED class support for micmute LED")

I submitted the fix patch now and it will be included later:
  https://lore.kernel.org/r/20200501072857.13720-1-tiwai@suse.de


thanks,

Takashi

linux-next: build warning after merge of the sound tree

[Stephen Rothwell]

[-- Attachment #1: Type: text/plain, Size: 452 bytes --]

Hi all,

After merging the sound tree, today's linux-next build (arm
multi_v7_defconfig) produced this warning:

sound/pci/hda/patch_realtek.c: In function 'alc_fixup_hp_gpio_led':
sound/pci/hda/patch_realtek.c:4134:6: warning: unused variable 'err' [-Wunused-variable]
 4134 |  int err;
      |      ^~~

Introduced by commit

  87dc36482cab ("ALSA: hda/realtek - Add LED class support for micmute LED")

-- 
Cheers,
Stephen Rothwell

[-- Attachment #2: OpenPGP digital signature --]
[-- Type: application/pgp-signature, Size: 488 bytes --]

linux-next: build warning after merge of the sound tree

[Stephen Rothwell]

[-- Attachment #1: Type: text/plain, Size: 465 bytes --]

Hi all,

After merging the sound tree, today's linux-next build (arm
multi_v7_defconfig) produced this warning:

sound/pci/hda/hda_tegra.c: In function 'hda_tegra_runtime_suspend':
sound/pci/hda/hda_tegra.c:169:19: warning: unused variable 'bus' [-Wunused-variable]
  169 |  struct hdac_bus *bus = azx_bus(chip);
      |                   ^~~

Introduced by commit

  f36da9406e66 ("ALSA: hda: Support PCM sync_stop")

-- 
Cheers,
Stephen Rothwell

[-- Attachment #2: OpenPGP digital signature --]
[-- Type: application/pgp-signature, Size: 488 bytes --]

Re: linux-next: build warning after merge of the sound tree

[Takashi Iwai]

At Tue, 30 Mar 2010 14:48:09 +1100,
Stephen Rothwell wrote:
> 
> Hi Takashi,
> 
> After merging the sound tree, today's linux-next build (x86_64
> allmodconfig) produced this warning:
> 
> sound/pci/hda/patch_realtek.c: In function 'fillup_priv_adc_nids':
> sound/pci/hda/patch_realtek.c:5120: warning: format '%s' expects type 'char *', but argument 2 has type 'int'
> sound/pci/hda/patch_realtek.c:5120: warning: too few arguments for format
> 
> Introduced by commit 6694635d3ae1b038d7a0e38b80637db867c7c8e2 ("ALSA: hda
> - Fix ADC/MUX assignment of ALC269 codec").

Fixed now.  Thanks!


Takashi

linux-next: build warning after merge of the sound tree

[Stephen Rothwell]

[-- Attachment #1: Type: text/plain, Size: 604 bytes --]

Hi Takashi,

After merging the sound tree, today's linux-next build (x86_64
allmodconfig) produced this warning:

sound/pci/hda/patch_realtek.c: In function 'fillup_priv_adc_nids':
sound/pci/hda/patch_realtek.c:5120: warning: format '%s' expects type 'char *', but argument 2 has type 'int'
sound/pci/hda/patch_realtek.c:5120: warning: too few arguments for format

Introduced by commit 6694635d3ae1b038d7a0e38b80637db867c7c8e2 ("ALSA: hda
- Fix ADC/MUX assignment of ALC269 codec").

-- 
Cheers,
Stephen Rothwell                    sfr@canb.auug.org.au
http://www.canb.auug.org.au/~sfr/

[-- Attachment #2: Type: application/pgp-signature, Size: 198 bytes --]

Re: linux-next: build warning after merge of the sound tree

[Takashi Iwai]

At Tue, 23 Feb 2010 16:20:00 +1100,
Luke Yelavich wrote:
> 
> On Tue, Feb 23, 2010 at 04:07:46PM EST, Stephen Rothwell wrote:
> > Hi Takashi,
> > 
> > After merging the sound tree, today's linux-next build (x86_64
> > allmodconfig) produced these warnings:
> > 
> > sound/pci/hda/patch_realtek.c:7016: warning: 'alc885_macmini3_ch2_init' defined but not used
> > sound/pci/hda/patch_realtek.c:7028: warning: 'alc885_macmini3_ch6_init' defined but not used
> > 
> > Introduced by commit e458b1fadf9239d1fdb165ff4c4ea0d807041bec ("ALSA: hda
> > - Add Macmini 3,1 support").
> 
> Whoops, thats my fault. I'll send a patch to the ALSA dev list to fix that right away.

I already fixed differently (just cleaned up, it's identical with mb5
definition).  At the next time, please add me to Cc so that I can pick
up more quickly.


thanks,

Takashi

Re: linux-next: build warning after merge of the sound tree

[Luke Yelavich]

On Tue, Feb 23, 2010 at 04:07:46PM EST, Stephen Rothwell wrote:
> Hi Takashi,
> 
> After merging the sound tree, today's linux-next build (x86_64
> allmodconfig) produced these warnings:
> 
> sound/pci/hda/patch_realtek.c:7016: warning: 'alc885_macmini3_ch2_init' defined but not used
> sound/pci/hda/patch_realtek.c:7028: warning: 'alc885_macmini3_ch6_init' defined but not used
> 
> Introduced by commit e458b1fadf9239d1fdb165ff4c4ea0d807041bec ("ALSA: hda
> - Add Macmini 3,1 support").

Whoops, thats my fault. I'll send a patch to the ALSA dev list to fix that right away.

Luke

linux-next: build warning after merge of the sound tree

[Stephen Rothwell]

[-- Attachment #1: Type: text/plain, Size: 523 bytes --]

Hi Takashi,

After merging the sound tree, today's linux-next build (x86_64
allmodconfig) produced these warnings:

sound/pci/hda/patch_realtek.c:7016: warning: 'alc885_macmini3_ch2_init' defined but not used
sound/pci/hda/patch_realtek.c:7028: warning: 'alc885_macmini3_ch6_init' defined but not used

Introduced by commit e458b1fadf9239d1fdb165ff4c4ea0d807041bec ("ALSA: hda
- Add Macmini 3,1 support").
-- 
Cheers,
Stephen Rothwell                    sfr@canb.auug.org.au
http://www.canb.auug.org.au/~sfr/

[-- Attachment #2: Type: application/pgp-signature, Size: 198 bytes --]