linux-kernel.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: Takashi Iwai <tiwai@suse.de>
To: Bradley Scott <Bradley.Scott@zebra.com>
Cc: Jaroslav Kysela <perex@perex.cz>, Takashi Iwai <tiwai@suse.com>,
	Jonathan Corbet <corbet@lwn.net>,
	Jeremy Szu <jeremy.szu@canonical.com>,
	Hui Wang <hui.wang@canonical.com>,
	Werner Sembach <wse@tuxedocomputers.com>,
	Kailang Yang <kailang@realtek.com>,
	Cameron Berkenpas <cam@neo-zeon.de>, Sami Loone <sami@loone.fi>,
	Elia Devito <eliadevito@gmail.com>,
	alsa-devel@alsa-project.org, linux-doc@vger.kernel.org,
	linux-kernel@vger.kernel.org
Subject: Re: [PATCH] ALSA: hda/realtek: Amp init fixup for HP ZBook 15 G6
Date: Sun, 12 Dec 2021 09:58:31 +0100	[thread overview]
Message-ID: <s5ha6h6fbd4.wl-tiwai@suse.de> (raw)
In-Reply-To: <20211210192614.460529-1-Bradley.Scott@zebra.com>

On Fri, 10 Dec 2021 20:26:12 +0100,
Bradley Scott wrote:
> 
> HP ZBook 15 G6 (SSID 103c:860f) needs the same speaker amplifier
> initialization as used on several other HP laptops using ALC285.
> 
> This commit also adds a new "alc285-hp-amp-init" model that can be used
> to apply this same amp init fixup to other devices by passing
> "hda_model=alc285-hp-amp-init" to the snd-sof-intel-hda-common module or
> "model=alc285-hp-amp-init" to the snd-hda-intel module, depending on
> which is being used.
> 
> Signed-off-by: Bradley Scott <Bradley.Scott@zebra.com>

Thanks for the patch.  Unfortunately, somehow your MUA broke the tabs
with spaces and the patch wasn't cleanly applicable.

Also, I prefer splitting the changes to two, the addition of a quirk
entry and the addition to the model string.  Then old stable kernels
have more chance to pick up.

Could you try to resubmit?  In the worst case, I can take the
attachments, too.


Takashi

      reply	other threads:[~2021-12-12  8:58 UTC|newest]

Thread overview: 2+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2021-12-10 19:26 [PATCH] ALSA: hda/realtek: Amp init fixup for HP ZBook 15 G6 Bradley Scott
2021-12-12  8:58 ` Takashi Iwai [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=s5ha6h6fbd4.wl-tiwai@suse.de \
    --to=tiwai@suse.de \
    --cc=Bradley.Scott@zebra.com \
    --cc=alsa-devel@alsa-project.org \
    --cc=cam@neo-zeon.de \
    --cc=corbet@lwn.net \
    --cc=eliadevito@gmail.com \
    --cc=hui.wang@canonical.com \
    --cc=jeremy.szu@canonical.com \
    --cc=kailang@realtek.com \
    --cc=linux-doc@vger.kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=perex@perex.cz \
    --cc=sami@loone.fi \
    --cc=tiwai@suse.com \
    --cc=wse@tuxedocomputers.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).