* [PATCH] ALSA: usb-audio: Change structure initialisation to C99 style
@ 2016-06-15 13:26 Amitoj Kaur Chawla
2016-06-15 13:29 ` Takashi Iwai
0 siblings, 1 reply; 4+ messages in thread
From: Amitoj Kaur Chawla @ 2016-06-15 13:26 UTC (permalink / raw)
To: perex, tiwai, alsa-devel, linux-kernel
Cc: julia.lawall, michael.leibowitz, keescook
Replace the in order struct initialisation style with explicit field
style.
The Coccinelle semantic patch used to make this change is as follows:
@decl@
identifier i1,fld;
type T;
field list[n] fs;
@@
struct i1 {
fs
T fld;
...};
@@
identifier decl.i1,i2,decl.fld;
expression e;
position bad.p, bad.fix;
@@
struct i1 i2@p = { ...,
+ .fld = e
- e@fix
,...};
Signed-off-by: Amitoj Kaur Chawla <amitoj1606@gmail.com>
---
sound/usb/mixer_maps.c | 6 ++++--
1 file changed, 4 insertions(+), 2 deletions(-)
diff --git a/sound/usb/mixer_maps.c b/sound/usb/mixer_maps.c
index 1f8fb0d9..9038b2e 100644
--- a/sound/usb/mixer_maps.c
+++ b/sound/usb/mixer_maps.c
@@ -107,8 +107,10 @@ static struct usbmix_name_map extigy_map[] = {
* e.g. no Master and fake PCM volume
* Pavel Mihaylov <bin@bash.info>
*/
-static struct usbmix_dB_map mp3plus_dB_1 = {-4781, 0}; /* just guess */
-static struct usbmix_dB_map mp3plus_dB_2 = {-1781, 618}; /* just guess */
+static struct usbmix_dB_map mp3plus_dB_1 = {.min = -4781, .max = 0};
+ /* just guess */
+static struct usbmix_dB_map mp3plus_dB_2 = {.min = -1781, .max = 618};
+ /* just guess */
static struct usbmix_name_map mp3plus_map[] = {
/* 1: IT pcm */
--
1.9.1
^ permalink raw reply related [flat|nested] 4+ messages in thread
* Re: [PATCH] ALSA: usb-audio: Change structure initialisation to C99 style
2016-06-15 13:26 [PATCH] ALSA: usb-audio: Change structure initialisation to C99 style Amitoj Kaur Chawla
@ 2016-06-15 13:29 ` Takashi Iwai
2016-06-15 13:31 ` Julia Lawall
0 siblings, 1 reply; 4+ messages in thread
From: Takashi Iwai @ 2016-06-15 13:29 UTC (permalink / raw)
To: Amitoj Kaur Chawla
Cc: alsa-devel, perex, linux-kernel, keescook, michael.leibowitz,
julia.lawall
On Wed, 15 Jun 2016 15:26:34 +0200,
Amitoj Kaur Chawla wrote:
>
> Replace the in order struct initialisation style with explicit field
> style.
>
> The Coccinelle semantic patch used to make this change is as follows:
>
> @decl@
> identifier i1,fld;
> type T;
> field list[n] fs;
> @@
>
> struct i1 {
> fs
> T fld;
> ...};
>
> @@
> identifier decl.i1,i2,decl.fld;
> expression e;
> position bad.p, bad.fix;
> @@
>
> struct i1 i2@p = { ...,
> + .fld = e
> - e@fix
> ,...};
>
> Signed-off-by: Amitoj Kaur Chawla <amitoj1606@gmail.com>
> ---
> sound/usb/mixer_maps.c | 6 ++++--
> 1 file changed, 4 insertions(+), 2 deletions(-)
>
> diff --git a/sound/usb/mixer_maps.c b/sound/usb/mixer_maps.c
> index 1f8fb0d9..9038b2e 100644
> --- a/sound/usb/mixer_maps.c
> +++ b/sound/usb/mixer_maps.c
> @@ -107,8 +107,10 @@ static struct usbmix_name_map extigy_map[] = {
> * e.g. no Master and fake PCM volume
> * Pavel Mihaylov <bin@bash.info>
> */
> -static struct usbmix_dB_map mp3plus_dB_1 = {-4781, 0}; /* just guess */
> -static struct usbmix_dB_map mp3plus_dB_2 = {-1781, 618}; /* just guess */
> +static struct usbmix_dB_map mp3plus_dB_1 = {.min = -4781, .max = 0};
> + /* just guess */
> +static struct usbmix_dB_map mp3plus_dB_2 = {.min = -1781, .max = 618};
> + /* just guess */
These are simple min/max table, so no big merit to write in such a
way.
thanks,
Takashi
^ permalink raw reply [flat|nested] 4+ messages in thread
* Re: [PATCH] ALSA: usb-audio: Change structure initialisation to C99 style
2016-06-15 13:29 ` Takashi Iwai
@ 2016-06-15 13:31 ` Julia Lawall
2016-06-15 13:39 ` [alsa-devel] " Takashi Iwai
0 siblings, 1 reply; 4+ messages in thread
From: Julia Lawall @ 2016-06-15 13:31 UTC (permalink / raw)
To: Takashi Iwai
Cc: Amitoj Kaur Chawla, alsa-devel, perex, linux-kernel, keescook,
michael.leibowitz
On Wed, 15 Jun 2016, Takashi Iwai wrote:
> On Wed, 15 Jun 2016 15:26:34 +0200,
> Amitoj Kaur Chawla wrote:
> >
> > Replace the in order struct initialisation style with explicit field
> > style.
> >
> > The Coccinelle semantic patch used to make this change is as follows:
> >
> > @decl@
> > identifier i1,fld;
> > type T;
> > field list[n] fs;
> > @@
> >
> > struct i1 {
> > fs
> > T fld;
> > ...};
> >
> > @@
> > identifier decl.i1,i2,decl.fld;
> > expression e;
> > position bad.p, bad.fix;
> > @@
> >
> > struct i1 i2@p = { ...,
> > + .fld = e
> > - e@fix
> > ,...};
> >
> > Signed-off-by: Amitoj Kaur Chawla <amitoj1606@gmail.com>
> > ---
> > sound/usb/mixer_maps.c | 6 ++++--
> > 1 file changed, 4 insertions(+), 2 deletions(-)
> >
> > diff --git a/sound/usb/mixer_maps.c b/sound/usb/mixer_maps.c
> > index 1f8fb0d9..9038b2e 100644
> > --- a/sound/usb/mixer_maps.c
> > +++ b/sound/usb/mixer_maps.c
> > @@ -107,8 +107,10 @@ static struct usbmix_name_map extigy_map[] = {
> > * e.g. no Master and fake PCM volume
> > * Pavel Mihaylov <bin@bash.info>
> > */
> > -static struct usbmix_dB_map mp3plus_dB_1 = {-4781, 0}; /* just guess */
> > -static struct usbmix_dB_map mp3plus_dB_2 = {-1781, 618}; /* just guess */
> > +static struct usbmix_dB_map mp3plus_dB_1 = {.min = -4781, .max = 0};
> > + /* just guess */
> > +static struct usbmix_dB_map mp3plus_dB_2 = {.min = -1781, .max = 618};
> > + /* just guess */
>
> These are simple min/max table, so no big merit to write in such a
> way.
My understanding is that structures are going to be randomized, so at
least all global structures need C99 initialization. Maybe Kees can
provide further clarification.
julia
^ permalink raw reply [flat|nested] 4+ messages in thread
* Re: [alsa-devel] [PATCH] ALSA: usb-audio: Change structure initialisation to C99 style
2016-06-15 13:31 ` Julia Lawall
@ 2016-06-15 13:39 ` Takashi Iwai
0 siblings, 0 replies; 4+ messages in thread
From: Takashi Iwai @ 2016-06-15 13:39 UTC (permalink / raw)
To: Julia Lawall
Cc: alsa-devel, Amitoj Kaur Chawla, keescook, linux-kernel,
michael.leibowitz
On Wed, 15 Jun 2016 15:31:25 +0200,
Julia Lawall wrote:
>
>
>
> On Wed, 15 Jun 2016, Takashi Iwai wrote:
>
> > On Wed, 15 Jun 2016 15:26:34 +0200,
> > Amitoj Kaur Chawla wrote:
> > >
> > > Replace the in order struct initialisation style with explicit field
> > > style.
> > >
> > > The Coccinelle semantic patch used to make this change is as follows:
> > >
> > > @decl@
> > > identifier i1,fld;
> > > type T;
> > > field list[n] fs;
> > > @@
> > >
> > > struct i1 {
> > > fs
> > > T fld;
> > > ...};
> > >
> > > @@
> > > identifier decl.i1,i2,decl.fld;
> > > expression e;
> > > position bad.p, bad.fix;
> > > @@
> > >
> > > struct i1 i2@p = { ...,
> > > + .fld = e
> > > - e@fix
> > > ,...};
> > >
> > > Signed-off-by: Amitoj Kaur Chawla <amitoj1606@gmail.com>
> > > ---
> > > sound/usb/mixer_maps.c | 6 ++++--
> > > 1 file changed, 4 insertions(+), 2 deletions(-)
> > >
> > > diff --git a/sound/usb/mixer_maps.c b/sound/usb/mixer_maps.c
> > > index 1f8fb0d9..9038b2e 100644
> > > --- a/sound/usb/mixer_maps.c
> > > +++ b/sound/usb/mixer_maps.c
> > > @@ -107,8 +107,10 @@ static struct usbmix_name_map extigy_map[] = {
> > > * e.g. no Master and fake PCM volume
> > > * Pavel Mihaylov <bin@bash.info>
> > > */
> > > -static struct usbmix_dB_map mp3plus_dB_1 = {-4781, 0}; /* just guess */
> > > -static struct usbmix_dB_map mp3plus_dB_2 = {-1781, 618}; /* just guess */
> > > +static struct usbmix_dB_map mp3plus_dB_1 = {.min = -4781, .max = 0};
> > > + /* just guess */
> > > +static struct usbmix_dB_map mp3plus_dB_2 = {.min = -1781, .max = 618};
> > > + /* just guess */
> >
> > These are simple min/max table, so no big merit to write in such a
> > way.
>
> My understanding is that structures are going to be randomized, so at
> least all global structures need C99 initialization. Maybe Kees can
> provide further clarification.
If that's the motivation, *please* write it in the patch description.
Otherwise no one can know why such a change becomes mandatory.
thanks,
Takashi
^ permalink raw reply [flat|nested] 4+ messages in thread
end of thread, other threads:[~2016-06-15 13:39 UTC | newest]
Thread overview: 4+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2016-06-15 13:26 [PATCH] ALSA: usb-audio: Change structure initialisation to C99 style Amitoj Kaur Chawla
2016-06-15 13:29 ` Takashi Iwai
2016-06-15 13:31 ` Julia Lawall
2016-06-15 13:39 ` [alsa-devel] " Takashi Iwai
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).