* [PATCH -next] sound: fix SND_HDA_GENERIC kconfig & build
@ 2020-07-01 21:08 Randy Dunlap
2020-07-07 8:26 ` Takashi Iwai
0 siblings, 1 reply; 2+ messages in thread
From: Randy Dunlap @ 2020-07-01 21:08 UTC (permalink / raw)
To: LKML, moderated for non-subscribers, Takashi Iwai, Jaroslav Kysela
From: Randy Dunlap <rdunlap@infradead.org>
Fix kconfig warnings and lots of subsequent build errors by
adding yet another ugly select statement:
WARNING: unmet direct dependencies detected for LEDS_CLASS
Depends on [n]: NEW_LEDS [=n]
Selected by [y]:
- SND_HDA_GENERIC [=y] && SOUND [=y] && !UML && SND [=y] && SND_HDA [=y] && SND_HDA_GENERIC_LEDS [=y]
WARNING: unmet direct dependencies detected for LEDS_TRIGGERS
Depends on [n]: NEW_LEDS [=n] && LEDS_CLASS [=y]
Selected by [y]:
- SND_HDA_GENERIC [=y] && SOUND [=y] && !UML && SND [=y] && SND_HDA [=y] && SND_HDA_GENERIC_LEDS [=y]
Selected by [m]:
- MAC80211_LEDS [=y] && NET [=y] && WIRELESS [=y] && MAC80211 [=m] && LEDS_CLASS [=y]
- IWLWIFI_LEDS [=y] && NETDEVICES [=y] && WLAN [=y] && WLAN_VENDOR_INTEL [=y] && IWLWIFI [=m] && (LEDS_CLASS [=y]=y || LEDS_CLASS [=y]=IWLWIFI [=m]) && (IWLMVM [=m] || IWLDVM [=m])
WARNING: unmet direct dependencies detected for LEDS_TRIGGER_AUDIO
Depends on [n]: NEW_LEDS [=n] && LEDS_TRIGGERS [=y]
Selected by [y]:
- SND_HDA_GENERIC [=y] && SOUND [=y] && !UML && SND [=y] && SND_HDA [=y] && SND_HDA_GENERIC_LEDS [=y]
Signed-off-by: Randy Dunlap <rdunlap@infradead.org>
Cc: Jaroslav Kysela <perex@perex.cz>
Cc: Takashi Iwai <tiwai@suse.com>
Cc: alsa-devel@alsa-project.org
---
sound/pci/hda/Kconfig | 1 +
1 file changed, 1 insertion(+)
--- linux-next-20200701.orig/sound/pci/hda/Kconfig
+++ linux-next-20200701/sound/pci/hda/Kconfig
@@ -221,6 +221,7 @@ comment "Set to Y if you want auto-loadi
config SND_HDA_GENERIC
tristate "Enable generic HD-audio codec parser"
+ select NEW_LEDS if SND_HDA_GENERIC_LEDS
select LEDS_CLASS if SND_HDA_GENERIC_LEDS
select LEDS_TRIGGERS if SND_HDA_GENERIC_LEDS
select LEDS_TRIGGER_AUDIO if SND_HDA_GENERIC_LEDS
^ permalink raw reply [flat|nested] 2+ messages in thread
* Re: [PATCH -next] sound: fix SND_HDA_GENERIC kconfig & build
2020-07-01 21:08 [PATCH -next] sound: fix SND_HDA_GENERIC kconfig & build Randy Dunlap
@ 2020-07-07 8:26 ` Takashi Iwai
0 siblings, 0 replies; 2+ messages in thread
From: Takashi Iwai @ 2020-07-07 8:26 UTC (permalink / raw)
To: Randy Dunlap; +Cc: LKML, moderated for non-subscribers, Jaroslav Kysela
On Wed, 01 Jul 2020 23:08:23 +0200,
Randy Dunlap wrote:
>
> From: Randy Dunlap <rdunlap@infradead.org>
>
> Fix kconfig warnings and lots of subsequent build errors by
> adding yet another ugly select statement:
>
> WARNING: unmet direct dependencies detected for LEDS_CLASS
> Depends on [n]: NEW_LEDS [=n]
> Selected by [y]:
> - SND_HDA_GENERIC [=y] && SOUND [=y] && !UML && SND [=y] && SND_HDA [=y] && SND_HDA_GENERIC_LEDS [=y]
>
> WARNING: unmet direct dependencies detected for LEDS_TRIGGERS
> Depends on [n]: NEW_LEDS [=n] && LEDS_CLASS [=y]
> Selected by [y]:
> - SND_HDA_GENERIC [=y] && SOUND [=y] && !UML && SND [=y] && SND_HDA [=y] && SND_HDA_GENERIC_LEDS [=y]
> Selected by [m]:
> - MAC80211_LEDS [=y] && NET [=y] && WIRELESS [=y] && MAC80211 [=m] && LEDS_CLASS [=y]
> - IWLWIFI_LEDS [=y] && NETDEVICES [=y] && WLAN [=y] && WLAN_VENDOR_INTEL [=y] && IWLWIFI [=m] && (LEDS_CLASS [=y]=y || LEDS_CLASS [=y]=IWLWIFI [=m]) && (IWLMVM [=m] || IWLDVM [=m])
>
> WARNING: unmet direct dependencies detected for LEDS_TRIGGER_AUDIO
> Depends on [n]: NEW_LEDS [=n] && LEDS_TRIGGERS [=y]
> Selected by [y]:
> - SND_HDA_GENERIC [=y] && SOUND [=y] && !UML && SND [=y] && SND_HDA [=y] && SND_HDA_GENERIC_LEDS [=y]
>
> Signed-off-by: Randy Dunlap <rdunlap@infradead.org>
> Cc: Jaroslav Kysela <perex@perex.cz>
> Cc: Takashi Iwai <tiwai@suse.com>
> Cc: alsa-devel@alsa-project.org
Applied now. Thanks.
Takashi
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2020-07-07 8:26 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2020-07-01 21:08 [PATCH -next] sound: fix SND_HDA_GENERIC kconfig & build Randy Dunlap
2020-07-07 8:26 ` Takashi Iwai
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).