From: Takashi Iwai <tiwai@suse.de>
To: Arnd Bergmann <arnd@arndb.de>
Cc: alsa-devel@alsa-project.org, Takashi Iwai <tiwai@suse.com>,
Baolin Wang <baolin.wang@linaro.org>,
y2038@lists.linaro.org, linux-kernel@vger.kernel.org,
Mark Brown <broonie@kernel.org>,
Baolin Wang <baolin.wang7@gmail.com>
Subject: Re: [alsa-devel] [PATCH v6 5/8] ALSA: Avoid using timespec for struct snd_rawmidi_status
Date: Tue, 12 Nov 2019 17:38:57 +0100 [thread overview]
Message-ID: <s5hv9rpnj6m.wl-tiwai@suse.de> (raw)
In-Reply-To: <20191112151642.680072-6-arnd@arndb.de>
On Tue, 12 Nov 2019 16:16:39 +0100,
Arnd Bergmann wrote:
>
> From: Baolin Wang <baolin.wang@linaro.org>
>
> The struct snd_rawmidi_status will use 'timespec' type variables to record
> timestamp, which is not year 2038 safe on 32bits system.
>
> Thus we introduced 'struct snd_rawmidi_status32' and 'struct snd_rawmidi_status64'
> to handle 32bit time_t and 64bit time_t in native mode, which replace
> timespec with s64 type.
>
> In compat mode, we renamed or introduced new structures to handle 32bit/64bit
> time_t in compatible mode. The 'struct snd_rawmidi_status32' and
> snd_rawmidi_ioctl_status32() are used to handle 32bit time_t in compat mode.
> 'struct compat_snd_rawmidi_status64' is used to handle 64bit time_t.
>
> When glibc changes time_t to 64-bit, any recompiled program will issue ioctl
> commands that the kernel does not understand without this patch.
>
> Signed-off-by: Baolin Wang <baolin.wang@linaro.org>
> Signed-off-by: Arnd Bergmann <arnd@arndb.de>
> ---
> include/uapi/sound/asound.h | 3 +
> sound/core/rawmidi.c | 132 ++++++++++++++++++++++++++++--------
> sound/core/rawmidi_compat.c | 87 ++++++------------------
> 3 files changed, 128 insertions(+), 94 deletions(-)
>
> diff --git a/include/uapi/sound/asound.h b/include/uapi/sound/asound.h
> index 7b74524f9406..cb830813da5d 100644
> --- a/include/uapi/sound/asound.h
> +++ b/include/uapi/sound/asound.h
> @@ -651,13 +651,16 @@ struct snd_rawmidi_params {
> unsigned char reserved[16]; /* reserved for future use */
> };
>
> +#ifndef __KERNEL__
> struct snd_rawmidi_status {
> int stream;
> + unsigned char pad1[sizeof(time_t) - sizeof(int)];
> struct timespec tstamp; /* Timestamp */
> size_t avail; /* available bytes */
> size_t xruns; /* count of overruns since last status (in bytes) */
> unsigned char reserved[16]; /* reserved for future use */
> };
Can we use union instead of padding? Something like:
struct snd_rawmidi_status {
union {
int stream;
time_t stream_alignment;
};
struct timespec tstamp; /* Timestamp */
....
thanks,
Takashi
next prev parent reply other threads:[~2019-11-12 16:39 UTC|newest]
Thread overview: 26+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-11-12 15:16 [PATCH v6 0/8] Fix year 2038 issue for sound subsystem Arnd Bergmann
2019-11-12 15:16 ` [PATCH v6 1/8] ALSA: Replace timespec with timespec64 Arnd Bergmann
2019-11-12 15:16 ` [PATCH v6 2/8] ALSA: Avoid using timespec for struct snd_timer_status Arnd Bergmann
2019-11-12 15:42 ` Takashi Iwai
2019-11-12 20:08 ` Arnd Bergmann
2019-11-12 20:28 ` Takashi Iwai
2019-11-13 15:09 ` Arnd Bergmann
2019-11-12 15:16 ` [PATCH v6 3/8] ALSA: Avoid using timespec for struct snd_ctl_elem_value Arnd Bergmann
2019-11-12 15:16 ` [PATCH v6 4/8] ALSA: Avoid using timespec for struct snd_pcm_status Arnd Bergmann
2019-11-12 15:16 ` [PATCH v6 5/8] ALSA: Avoid using timespec for struct snd_rawmidi_status Arnd Bergmann
2019-11-12 16:38 ` Takashi Iwai [this message]
2019-11-12 20:04 ` [alsa-devel] " Arnd Bergmann
2019-11-12 20:26 ` Takashi Iwai
2019-11-13 15:16 ` Arnd Bergmann
2019-11-12 15:16 ` [PATCH v6 6/8] ALSA: Avoid using timespec for struct snd_timer_tread Arnd Bergmann
2019-11-12 15:16 ` [PATCH v6 7/8] ALSA: move snd_pcm_ioctl_sync_ptr_compat into pcm_native.c Arnd Bergmann
2019-11-12 15:16 ` [PATCH v6 8/8] ALSA: add new 32-bit layout for snd_pcm_mmap_status/control Arnd Bergmann
2019-11-15 15:24 ` Arnd Bergmann
2019-11-12 20:37 ` [PATCH v6 0/8] Fix year 2038 issue for sound subsystem Takashi Iwai
2019-11-13 14:32 ` Arnd Bergmann
2019-11-13 16:40 ` Takashi Iwai
2019-11-13 16:51 ` Arnd Bergmann
2019-11-13 17:04 ` Takashi Iwai
2019-11-13 17:19 ` Arnd Bergmann
2019-11-13 18:13 ` Takashi Iwai
2019-11-13 20:48 ` Arnd Bergmann
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=s5hv9rpnj6m.wl-tiwai@suse.de \
--to=tiwai@suse.de \
--cc=alsa-devel@alsa-project.org \
--cc=arnd@arndb.de \
--cc=baolin.wang7@gmail.com \
--cc=baolin.wang@linaro.org \
--cc=broonie@kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=tiwai@suse.com \
--cc=y2038@lists.linaro.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).