linux-kernel.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
* [Bugfix] PCI: Fix a typo in file pcie-xilinx.c caused by commit e39758e0ea76
       [not found] <CAErSpo6aryRYOJpfXfY6SuJoVe72MYd8RKgPhiDZ9pt5+zmXBQ@mail.gmail.com>
@ 2015-08-18 15:45 ` Jiang Liu
  2015-08-18 16:09   ` [tip:irq/core] PCI: xilinx: Fix typo in function name tip-bot for Jiang Liu
  0 siblings, 1 reply; 2+ messages in thread
From: Jiang Liu @ 2015-08-18 15:45 UTC (permalink / raw)
  To: Thomas Gleixner, Mark Brown, Stephen Rothwell, Bjorn Helgaas,
	Michal Simek, Sören Brinkmann, Jiang Liu, Srikanth Thokala,
	Rob Herring, Yijing Wang
  Cc: linux-kernel, linux-pci, linux-arm-kernel

There's a typo in commit e39758e0ea76 ("PCI: Use helper functions to access
fields in struct msi_desc") in linux-next, which incorrectly spells
"msi_desc_to_pci_sysdata()" as "msi_desc_to_pci_sys_data()" and causes
buidling failure:
> ../drivers/pci/host/pcie-xilinx.c:235:3: error: implicit declaration of function 'msi_desc_to_pci_sys_data' [-Werror=implicit-function-declaration]

Links: https://lkml.org/lkml/2015/7/9/100

Signed-off-by: Jiang Liu <jiang.liu@linux.intel.com>
---
 drivers/pci/host/pcie-xilinx.c |    2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/drivers/pci/host/pcie-xilinx.c b/drivers/pci/host/pcie-xilinx.c
index 64454f416639..be494e46bbd1 100644
--- a/drivers/pci/host/pcie-xilinx.c
+++ b/drivers/pci/host/pcie-xilinx.c
@@ -232,7 +232,7 @@ static void xilinx_pcie_destroy_msi(unsigned int irq)
 
 	if (!test_bit(irq, msi_irq_in_use)) {
 		msi = irq_get_msi_desc(irq);
-		port = sys_to_pcie(msi_desc_to_pci_sys_data(msi));
+		port = sys_to_pcie(msi_desc_to_pci_sysdata(msi));
 		dev_err(port->dev, "Trying to free unused MSI#%d\n", irq);
 	} else {
 		clear_bit(irq, msi_irq_in_use);
-- 
1.7.10.4


^ permalink raw reply related	[flat|nested] 2+ messages in thread

* [tip:irq/core] PCI: xilinx: Fix typo in function name
  2015-08-18 15:45 ` [Bugfix] PCI: Fix a typo in file pcie-xilinx.c caused by commit e39758e0ea76 Jiang Liu
@ 2015-08-18 16:09   ` tip-bot for Jiang Liu
  0 siblings, 0 replies; 2+ messages in thread
From: tip-bot for Jiang Liu @ 2015-08-18 16:09 UTC (permalink / raw)
  To: linux-tip-commits
  Cc: bhelgaas, broonie, mingo, sfr, jiang.liu, linux-kernel,
	soren.brinkmann, hpa, michal.simek, robh, tglx, wangyijing,
	sthokal

Commit-ID:  649953b5b89dc308747797810812747333d971cd
Gitweb:     http://git.kernel.org/tip/649953b5b89dc308747797810812747333d971cd
Author:     Jiang Liu <jiang.liu@linux.intel.com>
AuthorDate: Tue, 18 Aug 2015 23:45:55 +0800
Committer:  Thomas Gleixner <tglx@linutronix.de>
CommitDate: Tue, 18 Aug 2015 18:07:20 +0200

PCI: xilinx: Fix typo in function name

There's a typo in commit e39758e0ea76 in linux-next, which incorrectly
spells "msi_desc_to_pci_sysdata()" as "msi_desc_to_pci_sys_data()" and
causes build failure:

> ../drivers/pci/host/pcie-xilinx.c:235:3: error: implicit declaration
    of function 'msi_desc_to_pci_sys_data' [-Werror=implicit-function-declaration]

Fixes: e39758e0ea76 "PCI: Use helper functions to access fields in struct msi_desc"
Signed-off-by: Jiang Liu <jiang.liu@linux.intel.com>
Cc: linux-arm-kernel@lists.infradead.org
Cc: Mark Brown <broonie@kernel.org>
Cc: Stephen Rothwell <sfr@canb.auug.org.au>
Cc: Bjorn Helgaas <bhelgaas@google.com>
Cc: Michal Simek <michal.simek@xilinx.com>
Cc: Sören Brinkmann <soren.brinkmann@xilinx.com>
Cc: Srikanth Thokala <sthokal@xilinx.com>
Cc: Rob Herring <robh@kernel.org>
Cc: Yijing Wang <wangyijing@huawei.com>
Link: http://lkml.kernel.org/r/1439912763-10645-1-git-send-email-jiang.liu@linux.intel.com
Signed-off-by: Thomas Gleixner <tglx@linutronix.de>
---
 drivers/pci/host/pcie-xilinx.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/drivers/pci/host/pcie-xilinx.c b/drivers/pci/host/pcie-xilinx.c
index 64454f4..be494e4 100644
--- a/drivers/pci/host/pcie-xilinx.c
+++ b/drivers/pci/host/pcie-xilinx.c
@@ -232,7 +232,7 @@ static void xilinx_pcie_destroy_msi(unsigned int irq)
 
 	if (!test_bit(irq, msi_irq_in_use)) {
 		msi = irq_get_msi_desc(irq);
-		port = sys_to_pcie(msi_desc_to_pci_sys_data(msi));
+		port = sys_to_pcie(msi_desc_to_pci_sysdata(msi));
 		dev_err(port->dev, "Trying to free unused MSI#%d\n", irq);
 	} else {
 		clear_bit(irq, msi_irq_in_use);

^ permalink raw reply related	[flat|nested] 2+ messages in thread

end of thread, other threads:[~2015-08-18 16:10 UTC | newest]

Thread overview: 2+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
     [not found] <CAErSpo6aryRYOJpfXfY6SuJoVe72MYd8RKgPhiDZ9pt5+zmXBQ@mail.gmail.com>
2015-08-18 15:45 ` [Bugfix] PCI: Fix a typo in file pcie-xilinx.c caused by commit e39758e0ea76 Jiang Liu
2015-08-18 16:09   ` [tip:irq/core] PCI: xilinx: Fix typo in function name tip-bot for Jiang Liu

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).