[PATCH] sched: core: Fix comment regarding nr_iowait_cpu() and get_iowait_load()

* [PATCH] sched: core: Fix comment regarding nr_iowait_cpu() and get_iowait_load()
@ 2018-10-04  9:05 Rafael J. Wysocki
  2018-10-04 10:04 ` [tip:sched/core] sched/core: " tip-bot for Rafael J. Wysocki
  0 siblings, 1 reply; 2+ messages in thread
From: Rafael J. Wysocki @ 2018-10-04  9:05 UTC (permalink / raw)
  To: Ingo Molnar, Peter Zijlstra; +Cc: Linux PM, LKML, Tejun Heo

From: Rafael J. Wysocki <rafael.j.wysocki@intel.com>

The comment related to nr_iowait_cpu() and get_iowait_load() confuses
cpufreq with cpuidle and is not very useful for this reason, so fix it.

Fixes: e33a9bba85a8 "sched/core: move IO scheduling accounting from io_schedule_timeout() into scheduler"
Signed-off-by: Rafael J. Wysocki <rafael.j.wysocki@intel.com>
---
 kernel/sched/core.c |    8 ++++----
 1 file changed, 4 insertions(+), 4 deletions(-)

Index: linux-pm/kernel/sched/core.c
===================================================================

--- linux-pm.orig/kernel/sched/core.c
+++ linux-pm/kernel/sched/core.c
@@ -2915,10 +2915,10 @@ unsigned long nr_iowait(void)
 }
 
 /*
- * Consumers of these two interfaces, like for example the cpufreq menu
- * governor are using nonsensical data. Boosting frequency for a CPU that has
- * IO-wait which might not even end up running the task when it does become
- * runnable.
+ * Consumers of these two interfaces, like for example the cpuidle menu
+ * governor, are using nonsensical data. Preferring shallow idle state selection
+ * for a CPU that has IO-wait which might not even end up running the task when
+ * it does become runnable.
  */
 
 unsigned long nr_iowait_cpu(int cpu)


^ permalink raw reply	[flat|nested] 2+ messages in thread