linux-kernel.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
* [PATCH] [TRIVIAL] perf probe usability related fixes.
@ 2012-01-20 12:13 Srikar Dronamraju
  2012-01-20 14:47 ` David Ahern
                   ` (2 more replies)
  0 siblings, 3 replies; 4+ messages in thread
From: Srikar Dronamraju @ 2012-01-20 12:13 UTC (permalink / raw)
  To: Ingo Molnar; +Cc: Arnaldo Carvalho de Melo, Masami Hiramatsu, LKML

From: Srikar Dronamraju <srikar@linux.vnet.ibm.com>

Ingo pointed out few perf probe usability related errors during
his review of uprobes.

Since these issues are independent of uprobes, fixing them in a
separate patch.

Suggested-by: Ingo Molnar <mingo@elte.hu>
Signed-off-by: Srikar Dronamraju <srikar@linux.vnet.ibm.com>
---
 tools/perf/util/probe-event.c |    6 +++---
 1 files changed, 3 insertions(+), 3 deletions(-)

diff --git a/tools/perf/util/probe-event.c b/tools/perf/util/probe-event.c
index f6f5794..da38ec5 100644
--- a/tools/perf/util/probe-event.c
+++ b/tools/perf/util/probe-event.c
@@ -1825,7 +1825,7 @@ static int __add_probe_trace_events(struct perf_probe_event *pev,
 	}
 
 	ret = 0;
-	printf("Add new event%s\n", (ntevs > 1) ? "s:" : ":");
+	printf("Added new event%s\n", (ntevs > 1) ? "s:" : ":");
 	for (i = 0; i < ntevs; i++) {
 		tev = &tevs[i];
 		if (pev->event)
@@ -1880,7 +1880,7 @@ static int __add_probe_trace_events(struct perf_probe_event *pev,
 
 	if (ret >= 0) {
 		/* Show how to use the event. */
-		printf("\nYou can now use it on all perf tools, such as:\n\n");
+		printf("\nYou can now use it in all perf tools, such as:\n\n");
 		printf("\tperf record -e %s:%s -aR sleep 1\n\n", tev->group,
 			 tev->event);
 	}
@@ -2063,7 +2063,7 @@ static int __del_trace_probe_event(int fd, struct str_node *ent)
 		goto error;
 	}
 
-	printf("Remove event: %s\n", ent->s);
+	printf("Removed event: %s\n", ent->s);
 	return 0;
 error:
 	pr_warning("Failed to delete event: %s\n", strerror(-ret));


^ permalink raw reply related	[flat|nested] 4+ messages in thread
* Re: [PATCH] [TRIVIAL] perf probe usability related fixes.
  2012-01-20 12:13 [PATCH] [TRIVIAL] perf probe usability related fixes Srikar Dronamraju
@ 2012-01-20 14:47 ` David Ahern
  2012-01-24  0:27 ` Masami Hiramatsu
  2012-01-26 13:35 ` [tip:perf/core] perf probe: Usability fixes tip-bot for Srikar Dronamraju
  2 siblings, 0 replies; 4+ messages in thread
From: David Ahern @ 2012-01-20 14:47 UTC (permalink / raw)
  To: Srikar Dronamraju
  Cc: Ingo Molnar, Arnaldo Carvalho de Melo, Masami Hiramatsu, LKML

On 01/20/2012 05:13 AM, Srikar Dronamraju wrote:
> From: Srikar Dronamraju <srikar@linux.vnet.ibm.com>
> 
> Ingo pointed out few perf probe usability related errors during
> his review of uprobes.
> 
> Since these issues are independent of uprobes, fixing them in a
> separate patch.
> 
> Suggested-by: Ingo Molnar <mingo@elte.hu>
> Signed-off-by: Srikar Dronamraju <srikar@linux.vnet.ibm.com>
> ---
>  tools/perf/util/probe-event.c |    6 +++---
>  1 files changed, 3 insertions(+), 3 deletions(-)
> 
> diff --git a/tools/perf/util/probe-event.c b/tools/perf/util/probe-event.c
> index f6f5794..da38ec5 100644
> --- a/tools/perf/util/probe-event.c
> +++ b/tools/perf/util/probe-event.c
> @@ -1825,7 +1825,7 @@ static int __add_probe_trace_events(struct perf_probe_event *pev,
>  	}
>  
>  	ret = 0;
> -	printf("Add new event%s\n", (ntevs > 1) ? "s:" : ":");
> +	printf("Added new event%s\n", (ntevs > 1) ? "s:" : ":");

It's not past tense until after write_probe_trace_event() right? Where
the message is now you can get an error message after that printf.

David


^ permalink raw reply	[flat|nested] 4+ messages in thread
* Re: [PATCH] [TRIVIAL] perf probe usability related fixes.
  2012-01-20 12:13 [PATCH] [TRIVIAL] perf probe usability related fixes Srikar Dronamraju
  2012-01-20 14:47 ` David Ahern
@ 2012-01-24  0:27 ` Masami Hiramatsu
  2012-01-26 13:35 ` [tip:perf/core] perf probe: Usability fixes tip-bot for Srikar Dronamraju
  2 siblings, 0 replies; 4+ messages in thread
From: Masami Hiramatsu @ 2012-01-24  0:27 UTC (permalink / raw)
  To: Srikar Dronamraju; +Cc: Ingo Molnar, Arnaldo Carvalho de Melo, LKML

(2012/01/20 21:13), Srikar Dronamraju wrote:
> From: Srikar Dronamraju <srikar@linux.vnet.ibm.com>
> 
> Ingo pointed out few perf probe usability related errors during
> his review of uprobes.
> 
> Since these issues are independent of uprobes, fixing them in a
> separate patch.
> 
> Suggested-by: Ingo Molnar <mingo@elte.hu>
> Signed-off-by: Srikar Dronamraju <srikar@linux.vnet.ibm.com>

Acked-by: Masami Hiramatsu <masami.hiramatsu.pt@hitachi.com>

Thanks!

> ---
>  tools/perf/util/probe-event.c |    6 +++---
>  1 files changed, 3 insertions(+), 3 deletions(-)
> 
> diff --git a/tools/perf/util/probe-event.c b/tools/perf/util/probe-event.c
> index f6f5794..da38ec5 100644
> --- a/tools/perf/util/probe-event.c
> +++ b/tools/perf/util/probe-event.c
> @@ -1825,7 +1825,7 @@ static int __add_probe_trace_events(struct perf_probe_event *pev,
>  	}
>  
>  	ret = 0;
> -	printf("Add new event%s\n", (ntevs > 1) ? "s:" : ":");
> +	printf("Added new event%s\n", (ntevs > 1) ? "s:" : ":");
>  	for (i = 0; i < ntevs; i++) {
>  		tev = &tevs[i];
>  		if (pev->event)
> @@ -1880,7 +1880,7 @@ static int __add_probe_trace_events(struct perf_probe_event *pev,
>  
>  	if (ret >= 0) {
>  		/* Show how to use the event. */
> -		printf("\nYou can now use it on all perf tools, such as:\n\n");
> +		printf("\nYou can now use it in all perf tools, such as:\n\n");
>  		printf("\tperf record -e %s:%s -aR sleep 1\n\n", tev->group,
>  			 tev->event);
>  	}
> @@ -2063,7 +2063,7 @@ static int __del_trace_probe_event(int fd, struct str_node *ent)
>  		goto error;
>  	}
>  
> -	printf("Remove event: %s\n", ent->s);
> +	printf("Removed event: %s\n", ent->s);
>  	return 0;
>  error:
>  	pr_warning("Failed to delete event: %s\n", strerror(-ret));
> 


-- 
Masami HIRAMATSU
Software Platform Research Dept. Linux Technology Center
Hitachi, Ltd., Yokohama Research Laboratory
E-mail: masami.hiramatsu.pt@hitachi.com

^ permalink raw reply	[flat|nested] 4+ messages in thread
* [tip:perf/core] perf probe: Usability fixes
  2012-01-20 12:13 [PATCH] [TRIVIAL] perf probe usability related fixes Srikar Dronamraju
  2012-01-20 14:47 ` David Ahern
  2012-01-24  0:27 ` Masami Hiramatsu
@ 2012-01-26 13:35 ` tip-bot for Srikar Dronamraju
  2 siblings, 0 replies; 4+ messages in thread
From: tip-bot for Srikar Dronamraju @ 2012-01-26 13:35 UTC (permalink / raw)
  To: linux-tip-commits
  Cc: acme, linux-kernel, hpa, mingo, masami.hiramatsu.pt, srikar, tglx, mingo

Commit-ID:  a844d1ef09872a8b8c66d431edd1b8a943e51c7a
Gitweb:     http://git.kernel.org/tip/a844d1ef09872a8b8c66d431edd1b8a943e51c7a
Author:     Srikar Dronamraju <srikar@linux.vnet.ibm.com>
AuthorDate: Fri, 20 Jan 2012 17:43:54 +0530
Committer:  Arnaldo Carvalho de Melo <acme@redhat.com>
CommitDate: Tue, 24 Jan 2012 20:31:02 -0200

perf probe: Usability fixes

Ingo pointed out few perf probe usability related errors during his
review of uprobes.

Since these issues are independent of uprobes, fixing them in a separate
patch.

Suggested-by: Ingo Molnar <mingo@elte.hu>
Acked-by: Masami Hiramatsu <masami.hiramatsu.pt@hitachi.com
Cc: Ingo Molnar <mingo@elte.hu>
Cc: Masami Hiramatsu <masami.hiramatsu.pt@hitachi.com>
Link: http://lkml.kernel.org/r/20120120121354.GL15447@linux.vnet.ibm.com
Signed-off-by: Srikar Dronamraju <srikar@linux.vnet.ibm.com>
Signed-off-by: Arnaldo Carvalho de Melo <acme@redhat.com>
---
 tools/perf/util/probe-event.c |    6 +++---
 1 files changed, 3 insertions(+), 3 deletions(-)

diff --git a/tools/perf/util/probe-event.c b/tools/perf/util/probe-event.c
index 29cb654..b9bbdd2 100644
--- a/tools/perf/util/probe-event.c
+++ b/tools/perf/util/probe-event.c
@@ -1729,7 +1729,7 @@ static int __add_probe_trace_events(struct perf_probe_event *pev,
 	}
 
 	ret = 0;
-	printf("Add new event%s\n", (ntevs > 1) ? "s:" : ":");
+	printf("Added new event%s\n", (ntevs > 1) ? "s:" : ":");
 	for (i = 0; i < ntevs; i++) {
 		tev = &tevs[i];
 		if (pev->event)
@@ -1784,7 +1784,7 @@ static int __add_probe_trace_events(struct perf_probe_event *pev,
 
 	if (ret >= 0) {
 		/* Show how to use the event. */
-		printf("\nYou can now use it on all perf tools, such as:\n\n");
+		printf("\nYou can now use it in all perf tools, such as:\n\n");
 		printf("\tperf record -e %s:%s -aR sleep 1\n\n", tev->group,
 			 tev->event);
 	}
@@ -1959,7 +1959,7 @@ static int __del_trace_probe_event(int fd, struct str_node *ent)
 		goto error;
 	}
 
-	printf("Remove event: %s\n", ent->s);
+	printf("Removed event: %s\n", ent->s);
 	return 0;
 error:
 	pr_warning("Failed to delete event: %s\n", strerror(-ret));

^ permalink raw reply related	[flat|nested] 4+ messages in thread
end of thread, other threads:[~2012-01-26 13:36 UTC | newest]

Thread overview: 4+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2012-01-20 12:13 [PATCH] [TRIVIAL] perf probe usability related fixes Srikar Dronamraju
2012-01-20 14:47 ` David Ahern
2012-01-24  0:27 ` Masami Hiramatsu
2012-01-26 13:35 ` [tip:perf/core] perf probe: Usability fixes tip-bot for Srikar Dronamraju

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).