lttng-dev.lists.lttng.org archive mirror
 help / color / mirror / Atom feed
From: Mathieu Desnoyers via lttng-dev <lttng-dev@lists.lttng.org>
To: diamon-discuss@lists.linuxfoundation.org
Cc: Jeremie Galarneau <jgalar@efficios.com>,
	lttng-dev@lists.lttng.org, Philippe Proulx <pproulx@efficios.com>,
	Genevieve Bastien <gbastien+lttng@versatic.net>
Subject: [RFC PATCH CTF] Clarify signedness of clock offset_s and offset fields
Date: Thu, 23 Jul 2020 10:45:03 -0400	[thread overview]
Message-ID: <20200723144503.5477-1-mathieu.desnoyers@efficios.com> (raw)

Clarify that both offset_s and offset fields of clock may have
negative values.

Signed-off-by: Mathieu Desnoyers <mathieu.desnoyers@efficios.com>
---
 common-trace-format-specification.md | 10 +++++-----
 1 file changed, 5 insertions(+), 5 deletions(-)

diff --git a/common-trace-format-specification.md b/common-trace-format-specification.md
index b40082c..d4c69ad 100644
--- a/common-trace-format-specification.md
+++ b/common-trace-format-specification.md
@@ -1545,11 +1545,11 @@ The `offset_s` and `offset` fields indicate the offset from
 POSIX.1 Epoch, 1970-01-01 00:00:00 +0000 (UTC), to the zero of value
 of the clock. The `offset_s` field is in seconds. The `offset` field is
 in (1/freq) units. If any of the `offset_s` or `offset` field is not
-present, it is assigned the 0 value. The field `absolute` is `TRUE` if
-the clock is a global reference across different clock UUID
-(e.g. NTP time). Otherwise, `absolute` is `FALSE`, and the clock can
-be considered as synchronized only with other clocks that have the same
-UUID.
+present, it is assigned the 0 value. Both `offset_s` and `offset`
+fields are signed integers. The field `absolute` is `TRUE` if the clock
+is a global reference across different clock UUID (e.g. NTP time).
+Otherwise, `absolute` is `FALSE`, and the clock can be considered as
+synchronized only with other clocks that have the same UUID.
 
 Secondly, a reference to this clock should be added within an integer
 type:
-- 
2.11.0

WARNING: multiple messages have this Message-ID (diff)
From: Mathieu Desnoyers via lttng-dev <lttng-dev@lists.lttng.org>
To: diamon-discuss@lists.linuxfoundation.org
Cc: Jeremie Galarneau <jgalar@efficios.com>,
	lttng-dev@lists.lttng.org, Philippe Proulx <pproulx@efficios.com>,
	Genevieve Bastien <gbastien+lttng@versatic.net>
Subject: [lttng-dev] [RFC PATCH CTF] Clarify signedness of clock offset_s and offset fields
Date: Thu, 23 Jul 2020 10:45:03 -0400	[thread overview]
Message-ID: <20200723144503.5477-1-mathieu.desnoyers@efficios.com> (raw)
Message-ID: <20200723144503.qhs5mPKS6X-bQSTvRJ76awZxDfbFnX1Cd86RYEfzQ8Y@z> (raw)

Clarify that both offset_s and offset fields of clock may have
negative values.

Signed-off-by: Mathieu Desnoyers <mathieu.desnoyers@efficios.com>
---
 common-trace-format-specification.md | 10 +++++-----
 1 file changed, 5 insertions(+), 5 deletions(-)

diff --git a/common-trace-format-specification.md b/common-trace-format-specification.md
index b40082c..d4c69ad 100644
--- a/common-trace-format-specification.md
+++ b/common-trace-format-specification.md
@@ -1545,11 +1545,11 @@ The `offset_s` and `offset` fields indicate the offset from
 POSIX.1 Epoch, 1970-01-01 00:00:00 +0000 (UTC), to the zero of value
 of the clock. The `offset_s` field is in seconds. The `offset` field is
 in (1/freq) units. If any of the `offset_s` or `offset` field is not
-present, it is assigned the 0 value. The field `absolute` is `TRUE` if
-the clock is a global reference across different clock UUID
-(e.g. NTP time). Otherwise, `absolute` is `FALSE`, and the clock can
-be considered as synchronized only with other clocks that have the same
-UUID.
+present, it is assigned the 0 value. Both `offset_s` and `offset`
+fields are signed integers. The field `absolute` is `TRUE` if the clock
+is a global reference across different clock UUID (e.g. NTP time).
+Otherwise, `absolute` is `FALSE`, and the clock can be considered as
+synchronized only with other clocks that have the same UUID.
 
 Secondly, a reference to this clock should be added within an integer
 type:
-- 
2.11.0

_______________________________________________
lttng-dev mailing list
lttng-dev@lists.lttng.org
https://lists.lttng.org/cgi-bin/mailman/listinfo/lttng-dev

             reply	other threads:[~2020-07-23 14:45 UTC|newest]

Thread overview: 2+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2020-07-23 14:45 Mathieu Desnoyers via lttng-dev [this message]
2020-07-23 14:45 ` [lttng-dev] [RFC PATCH CTF] Clarify signedness of clock offset_s and offset fields Mathieu Desnoyers via lttng-dev

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20200723144503.5477-1-mathieu.desnoyers@efficios.com \
    --to=lttng-dev@lists.lttng.org \
    --cc=diamon-discuss@lists.linuxfoundation.org \
    --cc=gbastien+lttng@versatic.net \
    --cc=jgalar@efficios.com \
    --cc=mathieu.desnoyers@efficios.com \
    --cc=pproulx@efficios.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).