Re: [lttng-dev] [PATCH 7/7] Experiment: Add explicit memory barrier in free_completion()

[Mathieu Desnoyers via lttng-dev <lttng-dev@lists.lttng.org>]

On 2023-03-17 17:37, Ondřej Surý via lttng-dev wrote:
> FIXME: This is experiment that adds explicit memory barrier in the
> free_completion in the workqueue.c, so ThreadSanitizer knows it's ok to
> free the resources.
> 
> Signed-off-by: Ondřej Surý <ondrej@sury.org>
> ---
>   src/workqueue.c | 1 +
>   1 file changed, 1 insertion(+)
> 
> diff --git a/src/workqueue.c b/src/workqueue.c
> index 1039d72..f21907f 100644
> --- a/src/workqueue.c
> +++ b/src/workqueue.c
> @@ -377,6 +377,7 @@ void free_completion(struct urcu_ref *ref)
>   	struct urcu_workqueue_completion *completion;
>   
>   	completion = caa_container_of(ref, struct urcu_workqueue_completion, ref);
> +	assert(!urcu_ref_get_unless_zero(&completion->ref));

Perhaps what we really want here is an ANNOTATE_UNPUBLISH_MEMORY_RANGE() 
of some sort ?

Thanks,

Mathieu

>   	free(completion);
>   }
>   

-- 
Mathieu Desnoyers
EfficiOS Inc.
https://www.efficios.com

_______________________________________________
lttng-dev mailing list
lttng-dev@lists.lttng.org
https://lists.lttng.org/cgi-bin/mailman/listinfo/lttng-dev