mm-commits.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
* [patch 086/114] drivers/scsi/megaraid: remove expensive inline from megasas_return_cmd
@ 2017-05-08 22:58 akpm
  0 siblings, 0 replies; only message in thread
From: akpm @ 2017-05-08 22:58 UTC (permalink / raw)
  To: ak, akpm, James.Bottomley, kashyap.desai, mm-commits,
	sumit.saxena, torvalds

From: Andi Kleen <ak@linux.intel.com>
Subject: drivers/scsi/megaraid: remove expensive inline from megasas_return_cmd

Remove an inline from a fairly big function that is used often.  It's
unlikely that calling or not calling it makes a lot of difference.

Saves around 8k text in my kernel.

   text    data     bss     dec     hex filename
9047801 5367568 11116544        25531913        1859609 vmlinux-before-megasas
9039417 5367568 11116544        25523529        1857549 vmlinux-megasas

Link: http://lkml.kernel.org/r/20170315021431.13107-7-andi@firstfloor.org
Signed-off-by: Andi Kleen <ak@linux.intel.com>
Cc: Kashyap Desai <kashyap.desai@avagotech.com>
Cc: Sumit Saxena <sumit.saxena@avagotech.com>
Cc: James Bottomley <James.Bottomley@HansenPartnership.com>
Signed-off-by: Andrew Morton <akpm@linux-foundation.org>
---

 drivers/scsi/megaraid/megaraid_sas_base.c |    2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff -puN drivers/scsi/megaraid/megaraid_sas_base.c~megasas-remove-expensive-inline-from-megasas_return_cmd drivers/scsi/megaraid/megaraid_sas_base.c
--- a/drivers/scsi/megaraid/megaraid_sas_base.c~megasas-remove-expensive-inline-from-megasas_return_cmd
+++ a/drivers/scsi/megaraid/megaraid_sas_base.c
@@ -244,7 +244,7 @@ struct megasas_cmd *megasas_get_cmd(stru
  * @instance:		Adapter soft state
  * @cmd:		Command packet to be returned to free command pool
  */
-inline void
+void
 megasas_return_cmd(struct megasas_instance *instance, struct megasas_cmd *cmd)
 {
 	unsigned long flags;
_

^ permalink raw reply	[flat|nested] only message in thread

only message in thread, other threads:[~2017-05-08 22:58 UTC | newest]

Thread overview: (only message) (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2017-05-08 22:58 [patch 086/114] drivers/scsi/megaraid: remove expensive inline from megasas_return_cmd akpm

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).