* [patch 042/108] mm, THP, swap: enable THP swap optimization only if has compound map
@ 2017-07-06 22:37 akpm
0 siblings, 0 replies; only message in thread
From: akpm @ 2017-07-06 22:37 UTC (permalink / raw)
To: aarcange, akpm, ebru.akagunduz, hannes, hughd, kirill.shutemov,
mhocko, minchan, mm-commits, riel, shli, tj, torvalds,
ying.huang
From: Huang Ying <ying.huang@intel.com>
Subject: mm, THP, swap: enable THP swap optimization only if has compound map
If there is no compound map for a THP (Transparent Huge Page), it is
possible that the map count of some sub-pages of the THP is 0. So it is
better to split the THP before swapping out. In this way, the sub-pages
not mapped will be freed, and we can avoid the unnecessary swap out
operations for these sub-pages.
Link: http://lkml.kernel.org/r/20170515112522.32457-6-ying.huang@intel.com
Signed-off-by: "Huang, Ying" <ying.huang@intel.com>
Cc: Johannes Weiner <hannes@cmpxchg.org>
Cc: Andrea Arcangeli <aarcange@redhat.com>
Cc: Ebru Akagunduz <ebru.akagunduz@gmail.com>
Cc: Hugh Dickins <hughd@google.com>
Cc: Kirill A. Shutemov <kirill.shutemov@linux.intel.com>
Cc: Michal Hocko <mhocko@kernel.org>
Cc: Minchan Kim <minchan@kernel.org>
Cc: Rik van Riel <riel@redhat.com>
Cc: Shaohua Li <shli@kernel.org>
Cc: Tejun Heo <tj@kernel.org>
Signed-off-by: Andrew Morton <akpm@linux-foundation.org>
---
mm/vmscan.c | 17 +++++++++++++----
1 file changed, 13 insertions(+), 4 deletions(-)
diff -puN mm/vmscan.c~mm-thp-swap-enable-thp-swap-optimization-only-if-has-compound-map mm/vmscan.c
--- a/mm/vmscan.c~mm-thp-swap-enable-thp-swap-optimization-only-if-has-compound-map
+++ a/mm/vmscan.c
@@ -1125,10 +1125,19 @@ static unsigned long shrink_page_list(st
!PageSwapCache(page)) {
if (!(sc->gfp_mask & __GFP_IO))
goto keep_locked;
- /* cannot split THP, skip it */
- if (PageTransHuge(page) &&
- !can_split_huge_page(page, NULL))
- goto activate_locked;
+ if (PageTransHuge(page)) {
+ /* cannot split THP, skip it */
+ if (!can_split_huge_page(page, NULL))
+ goto activate_locked;
+ /*
+ * Split pages without a PMD map right
+ * away. Chances are some or all of the
+ * tail pages can be freed without IO.
+ */
+ if (!compound_mapcount(page) &&
+ split_huge_page_to_list(page, page_list))
+ goto activate_locked;
+ }
if (!add_to_swap(page)) {
if (!PageTransHuge(page))
goto activate_locked;
_
^ permalink raw reply [flat|nested] only message in thread
only message in thread, other threads:[~2017-07-06 22:37 UTC | newest]
Thread overview: (only message) (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2017-07-06 22:37 [patch 042/108] mm, THP, swap: enable THP swap optimization only if has compound map akpm
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).