* [merged] mm-have-filemap_check_and_advance_wb_err-clear-as_eio-as_enospc.patch removed from -mm tree
@ 2017-10-04 19:40 akpm
0 siblings, 0 replies; only message in thread
From: akpm @ 2017-10-04 19:40 UTC (permalink / raw)
To: eguan, jack, jlayton, mm-commits
The patch titled
Subject: mm: have filemap_check_and_advance_wb_err clear AS_EIO/AS_ENOSPC
has been removed from the -mm tree. Its filename was
mm-have-filemap_check_and_advance_wb_err-clear-as_eio-as_enospc.patch
This patch was dropped because it was merged into mainline or a subsystem tree
------------------------------------------------------
From: Jeff Layton <jlayton@redhat.com>
Subject: mm: have filemap_check_and_advance_wb_err clear AS_EIO/AS_ENOSPC
Eryu noticed that he could sometimes get a leftover error reported when it
shouldn't be on fsync with ext2 and non-journalled ext4. The problem is
that writeback_single_inode still uses filemap_fdatawait. That picks up a
previously set AS_EIO flag, which would ordinarily have been cleared
before.
Since we're mostly using this function as a replacement for
filemap_check_errors, have filemap_check_and_advance_wb_err clear AS_EIO
and AS_ENOSPC when reporting an error. That should allow the new function
to better emulate the behavior of the old with respect to these flags.
Link: http://lkml.kernel.org/r/20170922133331.28812-1-jlayton@kernel.org
Signed-off-by: Jeff Layton <jlayton@redhat.com>
Reported-by: Eryu Guan <eguan@redhat.com>
Reviewed-by: Jan Kara <jack@suse.cz>
Signed-off-by: Andrew Morton <akpm@linux-foundation.org>
---
mm/filemap.c | 8 ++++++++
1 file changed, 8 insertions(+)
diff -puN mm/filemap.c~mm-have-filemap_check_and_advance_wb_err-clear-as_eio-as_enospc mm/filemap.c
--- a/mm/filemap.c~mm-have-filemap_check_and_advance_wb_err-clear-as_eio-as_enospc
+++ a/mm/filemap.c
@@ -620,6 +620,14 @@ int file_check_and_advance_wb_err(struct
trace_file_check_and_advance_wb_err(file, old);
spin_unlock(&file->f_lock);
}
+
+ /*
+ * We're mostly using this function as a drop in replacement for
+ * filemap_check_errors. Clear AS_EIO/AS_ENOSPC to emulate the effect
+ * that the legacy code would have had on these flags.
+ */
+ clear_bit(AS_EIO, &mapping->flags);
+ clear_bit(AS_ENOSPC, &mapping->flags);
return err;
}
EXPORT_SYMBOL(file_check_and_advance_wb_err);
_
Patches currently in -mm which might be from jlayton@redhat.com are
^ permalink raw reply [flat|nested] only message in thread
only message in thread, other threads:[~2017-10-04 19:40 UTC | newest]
Thread overview: (only message) (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2017-10-04 19:40 [merged] mm-have-filemap_check_and_advance_wb_err-clear-as_eio-as_enospc.patch removed from -mm tree akpm
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).