mm-commits.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
* [to-be-updated] kernel-forkc-annotate-data-races-for-copy_process.patch removed from -mm tree
@ 2020-06-21  2:04 akpm
  0 siblings, 0 replies; only message in thread
From: akpm @ 2020-06-21  2:04 UTC (permalink / raw)
  To: mm-commits, tglx, paulmck, oleg, lizefan, elver,
	christian.brauner, cai, chenweilong


The patch titled
     Subject: kernel/fork.c: annotate data races for copy_process
has been removed from the -mm tree.  Its filename was
     kernel-forkc-annotate-data-races-for-copy_process.patch

This patch was dropped because an updated version will be merged

------------------------------------------------------
From: Weilong Chen <chenweilong@huawei.com>
Subject: kernel/fork.c: annotate data races for copy_process

The check is only there to stop root fork bombs.

BUG: KCSAN: data-race in copy_process / copy_process

write to 0xffffffff86f87d20 of 4 bytes by task 7121 on cpu 5:
 copy_process+0x2e1a/0x3af0 kernel/fork.c:2285
 _do_fork+0xf7/0x790 kernel/fork.c:2430
 __do_sys_clone+0xf9/0x130 kernel/fork.c:2585
 __se_sys_clone kernel/fork.c:2566 [inline]
 __x64_sys_clone+0x6c/0x80 kernel/fork.c:2566
 do_syscall_64+0xc7/0x3b0 arch/x86/entry/common.c:295
 entry_SYSCALL_64_after_hwframe+0x44/0xa9

read to 0xffffffff86f87d20 of 4 bytes by task 7125 on cpu 3:
 copy_process+0x9eb/0x3af0 kernel/fork.c:1967
 _do_fork+0xf7/0x790 kernel/fork.c:2430
 __do_sys_clone+0xf9/0x130 kernel/fork.c:2585
 __se_sys_clone kernel/fork.c:2566 [inline]
 __x64_sys_clone+0x6c/0x80 kernel/fork.c:2566
 do_syscall_64+0xc7/0x3b0 arch/x86/entry/common.c:295
 entry_SYSCALL_64_after_hwframe+0x44/0xa9

Link: http://lkml.kernel.org/r/20200609030801.272704-1-chenweilong@huawei.com
Signed-off-by: Weilong Chen <chenweilong@huawei.com>
Cc: Qian Cai <cai@lca.pw>
Cc: Marco Elver <elver@google.com>
Cc: Christian Brauner <christian.brauner@ubuntu.com>
Cc: Thomas Gleixner <tglx@linutronix.de>
Cc: Zefan Li <lizefan@huawei.com>
Cc: Oleg Nesterov <oleg@redhat.com>
Cc: "Paul E. McKenney" <paulmck@kernel.org>
Signed-off-by: Andrew Morton <akpm@linux-foundation.org>
---

 kernel/fork.c |    2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

--- a/kernel/fork.c~kernel-forkc-annotate-data-races-for-copy_process
+++ a/kernel/fork.c
@@ -1976,7 +1976,7 @@ static __latent_entropy struct task_stru
 	 * to stop root fork bombs.
 	 */
 	retval = -EAGAIN;
-	if (nr_threads >= max_threads)
+	if (data_race(nr_threads >= max_threads))
 		goto bad_fork_cleanup_count;
 
 	delayacct_tsk_init(p);	/* Must remain after dup_task_struct() */
_

Patches currently in -mm which might be from chenweilong@huawei.com are

^ permalink raw reply	[flat|nested] only message in thread

only message in thread, other threads:[~2020-06-21  2:04 UTC | newest]

Thread overview: (only message) (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2020-06-21  2:04 [to-be-updated] kernel-forkc-annotate-data-races-for-copy_process.patch removed from -mm tree akpm

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).