* + fs-ntfs-fix-set-but-not-used-variable-log_page_mask.patch added to -mm tree
@ 2020-12-09 0:35 akpm
0 siblings, 0 replies; only message in thread
From: akpm @ 2020-12-09 0:35 UTC (permalink / raw)
To: mm-commits, anton, zhengzengkai
The patch titled
Subject: fs/ntfs: fix set but not used variable 'log_page_mask'
has been added to the -mm tree. Its filename is
fs-ntfs-fix-set-but-not-used-variable-log_page_mask.patch
This patch should soon appear at
https://ozlabs.org/~akpm/mmots/broken-out/fs-ntfs-fix-set-but-not-used-variable-log_page_mask.patch
and later at
https://ozlabs.org/~akpm/mmotm/broken-out/fs-ntfs-fix-set-but-not-used-variable-log_page_mask.patch
Before you just go and hit "reply", please:
a) Consider who else should be cc'ed
b) Prefer to cc a suitable mailing list as well
c) Ideally: find the original patch on the mailing list and do a
reply-to-all to that, adding suitable additional cc's
*** Remember to use Documentation/process/submit-checklist.rst when testing your code ***
The -mm tree is included into linux-next and is updated
there every 3-4 working days
------------------------------------------------------
From: Zheng Zengkai <zhengzengkai@huawei.com>
Subject: fs/ntfs: fix set but not used variable 'log_page_mask'
Fixes gcc '-Wunused-but-set-variable' warning:
fs/ntfs/logfile.c: In function ntfs_check_logfile:
fs/ntfs/logfile.c:481:21:
warning: variable log_page_mask set but not used [-Wunused-but-set-variable]
Actually log_page_mask can be used to replace 'log_page_size - 1' as it is set.
Link: https://lkml.kernel.org/r/20200312041353.19877-1-zhengzengkai@huawei.com
Signed-off-by: Zheng Zengkai <zhengzengkai@huawei.com>
Acked-by: Anton Altaparmakov <anton@tuxera.com>
Signed-off-by: Andrew Morton <akpm@linux-foundation.org>
---
fs/ntfs/logfile.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
--- a/fs/ntfs/logfile.c~fs-ntfs-fix-set-but-not-used-variable-log_page_mask
+++ a/fs/ntfs/logfile.c
@@ -506,7 +506,7 @@ bool ntfs_check_logfile(struct inode *lo
* optimize log_page_size and log_page_bits into constants.
*/
log_page_bits = ntfs_ffs(log_page_size) - 1;
- size &= ~(s64)(log_page_size - 1);
+ size &= ~(s64)(log_page_mask);
/*
* Ensure the log file is big enough to store at least the two restart
* pages and the minimum number of log record pages.
_
Patches currently in -mm which might be from zhengzengkai@huawei.com are
fs-ntfs-fix-set-but-not-used-variable-log_page_mask.patch
^ permalink raw reply [flat|nested] only message in thread
only message in thread, other threads:[~2020-12-09 0:36 UTC | newest]
Thread overview: (only message) (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2020-12-09 0:35 + fs-ntfs-fix-set-but-not-used-variable-log_page_mask.patch added to -mm tree akpm
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).