* + lib-stackdepot-add-support-to-disable-stack-depot-fix-2.patch added to -mm tree
@ 2021-02-01 23:42 akpm
0 siblings, 0 replies; only message in thread
From: akpm @ 2021-02-01 23:42 UTC (permalink / raw)
To: mm-commits, vjitta
The patch titled
Subject: lib: stackdepot: fix ignoring return value warning
has been added to the -mm tree. Its filename is
lib-stackdepot-add-support-to-disable-stack-depot-fix-2.patch
This patch should soon appear at
https://ozlabs.org/~akpm/mmots/broken-out/lib-stackdepot-add-support-to-disable-stack-depot-fix-2.patch
and later at
https://ozlabs.org/~akpm/mmotm/broken-out/lib-stackdepot-add-support-to-disable-stack-depot-fix-2.patch
Before you just go and hit "reply", please:
a) Consider who else should be cc'ed
b) Prefer to cc a suitable mailing list as well
c) Ideally: find the original patch on the mailing list and do a
reply-to-all to that, adding suitable additional cc's
*** Remember to use Documentation/process/submit-checklist.rst when testing your code ***
The -mm tree is included into linux-next and is updated
there every 3-4 working days
------------------------------------------------------
From: Vijayanand Jitta <vjitta@codeaurora.org>
Subject: lib: stackdepot: fix ignoring return value warning
Fix the below ignoring return value warning for kstrtobool in
is_stack_depot_disabled function.
lib/stackdepot.c: In function 'is_stack_depot_disabled':
lib/stackdepot.c:154:2: warning: ignoring return value of 'kstrtobool'
declared with attribute 'warn_unused_result' [-Wunused-result]
Link: https://lkml.kernel.org/r/1612163048-28026-1-git-send-email-vjitta@codeaurora.org
Fixes: b9779abb09a8 ("lib: stackdepot: add support to disable stack depot")
Signed-off-by: Vijayanand Jitta <vjitta@codeaurora.org>
Signed-off-by: Andrew Morton <akpm@linux-foundation.org>
---
lib/stackdepot.c | 6 ++++--
1 file changed, 4 insertions(+), 2 deletions(-)
--- a/lib/stackdepot.c~lib-stackdepot-add-support-to-disable-stack-depot-fix-2
+++ a/lib/stackdepot.c
@@ -151,8 +151,10 @@ static struct stack_record **stack_table
static int __init is_stack_depot_disabled(char *str)
{
- kstrtobool(str, &stack_depot_disable);
- if (stack_depot_disable) {
+ int ret;
+
+ ret = kstrtobool(str, &stack_depot_disable);
+ if (!ret && stack_depot_disable) {
pr_info("Stack Depot is disabled\n");
stack_table = NULL;
}
_
Patches currently in -mm which might be from vjitta@codeaurora.org are
lib-stackdepot-add-support-to-disable-stack-depot.patch
lib-stackdepot-add-support-to-disable-stack-depot-fix-2.patch
^ permalink raw reply [flat|nested] only message in thread
only message in thread, other threads:[~2021-02-01 23:43 UTC | newest]
Thread overview: (only message) (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2021-02-01 23:42 + lib-stackdepot-add-support-to-disable-stack-depot-fix-2.patch added to -mm tree akpm
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).