+ drivers-base-memory-fix-an-unlikely-reference-counting-issue-in-__add_memory_block.patch added to -mm tree

+ drivers-base-memory-fix-an-unlikely-reference-counting-issue-in-__add_memory_block.patch added to -mm tree

[Andrew Morton]

The patch titled
     Subject: drivers/base/memory: fix an unlikely reference counting issue in __add_memory_block()
has been added to the -mm tree.  Its filename is
     drivers-base-memory-fix-an-unlikely-reference-counting-issue-in-__add_memory_block.patch

This patch should soon appear at
    https://ozlabs.org/~akpm/mmots/broken-out/drivers-base-memory-fix-an-unlikely-reference-counting-issue-in-__add_memory_block.patch
and later at
    https://ozlabs.org/~akpm/mmotm/broken-out/drivers-base-memory-fix-an-unlikely-reference-counting-issue-in-__add_memory_block.patch

Before you just go and hit "reply", please:
   a) Consider who else should be cc'ed
   b) Prefer to cc a suitable mailing list as well
   c) Ideally: find the original patch on the mailing list and do a
      reply-to-all to that, adding suitable additional cc's

*** Remember to use Documentation/process/submit-checklist.rst when testing your code ***

The -mm tree is included into linux-next and is updated
there every 3-4 working days

------------------------------------------------------
From: Christophe JAILLET <christophe.jaillet@wanadoo.fr>
Subject: drivers/base/memory: fix an unlikely reference counting issue in __add_memory_block()

__add_memory_block() calls both put_device() and device_unregister() when
storing the memory block into the xarray.  This is incorrect because
xarray doesn't take an additional reference and device_unregister()
already calls put_device().

Triggering the issue looks really unlikely and its only effect should be
to log a spurious warning about a ref counted issue.

Link: https://lkml.kernel.org/r/d44c63d78affe844f020dc02ad6af29abc448fc4.1650611702.git.christophe.jaillet@wanadoo.fr
Fixes: 4fb6eabf1037 ("drivers/base/memory.c: cache memory blocks in xarray to accelerate lookup")
Signed-off-by: Christophe JAILLET <christophe.jaillet@wanadoo.fr>
Acked-by: Michal Hocko <mhocko@suse.com>
Reviewed-by: David Hildenbrand <david@redhat.com>
Cc: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
Cc: "Rafael J. Wysocki" <rafael@kernel.org>
Cc: Scott Cheloha <cheloha@linux.vnet.ibm.com>
Cc: Nathan Lynch <nathanl@linux.ibm.com>
Signed-off-by: Andrew Morton <akpm@linux-foundation.org>
---

 drivers/base/memory.c |    5 ++---
 1 file changed, 2 insertions(+), 3 deletions(-)

--- a/drivers/base/memory.c~drivers-base-memory-fix-an-unlikely-reference-counting-issue-in-__add_memory_block
+++ a/drivers/base/memory.c
@@ -636,10 +636,9 @@ static int __add_memory_block(struct mem
 	}
 	ret = xa_err(xa_store(&memory_blocks, memory->dev.id, memory,
 			      GFP_KERNEL));
-	if (ret) {
-		put_device(&memory->dev);
+	if (ret)
 		device_unregister(&memory->dev);
-	}
+
 	return ret;
 }
 
_

Patches currently in -mm which might be from christophe.jaillet@wanadoo.fr are

drivers-base-memory-fix-an-unlikely-reference-counting-issue-in-__add_memory_block.patch