mm-commits.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
* [failures] cflags-add-wunused-but-set-parameter.patch removed from -mm tree
@ 2016-07-12 21:26 akpm
  0 siblings, 0 replies; only message in thread
From: akpm @ 2016-07-12 21:26 UTC (permalink / raw)
  To: adobriyan, mmarek, mm-commits


The patch titled
     Subject: CFLAGS: add -Wunused-but-set-parameter
has been removed from the -mm tree.  Its filename was
     cflags-add-wunused-but-set-parameter.patch

This patch was dropped because it had testing failures

------------------------------------------------------
From: Alexey Dobriyan <adobriyan@gmail.com>
Subject: CFLAGS: add -Wunused-but-set-parameter

-Wunused-but-set-parameter is finding stuff with current allmodconfig:

drivers/misc/mic/scif/scif_dma.c:118:27: warning: parameter 'ep' set but not used [-Wunused-but-set-parameter]
drivers/net/ethernet/qlogic/qlcnic/qlcnic_83xx_hw.c:2156:8: warning: parameter 'function' set but not used [-Wunused-but-set-parameter]
drivers/net/ethernet/ti/tlan.c:1647:59: warning: parameter 'host_int' set but not used [-Wunused-but-set-parameter]
drivers/usb/gadget/udc/pxa27x_udc.c:1828:74: warning: parameter 'driver' set but not used [-Wunused-but-set-parameter]

and judging by changelogs, people were using it before,
but were too scared to touch top level Makefile.

Link: http://lkml.kernel.org/r/20160707214306.GB31678@p183.telecom.by
Signed-off-by: Alexey Dobriyan <adobriyan@gmail.com>
Cc: Michal Marek <mmarek@suse.cz>
Signed-off-by: Andrew Morton <akpm@linux-foundation.org>
---

 Makefile |    1 +
 1 file changed, 1 insertion(+)

diff -puN Makefile~cflags-add-wunused-but-set-parameter Makefile
--- a/Makefile~cflags-add-wunused-but-set-parameter
+++ a/Makefile
@@ -399,6 +399,7 @@ KBUILD_CFLAGS   := -Wall -Wundef -Wstric
 		   -Werror-implicit-function-declaration \
 		   -Wno-format-security \
 		   -std=gnu89
+KBUILD_CFLAGS += -Wunused-but-set-parameter
 
 KBUILD_AFLAGS_KERNEL :=
 KBUILD_CFLAGS_KERNEL :=
_

Patches currently in -mm which might be from adobriyan@gmail.com are

mm-faster-kmalloc_array-kcalloc.patch
ban-config_localversion_auto-with-allmodconfig.patch
ipc-delete-nr_ipc_ns.patch


^ permalink raw reply	[flat|nested] only message in thread

only message in thread, other threads:[~2016-07-12 21:26 UTC | newest]

Thread overview: (only message) (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2016-07-12 21:26 [failures] cflags-add-wunused-but-set-parameter.patch removed from -mm tree akpm

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).