* [merged] madvise_free-thp-fix-madvise_free_huge_pmd-return-value-after-splitting.patch removed from -mm tree
@ 2016-07-19 18:10 akpm
0 siblings, 0 replies; only message in thread
From: akpm @ 2016-07-19 18:10 UTC (permalink / raw)
To: ying.huang, aarcange, ebru.akagunduz, jmarchan, kirill.shutemov,
minchan, vbabka, mm-commits
The patch titled
Subject: madvise_free, thp: fix madvise_free_huge_pmd return value after splitting
has been removed from the -mm tree. Its filename was
madvise_free-thp-fix-madvise_free_huge_pmd-return-value-after-splitting.patch
This patch was dropped because it was merged into mainline or a subsystem tree
------------------------------------------------------
From: Huang Ying <ying.huang@intel.com>
Subject: madvise_free, thp: fix madvise_free_huge_pmd return value after splitting
madvise_free_huge_pmd should return 0 if the fallback PTE operations are
required. In madvise_free_huge_pmd, if part pages of THP are discarded,
the THP will be split and fallback PTE operations should be used if
splitting succeeds. But the original code will make fallback PTE
operations skipped, after splitting succeeds. Fix that via make
madvise_free_huge_pmd return 0 after splitting successfully, so that the
fallback PTE operations will be done.
Link: http://lkml.kernel.org/r/1467135452-16688-1-git-send-email-ying.huang@intel.com
Signed-off-by: "Huang, Ying" <ying.huang@intel.com>
Acked-by: Minchan Kim <minchan@kernel.org>
Cc: "Kirill A. Shutemov" <kirill.shutemov@linux.intel.com>
Cc: Vlastimil Babka <vbabka@suse.cz>
Cc: Jerome Marchand <jmarchan@redhat.com>
Cc: Andrea Arcangeli <aarcange@redhat.com>
Cc: Ebru Akagunduz <ebru.akagunduz@gmail.com>
Signed-off-by: Andrew Morton <akpm@linux-foundation.org>
---
mm/huge_memory.c | 7 +------
1 file changed, 1 insertion(+), 6 deletions(-)
diff -puN mm/huge_memory.c~madvise_free-thp-fix-madvise_free_huge_pmd-return-value-after-splitting mm/huge_memory.c
--- a/mm/huge_memory.c~madvise_free-thp-fix-madvise_free_huge_pmd-return-value-after-splitting
+++ a/mm/huge_memory.c
@@ -1624,14 +1624,9 @@ int madvise_free_huge_pmd(struct mmu_gat
if (next - addr != HPAGE_PMD_SIZE) {
get_page(page);
spin_unlock(ptl);
- if (split_huge_page(page)) {
- put_page(page);
- unlock_page(page);
- goto out_unlocked;
- }
+ split_huge_page(page);
put_page(page);
unlock_page(page);
- ret = 1;
goto out_unlocked;
}
_
Patches currently in -mm which might be from ying.huang@intel.com are
thp-fix-comments-of-__pmd_trans_huge_lock.patch
mm-thp-clean-up-return-value-of-madvise_free_huge_pmd.patch
^ permalink raw reply [flat|nested] only message in thread
only message in thread, other threads:[~2016-07-19 18:10 UTC | newest]
Thread overview: (only message) (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2016-07-19 18:10 [merged] madvise_free-thp-fix-madvise_free_huge_pmd-return-value-after-splitting.patch removed from -mm tree akpm
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).