* [patch 125/126] cgroup: remove unnecessary 0 check from css_from_id()
@ 2016-07-26 22:27 akpm
0 siblings, 0 replies; only message in thread
From: akpm @ 2016-07-26 22:27 UTC (permalink / raw)
To: torvalds, mm-commits, akpm, hannes, kernel, tj, vdavydov
From: Johannes Weiner <hannes@cmpxchg.org>
Subject: cgroup: remove unnecessary 0 check from css_from_id()
css_idr allocation starts at 1, so index 0 will never point to an item.
css_from_id() currently filters that before asking idr_find(), but
idr_find() would also just return NULL, so this is not needed.
Link: http://lkml.kernel.org/r/20160617162427.GC19084@cmpxchg.org
Signed-off-by: Johannes Weiner <hannes@cmpxchg.org>
Cc: Vladimir Davydov <vdavydov@virtuozzo.com>
Cc: Tejun Heo <tj@kernel.org>
Cc: Nikolay Borisov <kernel@kyup.com>
Signed-off-by: Andrew Morton <akpm@linux-foundation.org>
---
kernel/cgroup.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff -puN kernel/cgroup.c~cgroup-remove-unnecessary-0-check-from-css_from_id kernel/cgroup.c
--- a/kernel/cgroup.c~cgroup-remove-unnecessary-0-check-from-css_from_id
+++ a/kernel/cgroup.c
@@ -6166,7 +6166,7 @@ struct cgroup_subsys_state *css_tryget_o
struct cgroup_subsys_state *css_from_id(int id, struct cgroup_subsys *ss)
{
WARN_ON_ONCE(!rcu_read_lock_held());
- return id > 0 ? idr_find(&ss->css_idr, id) : NULL;
+ return idr_find(&ss->css_idr, id);
}
/**
_
^ permalink raw reply [flat|nested] only message in thread
only message in thread, other threads:[~2016-07-26 22:27 UTC | newest]
Thread overview: (only message) (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2016-07-26 22:27 [patch 125/126] cgroup: remove unnecessary 0 check from css_from_id() akpm
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).