* [merged] mm-memcontrol-make-the-walk_page_range-limit-obvious.patch removed from -mm tree
@ 2016-10-10 22:45 akpm
0 siblings, 0 replies; only message in thread
From: akpm @ 2016-10-10 22:45 UTC (permalink / raw)
To: james.morse, hannes, mhocko, n-horiguchi, vdavydov, mm-commits
The patch titled
Subject: mm/memcontrol.c: make the walk_page_range() limit obvious
has been removed from the -mm tree. Its filename was
mm-memcontrol-make-the-walk_page_range-limit-obvious.patch
This patch was dropped because it was merged into mainline or a subsystem tree
------------------------------------------------------
From: James Morse <james.morse@arm.com>
Subject: mm/memcontrol.c: make the walk_page_range() limit obvious
mem_cgroup_count_precharge() and mem_cgroup_move_charge() both call
walk_page_range() on the range 0 to ~0UL, neither provide a pte_hole
callback, which causes the current implementation to skip non-vma
regions. This is all fine but follow up changes would like to make
walk_page_range more generic so it is better to be explicit about which
range to traverse so let's use highest_vm_end to explicitly traverse
only user mmaped memory.
[mhocko@kernel.org: rewrote changelog]
Link: http://lkml.kernel.org/r/1472655897-22532-1-git-send-email-james.morse@arm.com
Signed-off-by: James Morse <james.morse@arm.com>
Acked-by: Naoya Horiguchi <n-horiguchi@ah.jp.nec.com>
Cc: Johannes Weiner <hannes@cmpxchg.org>
Cc: Michal Hocko <mhocko@kernel.org>
Cc: Vladimir Davydov <vdavydov@virtuozzo.com>
Signed-off-by: Andrew Morton <akpm@linux-foundation.org>
---
mm/memcontrol.c | 6 ++++--
1 file changed, 4 insertions(+), 2 deletions(-)
diff -puN mm/memcontrol.c~mm-memcontrol-make-the-walk_page_range-limit-obvious mm/memcontrol.c
--- a/mm/memcontrol.c~mm-memcontrol-make-the-walk_page_range-limit-obvious
+++ a/mm/memcontrol.c
@@ -4681,7 +4681,8 @@ static unsigned long mem_cgroup_count_pr
.mm = mm,
};
down_read(&mm->mmap_sem);
- walk_page_range(0, ~0UL, &mem_cgroup_count_precharge_walk);
+ walk_page_range(0, mm->highest_vm_end,
+ &mem_cgroup_count_precharge_walk);
up_read(&mm->mmap_sem);
precharge = mc.precharge;
@@ -4969,7 +4970,8 @@ retry:
* When we have consumed all precharges and failed in doing
* additional charge, the page walk just aborts.
*/
- walk_page_range(0, ~0UL, &mem_cgroup_move_charge_walk);
+ walk_page_range(0, mc.mm->highest_vm_end, &mem_cgroup_move_charge_walk);
+
up_read(&mc.mm->mmap_sem);
atomic_dec(&mc.from->moving_account);
}
_
Patches currently in -mm which might be from james.morse@arm.com are
^ permalink raw reply [flat|nested] only message in thread
only message in thread, other threads:[~2016-10-10 22:45 UTC | newest]
Thread overview: (only message) (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2016-10-10 22:45 [merged] mm-memcontrol-make-the-walk_page_range-limit-obvious.patch removed from -mm tree akpm
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).