mm-commits.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
* [folded-merged] relay-use-irq_work-instead-of-plain-timer-for-deferred-wakeup-checkpatch-fixes.patch removed from -mm tree
@ 2016-10-11 20:37 akpm
  0 siblings, 0 replies; only message in thread
From: akpm @ 2016-10-11 20:37 UTC (permalink / raw)
  To: akpm, akash.goel, mm-commits


The patch titled
     Subject: relay-use-irq_work-instead-of-plain-timer-for-deferred-wakeup-checkpatch-fixes
has been removed from the -mm tree.  Its filename was
     relay-use-irq_work-instead-of-plain-timer-for-deferred-wakeup-checkpatch-fixes.patch

This patch was dropped because it was folded into relay-use-irq_work-instead-of-plain-timer-for-deferred-wakeup.patch

------------------------------------------------------
From: Andrew Morton <akpm@linux-foundation.org>
Subject: relay-use-irq_work-instead-of-plain-timer-for-deferred-wakeup-checkpatch-fixes

ERROR: Please use git commit description style 'commit <12+ chars of sha1> ("<title line>")' - ie: 'commit 0123456789ab ("commit description")'
#12: 
	commit 7c9cb38302e78d24e37f7d8a2ea7eed4ae5f2fa7

WARNING: line over 80 characters
#87: FILE: kernel/relay.c:337:
+	struct rchan_buf *buf = container_of(work, struct rchan_buf, wakeup_work);

WARNING: waitqueue_active without comment
#119: FILE: kernel/relay.c:772:
+		if (waitqueue_active(&buf->read_wait)) {

total: 1 errors, 2 warnings, 70 lines checked

NOTE: For some of the reported defects, checkpatch may be able to
      mechanically convert to the typical style using --fix or --fix-inplace.

./patches/relay-use-irq_work-instead-of-plain-timer-for-deferred-wakeup.patch has style problems, please review.

NOTE: If any of the errors are false positives, please report
      them to the maintainer, see CHECKPATCH in MAINTAINERS.

Please run checkpatch prior to sending patches

Cc: Akash Goel <akash.goel@intel.com>
Signed-off-by: Andrew Morton <akpm@linux-foundation.org>
---

 kernel/relay.c |    4 +++-
 1 file changed, 3 insertions(+), 1 deletion(-)

diff -puN kernel/relay.c~relay-use-irq_work-instead-of-plain-timer-for-deferred-wakeup-checkpatch-fixes kernel/relay.c
--- a/kernel/relay.c~relay-use-irq_work-instead-of-plain-timer-for-deferred-wakeup-checkpatch-fixes
+++ a/kernel/relay.c
@@ -334,7 +334,9 @@ static struct rchan_callbacks default_ch
  */
 static void wakeup_readers(struct irq_work *work)
 {
-	struct rchan_buf *buf = container_of(work, struct rchan_buf, wakeup_work);
+	struct rchan_buf *buf;
+
+	buf = container_of(work, struct rchan_buf, wakeup_work);
 	wake_up_interruptible(&buf->read_wait);
 }
 
_

Patches currently in -mm which might be from akpm@linux-foundation.org are

relay-use-irq_work-instead-of-plain-timer-for-deferred-wakeup.patch
ipc-msg-avoid-waking-sender-upon-full-queue-checkpatch-fixes.patch
hung_task-allow-hung_task_panic-when-hung_task_warnings-is-0-fix.patch
fs-use-mapping_set_error-instead-of-opencoded-set_bit-fix.patch


^ permalink raw reply	[flat|nested] only message in thread

only message in thread, other threads:[~2016-10-11 20:37 UTC | newest]

Thread overview: (only message) (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2016-10-11 20:37 [folded-merged] relay-use-irq_work-instead-of-plain-timer-for-deferred-wakeup-checkpatch-fixes.patch removed from -mm tree akpm

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).