mm-commits.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
* + writeback-remove-redundant-if-check.patch added to -mm tree
@ 2016-11-18 23:55 akpm
  0 siblings, 0 replies; only message in thread
From: akpm @ 2016-11-18 23:55 UTC (permalink / raw)
  To: tahsin, mm-commits


The patch titled
     Subject: fs/fs-writeback.c: remove redundant if check
has been added to the -mm tree.  Its filename is
     writeback-remove-redundant-if-check.patch

This patch should soon appear at
    http://ozlabs.org/~akpm/mmots/broken-out/writeback-remove-redundant-if-check.patch
and later at
    http://ozlabs.org/~akpm/mmotm/broken-out/writeback-remove-redundant-if-check.patch

Before you just go and hit "reply", please:
   a) Consider who else should be cc'ed
   b) Prefer to cc a suitable mailing list as well
   c) Ideally: find the original patch on the mailing list and do a
      reply-to-all to that, adding suitable additional cc's

*** Remember to use Documentation/SubmitChecklist when testing your code ***

The -mm tree is included into linux-next and is updated
there every 3-4 working days

------------------------------------------------------
From: Tahsin Erdogan <tahsin@google.com>
Subject: fs/fs-writeback.c: remove redundant if check

b_more_io non-empty check is already preceded by an opposite check.

Link: http://lkml.kernel.org/r/1478591249-30641-1-git-send-email-tahsin@google.com
Signed-off-by: Tahsin Erdogan <tahsin@google.com>
Signed-off-by: Andrew Morton <akpm@linux-foundation.org>
---

 fs/fs-writeback.c |   16 +++++++---------
 1 file changed, 7 insertions(+), 9 deletions(-)

diff -puN fs/fs-writeback.c~writeback-remove-redundant-if-check fs/fs-writeback.c
--- a/fs/fs-writeback.c~writeback-remove-redundant-if-check
+++ a/fs/fs-writeback.c
@@ -1769,15 +1769,13 @@ static long wb_writeback(struct bdi_writ
 		 * become available for writeback. Otherwise
 		 * we'll just busyloop.
 		 */
-		if (!list_empty(&wb->b_more_io))  {
-			trace_writeback_wait(wb, work);
-			inode = wb_inode(wb->b_more_io.prev);
-			spin_lock(&inode->i_lock);
-			spin_unlock(&wb->list_lock);
-			/* This function drops i_lock... */
-			inode_sleep_on_writeback(inode);
-			spin_lock(&wb->list_lock);
-		}
+		trace_writeback_wait(wb, work);
+		inode = wb_inode(wb->b_more_io.prev);
+		spin_lock(&inode->i_lock);
+		spin_unlock(&wb->list_lock);
+		/* This function drops i_lock... */
+		inode_sleep_on_writeback(inode);
+		spin_lock(&wb->list_lock);
 	}
 	spin_unlock(&wb->list_lock);
 	blk_finish_plug(&plug);
_

Patches currently in -mm which might be from tahsin@google.com are

writeback-remove-redundant-if-check.patch


^ permalink raw reply	[flat|nested] only message in thread

only message in thread, other threads:[~2016-11-18 23:56 UTC | newest]

Thread overview: (only message) (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2016-11-18 23:55 + writeback-remove-redundant-if-check.patch added to -mm tree akpm

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).