* + scatterlist-do-not-disable-irqs-in-sg_copy_buffer.patch added to -mm tree
@ 2017-02-07 0:28 akpm
0 siblings, 0 replies; only message in thread
From: akpm @ 2017-02-07 0:28 UTC (permalink / raw)
To: gilad, axboe, ofir.drang, mm-commits
The patch titled
Subject: scatterlist: do not disable IRQs in sg_copy_buffer
has been added to the -mm tree. Its filename is
scatterlist-do-not-disable-irqs-in-sg_copy_buffer.patch
This patch should soon appear at
http://ozlabs.org/~akpm/mmots/broken-out/scatterlist-do-not-disable-irqs-in-sg_copy_buffer.patch
and later at
http://ozlabs.org/~akpm/mmotm/broken-out/scatterlist-do-not-disable-irqs-in-sg_copy_buffer.patch
Before you just go and hit "reply", please:
a) Consider who else should be cc'ed
b) Prefer to cc a suitable mailing list as well
c) Ideally: find the original patch on the mailing list and do a
reply-to-all to that, adding suitable additional cc's
*** Remember to use Documentation/SubmitChecklist when testing your code ***
The -mm tree is included into linux-next and is updated
there every 3-4 working days
------------------------------------------------------
From: Gilad Ben-Yossef <gilad@benyossef.com>
Subject: scatterlist: do not disable IRQs in sg_copy_buffer
Commit 50bed2e2862a ("sg: disable interrupts inside sg_copy_buffer")
introduced disabling interrupts in sg_copy_buffer() since atomic uses of
miter required it due to use of kmap_atomic().
However, as commit 8290e2d2dcbf ("scatterlist: atomic sg_mapping_iter() no
longer needs disabled IRQs") acknowledges disabling interrupts is no
longer needed for calls to kmap_atomic() and therefore unneeded for miter
ops either, so remove it from sg_copy_buffer().
Link: http://lkml.kernel.org/r/1486040150-14109-3-git-send-email-gilad@benyossef.com
Signed-off-by: Gilad Ben-Yossef <gilad@benyossef.com>
Cc: Jens Axboe <axboe@kernel.dk>
Cc: <ofir.drang@arm.com>
Signed-off-by: Andrew Morton <akpm@linux-foundation.org>
---
lib/scatterlist.c | 4 ----
1 file changed, 4 deletions(-)
diff -puN lib/scatterlist.c~scatterlist-do-not-disable-irqs-in-sg_copy_buffer lib/scatterlist.c
--- a/lib/scatterlist.c~scatterlist-do-not-disable-irqs-in-sg_copy_buffer
+++ a/lib/scatterlist.c
@@ -665,7 +665,6 @@ size_t sg_copy_buffer(struct scatterlist
{
unsigned int offset = 0;
struct sg_mapping_iter miter;
- unsigned long flags;
unsigned int sg_flags = SG_MITER_ATOMIC;
if (to_buffer)
@@ -678,8 +677,6 @@ size_t sg_copy_buffer(struct scatterlist
if (!sg_miter_skip(&miter, skip))
return false;
- local_irq_save(flags);
^ permalink raw reply [flat|nested] only message in thread
only message in thread, other threads:[~2017-02-07 0:28 UTC | newest]
Thread overview: (only message) (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2017-02-07 0:28 + scatterlist-do-not-disable-irqs-in-sg_copy_buffer.patch added to -mm tree akpm
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).