+ fork-free-vmapped-stacks-in-cache-when-cpus-are-offline.patch added to -mm tree

* + fork-free-vmapped-stacks-in-cache-when-cpus-are-offline.patch added to -mm tree
@ 2017-02-15  0:12 akpm
  0 siblings, 0 replies; 2+ messages in thread
From: akpm @ 2017-02-15  0:12 UTC (permalink / raw)
  To: hoeun.ryu, ebiederm, keescook, luto, mguzik, mhocko, mingo, oleg,
	tglx, mm-commits


The patch titled
     Subject: kernel/fork.c: free vmapped stacks in cache when cpus are offline
has been added to the -mm tree.  Its filename is
     fork-free-vmapped-stacks-in-cache-when-cpus-are-offline.patch

This patch should soon appear at
    http://ozlabs.org/~akpm/mmots/broken-out/fork-free-vmapped-stacks-in-cache-when-cpus-are-offline.patch
and later at
    http://ozlabs.org/~akpm/mmotm/broken-out/fork-free-vmapped-stacks-in-cache-when-cpus-are-offline.patch

Before you just go and hit "reply", please:
   a) Consider who else should be cc'ed
   b) Prefer to cc a suitable mailing list as well
   c) Ideally: find the original patch on the mailing list and do a
      reply-to-all to that, adding suitable additional cc's

*** Remember to use Documentation/SubmitChecklist when testing your code ***

The -mm tree is included into linux-next and is updated
there every 3-4 working days

------------------------------------------------------
From: Hoeun Ryu <hoeun.ryu@gmail.com>
Subject: kernel/fork.c: free vmapped stacks in cache when cpus are offline

Using virtually mapped stack, kernel stacks are allocated via vmalloc.  In
the current implementation, two stacks per cpu can be cached when tasks
are freed and the cached stacks are used again in task duplications.  but
the cached stacks may remain unfreed even when cpu are offline.  By adding
a cpu hotplug callback to free the cached stacks when a cpu goes offline,
the pages of the cached stacks are not wasted.

Link: http://lkml.kernel.org/r/1487076043-17802-1-git-send-email-hoeun.ryu@gmail.com
Signed-off-by: Hoeun Ryu <hoeun.ryu@gmail.com>
Reviewed-by: Thomas Gleixner <tglx@linutronix.de>
Acked-by: Michal Hocko <mhocko@suse.com>
Cc: Ingo Molnar <mingo@kernel.org>
Cc: Andy Lutomirski <luto@kernel.org>
Cc: Kees Cook <keescook@chromium.org>
Cc: "Eric W. Biederman" <ebiederm@xmission.com>
Cc: Oleg Nesterov <oleg@redhat.com>
Cc: Mateusz Guzik <mguzik@redhat.com>
Signed-off-by: Andrew Morton <akpm@linux-foundation.org>
---

 kernel/fork.c |   23 +++++++++++++++++++++++
 1 file changed, 23 insertions(+)

diff -puN kernel/fork.c~fork-free-vmapped-stacks-in-cache-when-cpus-are-offline kernel/fork.c

--- a/kernel/fork.c~fork-free-vmapped-stacks-in-cache-when-cpus-are-offline
+++ a/kernel/fork.c
@@ -168,6 +168,24 @@ void __weak arch_release_thread_stack(un
  */
 #define NR_CACHED_STACKS 2
 static DEFINE_PER_CPU(struct vm_struct *, cached_stacks[NR_CACHED_STACKS]);
+
+static int free_vm_stack_cache(unsigned int cpu)
+{
+	struct vm_struct **cached_vm_stacks = per_cpu_ptr(cached_stacks, cpu);
+	int i;
+
+	for (i = 0; i < NR_CACHED_STACKS; i++) {
+		struct vm_struct *vm_stack = cached_vm_stacks[i];
+
+		if (!vm_stack)
+			continue;
+
+		vfree(vm_stack->addr);
+		cached_vm_stacks[i] = NULL;
+	}
+
+	return 0;
+}
 #endif
 
 static unsigned long *alloc_thread_stack_node(struct task_struct *tsk, int node)
@@ -454,6 +472,11 @@ void __init fork_init(void)
 	for (i = 0; i < UCOUNT_COUNTS; i++) {
 		init_user_ns.ucount_max[i] = max_threads/2;
 	}
+
+#ifdef CONFIG_VMAP_STACK
+	cpuhp_setup_state(CPUHP_BP_PREPARE_DYN, "fork:vm_stack_cache",
+			  NULL, free_vm_stack_cache);
+#endif
 }
 
 int __weak arch_dup_task_struct(struct task_struct *dst,
_

Patches currently in -mm which might be from hoeun.ryu@gmail.com are

fork-free-vmapped-stacks-in-cache-when-cpus-are-offline.patch


^ permalink raw reply	[flat|nested] 2+ messages in thread