mm-commits.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
* + sched-out-of-line-__update_load_avg.patch added to -mm tree
@ 2017-03-15 21:49 akpm
  0 siblings, 0 replies; only message in thread
From: akpm @ 2017-03-15 21:49 UTC (permalink / raw)
  To: ak, mingo, peterz, mm-commits


The patch titled
     Subject: kernel/sched/fair.c: uninline __update_load_avg()
has been added to the -mm tree.  Its filename is
     sched-out-of-line-__update_load_avg.patch

This patch should soon appear at
    http://ozlabs.org/~akpm/mmots/broken-out/sched-out-of-line-__update_load_avg.patch
and later at
    http://ozlabs.org/~akpm/mmotm/broken-out/sched-out-of-line-__update_load_avg.patch

Before you just go and hit "reply", please:
   a) Consider who else should be cc'ed
   b) Prefer to cc a suitable mailing list as well
   c) Ideally: find the original patch on the mailing list and do a
      reply-to-all to that, adding suitable additional cc's

*** Remember to use Documentation/SubmitChecklist when testing your code ***

The -mm tree is included into linux-next and is updated
there every 3-4 working days

------------------------------------------------------
From: Andi Kleen <ak@linux.intel.com>
Subject: kernel/sched/fair.c: uninline __update_load_avg()

This is a very complex function, which is called in multiple places.  It
is unlikely that inlining or not inlining it makes any difference for its
run time.

This saves around 13k text in my kernel

   text    data     bss     dec     hex filename
9083992 5367600 11116544        25568136        1862388 vmlinux-before-load-avg
9070166 5367600 11116544        25554310        185ed86 vmlinux-load-avg

Link: http://lkml.kernel.org/r/20170315021431.13107-4-andi@firstfloor.org
Signed-off-by: Andi Kleen <ak@linux.intel.com>
Cc: Peter Zijlstra <peterz@infradead.org>
Cc: Ingo Molnar <mingo@elte.hu>
Signed-off-by: Andrew Morton <akpm@linux-foundation.org>
---

 kernel/sched/fair.c |    2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff -puN kernel/sched/fair.c~sched-out-of-line-__update_load_avg kernel/sched/fair.c
--- a/kernel/sched/fair.c~sched-out-of-line-__update_load_avg
+++ a/kernel/sched/fair.c
@@ -2848,7 +2848,7 @@ static u32 __compute_runnable_contrib(u6
  *   load_avg = u_0` + y*(u_0 + u_1*y + u_2*y^2 + ... )
  *            = u_0 + u_1*y + u_2*y^2 + ... [re-labeling u_i --> u_{i+1}]
  */
-static __always_inline int
+static int
 __update_load_avg(u64 now, int cpu, struct sched_avg *sa,
 		  unsigned long weight, int running, struct cfs_rq *cfs_rq)
 {
_

Patches currently in -mm which might be from ak@linux.intel.com are

trace-move-trace_seq_overflowed-out-of-line.patch
sched-out-of-line-__update_load_avg.patch
kref-remove-warn_on-for-null-release-functions.patch
out-of-line-dma_alloc-free_attrs.patch
megasas-remove-expensive-inline-from-megasas_return_cmd.patch
remove-expensive-warn_on-in-pagefault_disabled_dec.patch


^ permalink raw reply	[flat|nested] only message in thread

only message in thread, other threads:[~2017-03-15 21:49 UTC | newest]

Thread overview: (only message) (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2017-03-15 21:49 + sched-out-of-line-__update_load_avg.patch added to -mm tree akpm

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).