* + kdump-print-a-message-in-case-parse_crashkernel_mem-resulted-in-zero-bytes.patch added to -mm tree
@ 2017-11-15 0:19 akpm
0 siblings, 0 replies; only message in thread
From: akpm @ 2017-11-15 0:19 UTC (permalink / raw)
To: dyoung, bhe, bhsharma, vgoyal, mm-commits
The patch titled
Subject: kdump: print a message in case parse_crashkernel_mem resulted in zero bytes
has been added to the -mm tree. Its filename is
kdump-print-a-message-in-case-parse_crashkernel_mem-resulted-in-zero-bytes.patch
This patch should soon appear at
http://ozlabs.org/~akpm/mmots/broken-out/kdump-print-a-message-in-case-parse_crashkernel_mem-resulted-in-zero-bytes.patch
and later at
http://ozlabs.org/~akpm/mmotm/broken-out/kdump-print-a-message-in-case-parse_crashkernel_mem-resulted-in-zero-bytes.patch
Before you just go and hit "reply", please:
a) Consider who else should be cc'ed
b) Prefer to cc a suitable mailing list as well
c) Ideally: find the original patch on the mailing list and do a
reply-to-all to that, adding suitable additional cc's
*** Remember to use Documentation/SubmitChecklist when testing your code ***
The -mm tree is included into linux-next and is updated
there every 3-4 working days
------------------------------------------------------
From: Dave Young <dyoung@redhat.com>
Subject: kdump: print a message in case parse_crashkernel_mem resulted in zero bytes
parse_crashkernel_mem() silently returns if we get zero bytes in the
parsing function. It is useful for debugging to add a message, especially
if the kernel cannot boot correctly.
Add a pr_info instead of pr_warn because it is expected behavior for size
= 0, eg. crashkernel=2G-4G:128M, size will be 0 in case system memory is
less than 2G.
Link: http://lkml.kernel.org/r/20171114080129.GA6115@dhcp-128-65.nay.redhat.com
Signed-off-by: Dave Young <dyoung@redhat.com>
Cc: Baoquan He <bhe@redhat.com>
Cc: Vivek Goyal <vgoyal@redhat.com>
Cc: Bhupesh Sharma <bhsharma@redhat.com>
Signed-off-by: Andrew Morton <akpm@linux-foundation.org>
---
kernel/crash_core.c | 3 ++-
1 file changed, 2 insertions(+), 1 deletion(-)
diff -puN kernel/crash_core.c~kdump-print-a-message-in-case-parse_crashkernel_mem-resulted-in-zero-bytes kernel/crash_core.c
--- a/kernel/crash_core.c~kdump-print-a-message-in-case-parse_crashkernel_mem-resulted-in-zero-bytes
+++ a/kernel/crash_core.c
@@ -108,7 +108,8 @@ static int __init parse_crashkernel_mem(
return -EINVAL;
}
}
- }
+ } else
+ pr_info("crashkernel size resulted in zero bytes\n");
return 0;
}
_
Patches currently in -mm which might be from dyoung@redhat.com are
kdump-print-a-message-in-case-parse_crashkernel_mem-resulted-in-zero-bytes.patch
^ permalink raw reply [flat|nested] only message in thread
only message in thread, other threads:[~2017-11-15 0:19 UTC | newest]
Thread overview: (only message) (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2017-11-15 0:19 + kdump-print-a-message-in-case-parse_crashkernel_mem-resulted-in-zero-bytes.patch added to -mm tree akpm
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).