* [PATCH 1/3] net: phy: micrel: Staticize ksz8873mll_read_status()
@ 2013-08-06 8:29 Jingoo Han
2013-08-07 23:59 ` David Miller
0 siblings, 1 reply; 2+ messages in thread
From: Jingoo Han @ 2013-08-06 8:29 UTC (permalink / raw)
To: David S. Miller; +Cc: netdev, Hector Palacios, David J. Choi, Jingoo Han
ksz8873mll_read_status() is used only in this file.
Fix the following sparse warning:
drivers/net/phy/micrel.c:147:5: warning: symbol 'ksz8873mll_read_status' was not declared. Should it be static?
Signed-off-by: Jingoo Han <jg1.han@samsung.com>
---
drivers/net/phy/micrel.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/net/phy/micrel.c b/drivers/net/phy/micrel.c
index 2510435..9ca4945 100644
--- a/drivers/net/phy/micrel.c
+++ b/drivers/net/phy/micrel.c
@@ -144,7 +144,7 @@ static int ks8051_config_init(struct phy_device *phydev)
#define KSZ8873MLL_GLOBAL_CONTROL_4 0x06
#define KSZ8873MLL_GLOBAL_CONTROL_4_DUPLEX (1 << 6)
#define KSZ8873MLL_GLOBAL_CONTROL_4_SPEED (1 << 4)
-int ksz8873mll_read_status(struct phy_device *phydev)
+static int ksz8873mll_read_status(struct phy_device *phydev)
{
int regval;
--
1.7.10.4
^ permalink raw reply related [flat|nested] 2+ messages in thread
* Re: [PATCH 1/3] net: phy: micrel: Staticize ksz8873mll_read_status()
2013-08-06 8:29 [PATCH 1/3] net: phy: micrel: Staticize ksz8873mll_read_status() Jingoo Han
@ 2013-08-07 23:59 ` David Miller
0 siblings, 0 replies; 2+ messages in thread
From: David Miller @ 2013-08-07 23:59 UTC (permalink / raw)
To: jg1.han; +Cc: netdev, hector.palacios, david.choi
From: Jingoo Han <jg1.han@samsung.com>
Date: Tue, 06 Aug 2013 17:29:35 +0900
> ksz8873mll_read_status() is used only in this file.
> Fix the following sparse warning:
>
> drivers/net/phy/micrel.c:147:5: warning: symbol 'ksz8873mll_read_status' was not declared. Should it be static?
>
> Signed-off-by: Jingoo Han <jg1.han@samsung.com>
Applied.
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2013-08-07 23:54 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2013-08-06 8:29 [PATCH 1/3] net: phy: micrel: Staticize ksz8873mll_read_status() Jingoo Han
2013-08-07 23:59 ` David Miller
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).