From: Alexei Starovoitov <ast@fb.com>
To: Jakub Kicinski <jakub.kicinski@netronome.com>
Cc: Andrey Ignatov <rdna@fb.com>,
Daniel Borkmann <daniel@iogearbox.net>,
Takshak Chahande <ctakshak@fb.com>,
"netdev@vger.kernel.org" <netdev@vger.kernel.org>,
"ast@kernel.org" <ast@kernel.org>,
Kernel Team <Kernel-team@fb.com>,
Stanislav Fomichev <sdf@google.com>
Subject: Re: [PATCH bpf-next] bpftool: Add BPF_F_QUERY_EFFECTIVE support in bpftool cgroup [show|tree]
Date: Tue, 25 Jun 2019 00:40:09 +0000 [thread overview]
Message-ID: <01c2c76b-5a45-aab0-e698-b5a66ab6c2e7@fb.com> (raw)
In-Reply-To: <20190624173005.06430163@cakuba.netronome.com>
On 6/24/19 5:30 PM, Jakub Kicinski wrote:
> On Tue, 25 Jun 2019 00:21:57 +0000, Alexei Starovoitov wrote:
>> On 6/24/19 5:16 PM, Jakub Kicinski wrote:
>>> On Mon, 24 Jun 2019 23:38:11 +0000, Alexei Starovoitov wrote:
>>>> I don't think this patch should be penalized.
>>>> I'd rather see we fix them all.
>>>
>>> So we are going to add this broken option just to remove it?
>>> I don't understand.
>>> I'm happy to spend the 15 minutes rewriting this if you don't
>>> want to penalize Takshak.
>>
>> hmm. I don't understand the 'broken' part.
>> The only issue I see that it could have been local vs global,
>> but they all should have been local.
>
> I don't think all of them. Only --mapcompat and --bpffs. bpffs could
> be argued. On mapcompat I must have not read the patch fully, I was
> under the impression its a global libbpf flag :(
>
> --json, --pretty, --nomount, --debug are global because they affect
> global behaviour of bpftool. The difference here is that we basically
> add a syscall parameter as a global option.
sure. I only disagreed about not touching older flags.
--effective should be local.
If follow up patch means 90% rewrite then revert is better.
If it's 10% fixup then it's different story.
Takshak,
could you check which way is cleaner? Revert and new patch or follow up fix?
But bpftool doesn't have a way to do local, no?
so it's kinda new feature and other flags should become local too.
hence it feels more like follow up. Just my .02
next prev parent reply other threads:[~2019-06-25 0:42 UTC|newest]
Thread overview: 15+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-06-21 22:33 [PATCH bpf-next] bpftool: Add BPF_F_QUERY_EFFECTIVE support in bpftool cgroup [show|tree] Takshak Chahande
2019-06-24 14:22 ` Daniel Borkmann
2019-06-24 21:51 ` Jakub Kicinski
2019-06-24 22:16 ` Andrey Ignatov
2019-06-24 22:43 ` Jakub Kicinski
2019-06-24 23:38 ` Alexei Starovoitov
2019-06-25 0:16 ` Jakub Kicinski
2019-06-25 0:21 ` Alexei Starovoitov
2019-06-25 0:30 ` Jakub Kicinski
2019-06-25 0:40 ` Alexei Starovoitov [this message]
2019-06-25 0:47 ` Jakub Kicinski
2019-06-25 0:57 ` Jakub Kicinski
2019-06-25 1:23 ` Alexei Starovoitov
2019-06-25 1:39 ` Takshak Chahande
2019-06-25 1:22 ` Alexei Starovoitov
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=01c2c76b-5a45-aab0-e698-b5a66ab6c2e7@fb.com \
--to=ast@fb.com \
--cc=Kernel-team@fb.com \
--cc=ast@kernel.org \
--cc=ctakshak@fb.com \
--cc=daniel@iogearbox.net \
--cc=jakub.kicinski@netronome.com \
--cc=netdev@vger.kernel.org \
--cc=rdna@fb.com \
--cc=sdf@google.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).