From: Jakub Kicinski <jakub.kicinski@netronome.com>
To: Andrey Ignatov <rdna@fb.com>
Cc: Daniel Borkmann <daniel@iogearbox.net>,
Takshak Chahande <ctakshak@fb.com>,
"netdev@vger.kernel.org" <netdev@vger.kernel.org>,
"ast@kernel.org" <ast@kernel.org>,
Kernel Team <Kernel-team@fb.com>,
Stanislav Fomichev <sdf@google.com>
Subject: Re: [PATCH bpf-next] bpftool: Add BPF_F_QUERY_EFFECTIVE support in bpftool cgroup [show|tree]
Date: Mon, 24 Jun 2019 15:43:09 -0700 [thread overview]
Message-ID: <20190624154309.5ef3357b@cakuba.netronome.com> (raw)
In-Reply-To: <20190624221558.GA41600@rdna-mbp.dhcp.thefacebook.com>
On Mon, 24 Jun 2019 22:16:02 +0000, Andrey Ignatov wrote:
> Jakub Kicinski <jakub.kicinski@netronome.com> [Mon, 2019-06-24 14:51 -0700]:
> > This is a cgroup-specific flag, right? It should be a parameter
> > to cgroup show, not a global flag. Can we please drop this patch
> > from the tree?
>
> Hey Jakub,
>
> I had same thought about cgroup-specific flag while reviewing the patch,
> but then found out that all flags in bpftool are now global, no mater if
> they're sub-command-specific or not.
>
> For example, --mapcompat is used only in prog-subcommand, but the option
> is global; --bpffs is used in prog- and map-subcommands, but the option
> is global as well, etc (there are more examples).
I don't think these are equivalent. BPF_F_QUERY_EFFECTIVE is a flag
for a syscall corresponding to a subcommand quite clearly.
> I agree that limiting the scope of an option is a good idea in the long
> term and it'd be great to rework all existing options to be available
> only for corresponding sub-commands, but I don't see how the new `-e`
> options is different from existing options and why it should be dropped.
Agreed, TBH, but we can't change existing options, people may be using
them. Let's drop the patch and make sure we're not making this mistake
again :)
Thanks!
next prev parent reply other threads:[~2019-06-24 22:43 UTC|newest]
Thread overview: 15+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-06-21 22:33 [PATCH bpf-next] bpftool: Add BPF_F_QUERY_EFFECTIVE support in bpftool cgroup [show|tree] Takshak Chahande
2019-06-24 14:22 ` Daniel Borkmann
2019-06-24 21:51 ` Jakub Kicinski
2019-06-24 22:16 ` Andrey Ignatov
2019-06-24 22:43 ` Jakub Kicinski [this message]
2019-06-24 23:38 ` Alexei Starovoitov
2019-06-25 0:16 ` Jakub Kicinski
2019-06-25 0:21 ` Alexei Starovoitov
2019-06-25 0:30 ` Jakub Kicinski
2019-06-25 0:40 ` Alexei Starovoitov
2019-06-25 0:47 ` Jakub Kicinski
2019-06-25 0:57 ` Jakub Kicinski
2019-06-25 1:23 ` Alexei Starovoitov
2019-06-25 1:39 ` Takshak Chahande
2019-06-25 1:22 ` Alexei Starovoitov
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20190624154309.5ef3357b@cakuba.netronome.com \
--to=jakub.kicinski@netronome.com \
--cc=Kernel-team@fb.com \
--cc=ast@kernel.org \
--cc=ctakshak@fb.com \
--cc=daniel@iogearbox.net \
--cc=netdev@vger.kernel.org \
--cc=rdna@fb.com \
--cc=sdf@google.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).