* About tcp: set timestamps for restored skb-s
@ 2013-08-18 0:39 Eric Dumazet
2013-08-20 20:08 ` David Miller
0 siblings, 1 reply; 3+ messages in thread
From: Eric Dumazet @ 2013-08-18 0:39 UTC (permalink / raw)
To: Andrey Vagin; +Cc: netdev
Because of gmail.com problems, I missed lot of netdev traffic
Related to :
http://patchwork.ozlabs.org/patch/267678/
diff --git a/net/ipv4/tcp.c b/net/ipv4/tcp.c
index 5423223..b2f6c74 100644
--- a/net/ipv4/tcp.c
+++ b/net/ipv4/tcp.c
@@ -1121,6 +1121,13 @@ new_segment:
goto wait_for_memory;
/*
+ * All packets are restored as if they have
+ * already been sent.
+ */
+ if (tp->repair)
+ TCP_SKB_CB(skb)->when = tcp_time_stamp;
+
The test could be removed.
Setting @when for regular sends seems harmless
^ permalink raw reply related [flat|nested] 3+ messages in thread
* Re: About tcp: set timestamps for restored skb-s
2013-08-18 0:39 About tcp: set timestamps for restored skb-s Eric Dumazet
@ 2013-08-20 20:08 ` David Miller
2013-08-20 20:30 ` Eric Dumazet
0 siblings, 1 reply; 3+ messages in thread
From: David Miller @ 2013-08-20 20:08 UTC (permalink / raw)
To: eric.dumazet; +Cc: avagin, netdev
From: Eric Dumazet <eric.dumazet@gmail.com>
Date: Sat, 17 Aug 2013 17:39:36 -0700
> Because of gmail.com problems, I missed lot of netdev traffic
>
> Related to :
>
> http://patchwork.ozlabs.org/patch/267678/
>
>
> diff --git a/net/ipv4/tcp.c b/net/ipv4/tcp.c
> index 5423223..b2f6c74 100644
> --- a/net/ipv4/tcp.c
> +++ b/net/ipv4/tcp.c
> @@ -1121,6 +1121,13 @@ new_segment:
> goto wait_for_memory;
>
> /*
> + * All packets are restored as if they have
> + * already been sent.
> + */
> + if (tp->repair)
> + TCP_SKB_CB(skb)->when = tcp_time_stamp;
> +
>
> The test could be removed.
>
> Setting @when for regular sends seems harmless
I applied this before reading this, sorry.
It can be cleaned up in net-next eventually.
^ permalink raw reply [flat|nested] 3+ messages in thread
* Re: About tcp: set timestamps for restored skb-s
2013-08-20 20:08 ` David Miller
@ 2013-08-20 20:30 ` Eric Dumazet
0 siblings, 0 replies; 3+ messages in thread
From: Eric Dumazet @ 2013-08-20 20:30 UTC (permalink / raw)
To: David Miller; +Cc: avagin, netdev
On Tue, 2013-08-20 at 13:08 -0700, David Miller wrote:
>
> I applied this before reading this, sorry.
>
> It can be cleaned up in net-next eventually.
No worries, this was a minor comment, thanks ;)
^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2013-08-20 20:30 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2013-08-18 0:39 About tcp: set timestamps for restored skb-s Eric Dumazet
2013-08-20 20:08 ` David Miller
2013-08-20 20:30 ` Eric Dumazet
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).