* [PATCH 3/4] ip_tunnel: delete unneeded call to netdev_priv
@ 2014-05-15 3:43 Julia Lawall
2014-05-15 20:58 ` David Miller
0 siblings, 1 reply; 2+ messages in thread
From: Julia Lawall @ 2014-05-15 3:43 UTC (permalink / raw)
To: David S. Miller
Cc: kernel-janitors, Alexey Kuznetsov, James Morris,
Hideaki YOSHIFUJI, Patrick McHardy, netdev, linux-kernel
From: Julia Lawall <Julia.Lawall@lip6.fr>
Netdev_priv is an accessor function, and has no purpose if its result is
not used.
A simplified version of the semantic match that fixes this problem is as
follows: (http://coccinelle.lip6.fr/)
// <smpl>
@@ local idexpression x; @@
-x = netdev_priv(...);
... when != x
// </smpl>
Signed-off-by: Julia Lawall <Julia.Lawall@lip6.fr>
---
net/ipv4/ip_tunnel.c | 3 +--
1 file changed, 1 insertion(+), 2 deletions(-)
diff --git a/net/ipv4/ip_tunnel.c b/net/ipv4/ip_tunnel.c
index b3f8597..059176d 100644
--- a/net/ipv4/ip_tunnel.c
+++ b/net/ipv4/ip_tunnel.c
@@ -395,11 +395,10 @@ static struct ip_tunnel *ip_tunnel_create(struct net *net,
struct ip_tunnel_net *itn,
struct ip_tunnel_parm *parms)
{
- struct ip_tunnel *nt, *fbt;
+ struct ip_tunnel *nt;
struct net_device *dev;
BUG_ON(!itn->fb_tunnel_dev);
- fbt = netdev_priv(itn->fb_tunnel_dev);
dev = __ip_tunnel_create(net, itn->fb_tunnel_dev->rtnl_link_ops, parms);
if (IS_ERR(dev))
return ERR_CAST(dev);
^ permalink raw reply related [flat|nested] 2+ messages in thread
* Re: [PATCH 3/4] ip_tunnel: delete unneeded call to netdev_priv
2014-05-15 3:43 [PATCH 3/4] ip_tunnel: delete unneeded call to netdev_priv Julia Lawall
@ 2014-05-15 20:58 ` David Miller
0 siblings, 0 replies; 2+ messages in thread
From: David Miller @ 2014-05-15 20:58 UTC (permalink / raw)
To: Julia.Lawall
Cc: kernel-janitors, kuznet, jmorris, yoshfuji, kaber, netdev, linux-kernel
From: Julia Lawall <Julia.Lawall@lip6.fr>
Date: Thu, 15 May 2014 05:43:20 +0200
> From: Julia Lawall <Julia.Lawall@lip6.fr>
>
> Netdev_priv is an accessor function, and has no purpose if its result is
> not used.
>
> A simplified version of the semantic match that fixes this problem is as
> follows: (http://coccinelle.lip6.fr/)
>
> // <smpl>
> @@ local idexpression x; @@
> -x = netdev_priv(...);
> ... when != x
> // </smpl>
>
> Signed-off-by: Julia Lawall <Julia.Lawall@lip6.fr>
Applied.
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2014-05-15 20:58 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2014-05-15 3:43 [PATCH 3/4] ip_tunnel: delete unneeded call to netdev_priv Julia Lawall
2014-05-15 20:58 ` David Miller
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).